On Mon, May 22, 2023 at 06:26:01PM +0200, Neil Armstrong wrote: > The PM8550 PWM modules are compatible with the PM8350c PWM modules, > document the PM8350c PWM compatible as fallback for the PM8550 PWM. > > Signed-off-by: Neil Armstrong I suppose you picked "items/enum", rather than "items/const" to reduce future churn? Reviewed-by: Conor Dooley Thanks, Conor. > --- > .../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++--------- > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > index 6295c91f43e8..fa378ee05c16 100644 > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > @@ -16,18 +16,24 @@ description: > > > properties: > compatible: > - enum: > - - qcom,pm660l-lpg > - - qcom,pm8150b-lpg > - - qcom,pm8150l-lpg > - - qcom,pm8350c-pwm > - - qcom,pm8916-pwm > - - qcom,pm8941-lpg > - - qcom,pm8994-lpg > - - qcom,pmc8180c-lpg > - - qcom,pmi8994-lpg > - - qcom,pmi8998-lpg > - - qcom,pmk8550-pwm > + oneOf: > + - enum: > + - qcom,pm660l-lpg > + - qcom,pm8150b-lpg > + - qcom,pm8150l-lpg > + - qcom,pm8350c-pwm > + - qcom,pm8916-pwm > + - qcom,pm8941-lpg > + - qcom,pm8994-lpg > + - qcom,pmc8180c-lpg > + - qcom,pmi8994-lpg > + - qcom,pmi8998-lpg > + - qcom,pmk8550-pwm > + - items: > + - enum: > + - qcom,pm8550-pwm > + - const: qcom,pm8350c-pwm > + > > "#pwm-cells": > const: 2 > > --- > base-commit: 44c026a73be8038f03dbdeef028b642880cf1511 > change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d > > Best regards, > -- > Neil Armstrong >