From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA28C77B73 for ; Mon, 22 May 2023 17:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjEVRjj (ORCPT ); Mon, 22 May 2023 13:39:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbjEVRji (ORCPT ); Mon, 22 May 2023 13:39:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E37F9DB; Mon, 22 May 2023 10:39:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7825362334; Mon, 22 May 2023 17:39:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D108AC433D2; Mon, 22 May 2023 17:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684777176; bh=Kk6mby5P1tf8oTeyObXljroIwmNVqfqbu+Q9j5a2xb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DnRSE3VBaPYHZ+XI5MyAO5m9rXr+zZ/6NY6dwsgM76rLJ5C/HIcZqIeZ8FgzOKCkN m6782JCKSHNmvo21eUQhoCKVLQ4V2NBOHfQBaWVcfd4VsprgyNT1vibL3uCihCaAZ7 0s+jkXSsSMaW7JHi6m0XiLFfYgJptF3L7RtwtxFJ3MHsokArrotEAT4uuTESKU/sN0 BjubL2KsMix0q2UXFaAEs9t81WGmHBFr70UOVtkQFyJ3+Z/0lL3CNJUT+B+3HQQwc9 qdBgK4ZLNwcn4CGj2JWmc5BOq7QYOl5/SuCTr4FgVKG1sWnyXHuZfNV39hUNusdHfI shOsr/rj3UNVg== Date: Mon, 22 May 2023 18:39:32 +0100 From: Conor Dooley To: Neil Armstrong Cc: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible Message-ID: <20230522-childhood-eastbound-06a5f02f1f4a@spud> References: <20230522-topic-sm8550-upstream-pm8550-lpg-v1-1-f016578d9e63@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1qfQUUVRK2UvHwkM" Content-Disposition: inline In-Reply-To: <20230522-topic-sm8550-upstream-pm8550-lpg-v1-1-f016578d9e63@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --1qfQUUVRK2UvHwkM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 22, 2023 at 06:26:01PM +0200, Neil Armstrong wrote: > The PM8550 PWM modules are compatible with the PM8350c PWM modules, > document the PM8350c PWM compatible as fallback for the PM8550 PWM. >=20 > Signed-off-by: Neil Armstrong I suppose you picked "items/enum", rather than "items/const" to reduce future churn? Reviewed-by: Conor Dooley Thanks, Conor. > --- > .../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++---= ------ > 1 file changed, 18 insertions(+), 12 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/= Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > index 6295c91f43e8..fa378ee05c16 100644 > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > @@ -16,18 +16,24 @@ description: > > =20 > properties: > compatible: > - enum: > - - qcom,pm660l-lpg > - - qcom,pm8150b-lpg > - - qcom,pm8150l-lpg > - - qcom,pm8350c-pwm > - - qcom,pm8916-pwm > - - qcom,pm8941-lpg > - - qcom,pm8994-lpg > - - qcom,pmc8180c-lpg > - - qcom,pmi8994-lpg > - - qcom,pmi8998-lpg > - - qcom,pmk8550-pwm > + oneOf: > + - enum: > + - qcom,pm660l-lpg > + - qcom,pm8150b-lpg > + - qcom,pm8150l-lpg > + - qcom,pm8350c-pwm > + - qcom,pm8916-pwm > + - qcom,pm8941-lpg > + - qcom,pm8994-lpg > + - qcom,pmc8180c-lpg > + - qcom,pmi8994-lpg > + - qcom,pmi8998-lpg > + - qcom,pmk8550-pwm > + - items: > + - enum: > + - qcom,pm8550-pwm > + - const: qcom,pm8350c-pwm > + > =20 > "#pwm-cells": > const: 2 >=20 > --- > base-commit: 44c026a73be8038f03dbdeef028b642880cf1511 > change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d >=20 > Best regards, > --=20 > Neil Armstrong >=20 --1qfQUUVRK2UvHwkM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGuo1AAKCRB4tDGHoIJi 0p6EAQDTIZTlFFa55WeO6xB3Ese2p9pWCG0HVK0S/9lsyT/vQgEAqmnB1lZVPXFo H7E/qCropV1xS+Vq+mRyzXy6AflNGA0= =QH2B -----END PGP SIGNATURE----- --1qfQUUVRK2UvHwkM--