From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Martin Kurbanov <mmkurbanov@sberdevices.ru>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, kernel@sberdevices.ru
Subject: Re: [PATCH v4 2/2] leds: add aw20xx driver
Date: Mon, 22 May 2023 08:14:26 +0100 [thread overview]
Message-ID: <20230522071426.GP404509@google.com> (raw)
In-Reply-To: <CAHp75VdEc9x=v-NU4wqrg-S0vEjqc27JPqZAK0TJsNUc37ZTmg@mail.gmail.com>
On Thu, 18 May 2023, Andy Shevchenko wrote:
> On Wed, May 17, 2023 at 10:52 PM Martin Kurbanov
> <mmkurbanov@sberdevices.ru> wrote:
> >
> > This commit adds support for AWINIC AW20036/AW20054/AW20072 LED driver.
> > This driver supports following AW200XX features:
> > - Individual 64-level DIM currents
>
> With or without below
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> ...
>
> > +static int aw200xx_probe_dt(struct device *dev, struct aw200xx *chip)
>
> _dt is not fully correct suffix, it's now firmware properties, so perhaps _fw?
>
> ...
>
> I would do
>
> i = 0;
>
> here and drop the assignment in the definition block to be more robust
"here" where?
You've removed all context.
> against sudden reuse of i in between.
>
> > + device_for_each_child_node(dev, child) {
>
> > + i++;
> > + }
>
> --
> With Best Regards,
> Andy Shevchenko
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-05-22 7:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 19:52 [PATCH v4 0/2] leds: add aw20xx driver Martin Kurbanov
2023-05-17 19:52 ` [PATCH v4 1/2] dt-bindings: leds: add binding for aw200xx Martin Kurbanov
2023-05-17 19:52 ` [PATCH v4 2/2] leds: add aw20xx driver Martin Kurbanov
2023-05-18 10:44 ` Andy Shevchenko
2023-05-22 7:14 ` Lee Jones [this message]
2023-05-22 9:35 ` Andy Shevchenko
2023-05-22 16:35 ` Lee Jones
2023-05-22 18:52 ` Andy Shevchenko
2023-05-23 9:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522071426.GP404509@google.com \
--to=lee@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mmkurbanov@sberdevices.ru \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).