From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FDA8C7EE2E for ; Tue, 23 May 2023 09:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbjEWJHM (ORCPT ); Tue, 23 May 2023 05:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236339AbjEWJGw (ORCPT ); Tue, 23 May 2023 05:06:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 944CA118; Tue, 23 May 2023 02:06:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A42462555; Tue, 23 May 2023 09:06:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82939C4339B; Tue, 23 May 2023 09:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684832810; bh=5AHcJMuMuyYhhAsyGVbPQl1L5/pgWSOiDxGcQFt0A2I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MBcfyAbRHVYm6FQ+aE1bIUk41h7kZ4HW51VRE0eDzTBbLzDq0pL0VluiST4Ib6PNn R6M1ySA5PNQPtvYdpKGYyGm0Tpzi2f4QEB8TuPKOHH43SsAhHH/70pndSjLz7owvVe 1Tefq0777T0sIghCOgWwSQLwabtKoZgSYYqu7OOYNtTkehWD5ZxAqTomXz1QQpnTcf R6kKq7qVeWWnGaQ7UTxrW7B8ibd27fF4t1eNvdn4ZX01IhI3nU+ew5N46fMqOMnPyR HywRVAqtaSce0BuJE5XnNcak0pQkAZ0t8EkvY57TrnlvKHpDlWvzcmut67uTW+zRIP MEFqkz+LDm74w== Date: Tue, 23 May 2023 10:06:45 +0100 From: Lee Jones To: Andy Shevchenko Cc: Martin Kurbanov , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v4 2/2] leds: add aw20xx driver Message-ID: <20230523090645.GD2174496@google.com> References: <20230517195238.34069-1-mmkurbanov@sberdevices.ru> <20230517195238.34069-3-mmkurbanov@sberdevices.ru> <20230522071426.GP404509@google.com> <20230522163537.GR404509@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, 22 May 2023, Andy Shevchenko wrote: > On Mon, May 22, 2023 at 7:35 PM Lee Jones wrote: > > On Mon, 22 May 2023, Andy Shevchenko wrote: > > > On Mon, May 22, 2023 at 10:14 AM Lee Jones wrote: > > > > On Thu, 18 May 2023, Andy Shevchenko wrote: > > > > > On Wed, May 17, 2023 at 10:52 PM Martin Kurbanov > > > > > wrote: > > ... > > > > > > I would do > > > > > > > > > > i = 0; > > > > > > > > > > here and drop the assignment in the definition block to be more robust > > > > > > > > "here" where? > > > > > > > You've removed all context. > > > > > > That's not true. The below line exclusively defines the location in > > > the code that I'm talking about. Note, Martin understood that AFAICT > > > and addressed in the new version. > > > > I'd expect the author to have a solid understanding of the code. I > > found this difficult to read as-was and had to go look at the patch to > > understand it. > > I see your point. > > > No biggy. Just something to bear in mind. > > No worries, and thanks for the remark. I'll try my best to satisfy > others and not only the author of the code in the future reviews. Thanks mate. -- Lee Jones [李琼斯]