[PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[Krzysztof Kozlowski]

Document compatible for PM8550 Torch and Flash LED controller.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
index ffacf703d9f9..074ef7e63c49 100644
--- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
+++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,pm8150c-flash-led
           - qcom,pm8150l-flash-led
           - qcom,pm8350c-flash-led
+          - qcom,pm8550-flash-led
       - const: qcom,spmi-flash-led
 
   reg:
-- 
2.34.1

[PATCH 2/3] arm64: dts: qcom: pm8550: add flash LED controller

[Krzysztof Kozlowski]

Add node for PM8550 PMIC flash LED controller.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm8550.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8550.dtsi b/arch/arm64/boot/dts/qcom/pm8550.dtsi
index 46396ec1a330..33f357a80636 100644
--- a/arch/arm64/boot/dts/qcom/pm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8550.dtsi
@@ -55,5 +55,11 @@ pm8550_gpios: gpio@8800 {
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
+
+		pm8550_flash: led-controller@ee00 {
+			compatible = "qcom,pm8550-flash-led", "qcom,spmi-flash-led";
+			reg = <0xee00>;
+			status = "disabled";
+		};
 	};
 };
-- 
2.34.1

[PATCH 3/3] arm64: dts: qcom: sm8550-qrd: add flash LEDs

[Krzysztof Kozlowski]

Enable PM8550 PMIC flash LED controller and add two flash LEDs using
four current outputs.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Context in the patch depends on:
https://lore.kernel.org/linux-arm-msm/20230516133011.108093-1-krzysztof.kozlowski@linaro.org/T/#t
---
 arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index 88b7d3ecdbc9..30b36a149125 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include "sm8550.dtsi"
 #include "pm8010.dtsi"
@@ -451,6 +452,30 @@ &pcie0_phy {
 	status = "okay";
 };
 
+&pm8550_flash {
+	status = "okay";
+
+	led-0 {
+		function = LED_FUNCTION_FLASH;
+		color = <LED_COLOR_ID_YELLOW>;
+		led-sources = <1>, <4>;
+		led-max-microamp = <500000>;
+		flash-max-microamp = <2000000>;
+		flash-max-timeout-us = <1280000>;
+		function-enumerator = <0>;
+	};
+
+	led-1 {
+		function = LED_FUNCTION_FLASH;
+		color = <LED_COLOR_ID_WHITE>;
+		led-sources = <2>, <3>;
+		led-max-microamp = <500000>;
+		flash-max-microamp = <2000000>;
+		flash-max-timeout-us = <1280000>;
+		function-enumerator = <1>;
+	};
+};
+
 &pm8550b_eusb2_repeater {
 	vdd18-supply = <&vreg_l15b_1p8>;
 	vdd3-supply = <&vreg_l5b_3p1>;
-- 
2.34.1

Re: [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

On Tue, May 16, 2023 at 05:02:00PM +0200, Krzysztof Kozlowski wrote:
> Document compatible for PM8550 Torch and Flash LED controller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/3] arm64: dts: qcom: pm8550: add flash LED controller

[Konrad Dybcio]

On 16.05.2023 17:02, Krzysztof Kozlowski wrote:
> Add node for PM8550 PMIC flash LED controller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/pm8550.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8550.dtsi b/arch/arm64/boot/dts/qcom/pm8550.dtsi
> index 46396ec1a330..33f357a80636 100644
> --- a/arch/arm64/boot/dts/qcom/pm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8550.dtsi
> @@ -55,5 +55,11 @@ pm8550_gpios: gpio@8800 {
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
> +
> +		pm8550_flash: led-controller@ee00 {
> +			compatible = "qcom,pm8550-flash-led", "qcom,spmi-flash-led";
> +			reg = <0xee00>;
> +			status = "disabled";
> +		};
>  	};
>  };

Re: [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: add flash LEDs

[Konrad Dybcio]

On 16.05.2023 17:02, Krzysztof Kozlowski wrote:
> Enable PM8550 PMIC flash LED controller and add two flash LEDs using
> four current outputs.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Context in the patch depends on:
> https://lore.kernel.org/linux-arm-msm/20230516133011.108093-1-krzysztof.kozlowski@linaro.org/T/#t
> ---
>  arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> index 88b7d3ecdbc9..30b36a149125 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> @@ -5,6 +5,7 @@
>  
>  /dts-v1/;
>  
> +#include <dt-bindings/leds/common.h>
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include "sm8550.dtsi"
>  #include "pm8010.dtsi"
> @@ -451,6 +452,30 @@ &pcie0_phy {
>  	status = "okay";
>  };
>  
> +&pm8550_flash {
> +	status = "okay";
> +
> +	led-0 {
> +		function = LED_FUNCTION_FLASH;
> +		color = <LED_COLOR_ID_YELLOW>;
> +		led-sources = <1>, <4>;
> +		led-max-microamp = <500000>;
> +		flash-max-microamp = <2000000>;
That's some serious LEDs!

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +		flash-max-timeout-us = <1280000>;
> +		function-enumerator = <0>;
> +	};
> +
> +	led-1 {
> +		function = LED_FUNCTION_FLASH;
> +		color = <LED_COLOR_ID_WHITE>;
> +		led-sources = <2>, <3>;
> +		led-max-microamp = <500000>;
> +		flash-max-microamp = <2000000>;
> +		flash-max-timeout-us = <1280000>;
> +		function-enumerator = <1>;
> +	};
> +};
> +
>  &pm8550b_eusb2_repeater {
>  	vdd18-supply = <&vreg_l15b_1p8>;
>  	vdd3-supply = <&vreg_l5b_3p1>;

Re: [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[Konrad Dybcio]

On 16.05.2023 17:02, Krzysztof Kozlowski wrote:
> Document compatible for PM8550 Torch and Flash LED controller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> index ffacf703d9f9..074ef7e63c49 100644
> --- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> +++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> @@ -26,6 +26,7 @@ properties:
>            - qcom,pm8150c-flash-led
>            - qcom,pm8150l-flash-led
>            - qcom,pm8350c-flash-led
> +          - qcom,pm8550-flash-led
>        - const: qcom,spmi-flash-led
>  
>    reg:

Re: [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[Lee Jones]

On Wed, 17 May 2023, Konrad Dybcio wrote:

> 
> 
> On 16.05.2023 17:02, Krzysztof Kozlowski wrote:
> > Document compatible for PM8550 Torch and Flash LED controller.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

This should be a Reviewed-by.

Other maintainers might get confused by this and apply the patch via
their own repositories which I'm assuming was not the intention.

> >  Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> > index ffacf703d9f9..074ef7e63c49 100644
> > --- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> > +++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
> > @@ -26,6 +26,7 @@ properties:
> >            - qcom,pm8150c-flash-led
> >            - qcom,pm8150l-flash-led
> >            - qcom,pm8350c-flash-led
> > +          - qcom,pm8550-flash-led
> >        - const: qcom,spmi-flash-led
> >  
> >    reg:

-- 
Lee Jones [李琼斯]

Re: (subset) [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[Bjorn Andersson]

On Tue, 16 May 2023 17:02:00 +0200, Krzysztof Kozlowski wrote:
> Document compatible for PM8550 Torch and Flash LED controller.
> 
> 

Applied, thanks!

[2/3] arm64: dts: qcom: pm8550: add flash LED controller
      commit: cf51d2be057b19f2ef72233788c3211f0781678d
[3/3] arm64: dts: qcom: sm8550-qrd: add flash LEDs
      commit: a158f00cdf68852850df231526ce0df0bb7dc1b4

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add PM8550

[Lee Jones]

On Tue, 16 May 2023, Krzysztof Kozlowski wrote:

> Document compatible for PM8550 Torch and Flash LED controller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

-- 
Lee Jones [李琼斯]