From: Christian Marangi <ansuelsmth@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-leds@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [net-next PATCH v4 05/13] leds: trigger: netdev: introduce check for possible hw control
Date: Mon, 29 May 2023 18:32:35 +0200 [thread overview]
Message-ID: <20230529163243.9555-6-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20230529163243.9555-1-ansuelsmth@gmail.com>
Introduce function to check if the requested mode can use hw control in
preparation for hw control support. Currently everything is handled in
software so can_hw_control will always return false.
Add knob with the new value hw_control in trigger_data struct to
set hw control possible. Useful for future implementation to implement
in set_baseline_state() the required function to set the requested mode
using LEDs hw control ops and in other function to reject set if hw
control is currently active.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/leds/trigger/ledtrig-netdev.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
index c93ac3bc85a6..e1f3cedd5d57 100644
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -51,6 +51,7 @@ struct led_netdev_data {
unsigned long mode;
bool carrier_link_up;
+ bool hw_control;
};
enum led_trigger_netdev_modes {
@@ -91,6 +92,11 @@ static void set_baseline_state(struct led_netdev_data *trigger_data)
}
}
+static bool can_hw_control(struct led_netdev_data *trigger_data)
+{
+ return false;
+}
+
static ssize_t device_name_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
@@ -204,6 +210,8 @@ static ssize_t netdev_led_attr_store(struct device *dev, const char *buf,
else
clear_bit(bit, &trigger_data->mode);
+ trigger_data->hw_control = can_hw_control(trigger_data);
+
set_baseline_state(trigger_data);
return size;
--
2.39.2
next prev parent reply other threads:[~2023-05-29 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 16:32 [net-next PATCH v4 00/13] leds: introduce new LED hw control APIs Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 01/13] leds: add APIs for LEDs hw control Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 02/13] leds: add API to get attached device for LED " Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 03/13] Documentation: leds: leds-class: Document new Hardware driven LEDs APIs Christian Marangi
2023-05-29 17:07 ` Andrew Lunn
2023-05-29 16:32 ` [net-next PATCH v4 04/13] leds: trigger: netdev: refactor code setting device name Christian Marangi
2023-05-29 16:32 ` Christian Marangi [this message]
2023-05-29 16:32 ` [net-next PATCH v4 06/13] leds: trigger: netdev: add basic check for hw control support Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 07/13] leds: trigger: netdev: reject interval store for hw_control Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 08/13] leds: trigger: netdev: add support for LED hw control Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 09/13] leds: trigger: netdev: validate configured netdev Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 10/13] leds: trigger: netdev: init mode if hw control already active Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 11/13] leds: trigger: netdev: expose netdev trigger modes in linux include Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 12/13] net: dsa: qca8k: implement hw_control ops Christian Marangi
2023-05-29 16:32 ` [net-next PATCH v4 13/13] net: dsa: qca8k: add op to get ports netdev Christian Marangi
2023-05-30 5:17 ` [net-next PATCH v4 00/13] leds: introduce new LED hw control APIs Jakub Kicinski
2023-05-30 12:54 ` Andrew Lunn
2023-05-31 9:10 ` patchwork-bot+netdevbpf
2023-05-31 10:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529163243.9555-6-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).