From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC7CC7EE2E for ; Mon, 29 May 2023 16:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjE2QfB (ORCPT ); Mon, 29 May 2023 12:35:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbjE2Qew (ORCPT ); Mon, 29 May 2023 12:34:52 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 553CFBE; Mon, 29 May 2023 09:34:51 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-307d20548adso2072948f8f.0; Mon, 29 May 2023 09:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685378090; x=1687970090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=qJiU1ASrfZmceZZC4eiSm3WS0QnApUvAsP7UJRGu7Co=; b=UjQM7+YVLYGHnFZmtl/O4wixpGGuV4XHFoBoRyt/AzXo7TB3AlLZllQ3lAmg5vvdjM lP9O4FSGU01rRKZoJKXVm35XZ3a2J0SLckVlrn0OkM2Lkgbt/n5uo5irMbeTzxs9N0S9 Naxwttn4fMCd/Ae6hajUXEoTW0T+D78DTz6Vv9b6RpzqahwaR7qfi/uShNcqeoqLY5pv P2R3LtbpwGk2cPjAhf1hU8aLHJn9X/aNpmurRFPVzWP8ENs4N7UsFjUa/qoH2wC+uhST 9LjWLupMmeXsqO5THE9xJKhxvO7H1TzVZ/sM3qCHWmiucMJAh8BR0i4e8YEmgFvKNWrQ ZNUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685378090; x=1687970090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qJiU1ASrfZmceZZC4eiSm3WS0QnApUvAsP7UJRGu7Co=; b=TkMDyD1MYDLAxcUFx/suj9sAWsmfBe41bptt+B58/JDHyyMWyO3THAWTb+cvu6NBlQ 9hdvyxw4bAhXDuXJdTMoZhhFWTOvhQQWtj8yxrghaCZIYMRo9VgpzLK5mQfrdXUJ7hZv GQW0HHm9SUf9I7AAvngF0IEb744QgQ3ZiG0RGChoabylFfFsvMfVibAdzNxsPdz+GQsN i9UvG6X6GPjwNWXTojTurnd/RzgcyqIUJfnOQWbJVLCWVm0Ik1rkUO4f7TlcjlaWKgTo 2Ct4X65rerm9i++FZvMSpl5bnUMHxOWHuOjgRxtqmxwXUssCwYpFg+ksGYrEdIWVKYqR oMdQ== X-Gm-Message-State: AC+VfDzMLRMRxiuIok7TQInFXog34Ea+hKloQ/ioRc5x27ZKGybIfq63 Mzm9MwS9enHaOSmAuNSOH6E= X-Google-Smtp-Source: ACHHUZ6LmavkNiuiaw1OkB4/vaYueucZlXesPwBKXihMiuOc7iNu5z7Z2kZWXDxxwCB+REryY4N+AQ== X-Received: by 2002:adf:df12:0:b0:306:2f8e:d259 with SMTP id y18-20020adfdf12000000b003062f8ed259mr7569897wrl.57.1685378089652; Mon, 29 May 2023 09:34:49 -0700 (PDT) Received: from localhost.localdomain (93-34-93-173.ip49.fastwebnet.it. [93.34.93.173]) by smtp.googlemail.com with ESMTPSA id h14-20020a5d6e0e000000b002ff2c39d072sm417513wrz.104.2023.05.29.09.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 09:34:49 -0700 (PDT) From: Christian Marangi To: Pavel Machek , Lee Jones , Jonathan Corbet , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [net-next PATCH v4 07/13] leds: trigger: netdev: reject interval store for hw_control Date: Mon, 29 May 2023 18:32:37 +0200 Message-Id: <20230529163243.9555-8-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230529163243.9555-1-ansuelsmth@gmail.com> References: <20230529163243.9555-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Reject interval store with hw_control enabled. It's are currently not supported and MUST be set to the default value with hw control enabled. Signed-off-by: Christian Marangi Reviewed-by: Andrew Lunn --- drivers/leds/trigger/ledtrig-netdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c index 2101cbbda707..cb2ec33abc4e 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -265,6 +265,9 @@ static ssize_t interval_store(struct device *dev, unsigned long value; int ret; + if (trigger_data->hw_control) + return -EINVAL; + ret = kstrtoul(buf, 0, &value); if (ret) return ret; -- 2.39.2