From: Lee Jones <lee@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Bjorn Andersson" <quic_bjorande@quicinc.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Anjelique Melendez" <quic_amelende@quicinc.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Caleb Connolly" <caleb.connolly@linaro.org>,
"Steev Klimaszewski" <steev@kali.org>
Subject: Re: [PATCH v2] leds: qcom-lpg: Fix PWM period limits
Date: Fri, 2 Jun 2023 10:19:28 +0100 [thread overview]
Message-ID: <20230602091928.GR449117@google.com> (raw)
In-Reply-To: <ZG4gBE1rqkMIllV3@hovoldconsulting.com>
On Wed, 24 May 2023, Johan Hovold wrote:
> On Mon, May 15, 2023 at 09:26:04AM -0700, Bjorn Andersson wrote:
> > The introduction of high resolution PWM support changed the order of the
> > operations in the calculation of min and max period. The result in both
> > divisions is in most cases a truncation to 0, which limits the period to
> > the range of [0, 0].
> >
> > Both numerators (and denominators) are within 64 bits, so the whole
> > expression can be put directly into the div64_u64, instead of doing it
> > partially.
> >
> > Fixes: b00d2ed37617 ("leds: rgb: leds-qcom-lpg: Add support for high resolution PWM")
> > Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> > Tested-by: Steev Klimaszewski <steev@kali.org>
> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> Tested-by: Johan Hovold <johan+linaro@kernel.org>
>
> Pavel or Lee, could you pick this one up for 6.4 as it fixes a
> regression (e.g. broken backlight on a number of laptops like the X13s)?
I don't presently have any plans for a -fixes submission.
If anyone else would like to submit it, please be my guest:
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-02 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 16:26 [PATCH v2] leds: qcom-lpg: Fix PWM period limits Bjorn Andersson
2023-05-24 14:32 ` Johan Hovold
2023-06-02 9:19 ` Lee Jones [this message]
2023-06-03 15:43 ` Johan Hovold
2023-06-08 12:48 ` Lee Jones
2023-05-25 13:55 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602091928.GR449117@google.com \
--to=lee@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_amelende@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=steev@kali.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).