From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E40CC7EE25 for ; Mon, 12 Jun 2023 11:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235385AbjFLLi7 (ORCPT ); Mon, 12 Jun 2023 07:38:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbjFLLiL (ORCPT ); Mon, 12 Jun 2023 07:38:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09FB77EDD; Mon, 12 Jun 2023 04:27:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B16D61510; Mon, 12 Jun 2023 11:27:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B3C1C433EF; Mon, 12 Jun 2023 11:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686569245; bh=hmHbzFm4Dm33OgsGVFYgS4uUdY2P5aUpwmK7kHrb1KM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CaOjL7+1XFSLdT+BXOGjY401sGoIpWDlfTo9tL/2PExN/CgzzFistaKm13MbtyZb/ 1uh/Z2jqHeyIImqWiZHwWNOzLfZj1oIo+VGfBshyLVruDgdvB78ypxxEpyAXBWgsRk 2lnr0m1ibuR5vLztFdk/lj7Te1axs0dnU8RDezYF7GeEdarEbylaZR7zIwqXUilZuF 2ISzEwnO49VC3LFDhmaXVgE9ifRUMC8baYVPdvVVDGakhL4mCrf2M433dSGjzFnjDZ /JmRy4RvNsNvs/ZKFjvM/4UfbFNKvupYn+aCmg8QKmv2v2h/S/fppATKzk5ldTgK+t 3akJWPU5kr74A== Date: Mon, 12 Jun 2023 12:27:19 +0100 From: Lee Jones To: Andy Shevchenko Cc: Henning Schild , Pavel Machek , Hans de Goede , Mark Gross , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables Message-ID: <20230612112719.GP3635807@google.com> References: <20230524124628.32295-1-henning.schild@siemens.com> <20230524124628.32295-2-henning.schild@siemens.com> <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net> <20230608173027.GL3572061@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, 09 Jun 2023, Andy Shevchenko wrote: > On Thu, Jun 08, 2023 at 06:30:27PM +0100, Lee Jones wrote: > > On Thu, 01 Jun 2023, Andy Shevchenko wrote: > > > On Tue, May 30, 2023 at 05:11:00PM +0200, Henning Schild wrote: > > > > Am Sat, 27 May 2023 11:54:08 +0300 > > > > schrieb Andy Shevchenko : > > > > > > > > > On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote: > > > > > > The entries do not seem to be stricly needed when the number of > > > > > > entries is given via the number of LEDs. But adding them is a > > > > > > safeguard should anyone ever iterate over the tables to their end, > > > > > > it also gets us in line with other drivers that register > > > > > > "leds-gpio" tables. > > > > > > > > > > Reported-by? > > > > > Reviewed-by: Andy Shevchenko > > > > > > > > I think we could do > > > > > > > > Reported-by: Andy Shevchenko > > > > > > > > on merge. But i would not want to send the whole series again for that > > > > one line. > > > > > > Since you added it, `b4` will happily take it, I believe no manual work even > > > needed for that, thank you! > > > > b4 didn't pick this up. Nor the whole-series Ack provided by Hans. > > > > I added both manually. > > There is an option to take this > > -t, --apply-cover-trailers > Apply trailers sent to the cover letter to all patches > > have you tried it? Doesn't look like it: b4 am -3 -slt -P_ -o - ${id} | git am -3 --reject Can't remember if I had it before then removed it, or never had it. I'll attempt to add it now and see what happens. -- Lee Jones [李琼斯]