From: Stephan Gerhold <stephan@gerhold.net>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Nikita Travkin <nikita@trvn.ru>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Lin,
Meng-Bo" <linmengbo0689@protonmail.com>,
Stephan Gerhold <stephan@gerhold.net>
Subject: [PATCH v3 0/3] leds: aw2013: Document interrupt and pull-up supply
Date: Tue, 15 Aug 2023 19:21:03 +0200 [thread overview]
Message-ID: <20230815-aw2013-vio-v3-0-2505296b0856@gerhold.net> (raw)
AW2013 has an optional interrupt pin "INTN" which is used to report
completion of started operations (e.g. power up or LED breath effects).
The driver does not use it (yet) but it should be already described for
completeness inside the DT schema.
Since the interrupt and I2C lines operate in open drain low active mode
a pull-up supply is needed for correct operation. Unfortunately there
is no ideal place to describe it in the DT: The pull-up needed for the
I2C lines could be described on the I2C bus. However, the pull-up
needed for the interrupt line belongs neither directly to the interrupt
controller nor to AW2013. Since the AW2013 driver will be typically in
control of the power management and interrupt masking it makes more
sense to describe it inside the AW2013 device tree node.
Changes in v3:
- Rewrite commit messages based on discussion on v2
- Also document missing interrupt in DT schema (new patch)
Discussion on v2:
https://lore.kernel.org/linux-leds/20230321220825.GA1685482-robh@kernel.org/
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
Lin, Meng-Bo (1):
leds: aw2013: Enable pull-up supply for interrupt and I2C
Stephan Gerhold (2):
dt-bindings: leds: aw2013: Document interrupt
dt-bindings: leds: Document pull-up supply for interrupt and I2C
.../devicetree/bindings/leds/leds-aw2013.yaml | 13 ++++++++
drivers/leds/leds-aw2013.c | 36 +++++++++++++---------
2 files changed, 35 insertions(+), 14 deletions(-)
---
base-commit: 841165267827955bb3295b066cb6a906ba9265c0
change-id: 20230815-aw2013-vio-92a4566c5863
Best regards,
--
Stephan Gerhold <stephan@gerhold.net>
next reply other threads:[~2023-08-15 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 17:21 Stephan Gerhold [this message]
2023-08-15 17:21 ` [PATCH v3 1/3] dt-bindings: leds: aw2013: Document interrupt Stephan Gerhold
2023-08-15 20:31 ` Krzysztof Kozlowski
2023-08-15 17:21 ` [PATCH v3 2/3] dt-bindings: leds: Document pull-up supply for interrupt and I2C Stephan Gerhold
2023-08-15 20:31 ` Krzysztof Kozlowski
2023-08-15 17:21 ` [PATCH v3 3/3] leds: aw2013: Enable " Stephan Gerhold
2023-08-16 5:38 ` [PATCH v3 0/3] leds: aw2013: Document interrupt and pull-up supply Nikita Travkin
2023-08-18 15:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815-aw2013-vio-v3-0-2505296b0856@gerhold.net \
--to=stephan@gerhold.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linmengbo0689@protonmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).