linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Eckert.Florian@googlemail.com, jirislaby@kernel.org,
	pavel@ucw.cz, lee@kernel.org, kabel@kernel.org,
	u.kleine-koenig@pengutronix.de, m.brock@vanmierlo.com,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v5 2/2] leds: ledtrig-tty: add new line mode evaluation
Date: Mon, 23 Oct 2023 14:59:02 +0200	[thread overview]
Message-ID: <2023102333-skewer-reclining-8d04@gregkh> (raw)
In-Reply-To: <c4398f09d5a07672ad77f2100ccae0f4@dev.tdt.de>

On Mon, Oct 23, 2023 at 02:45:55PM +0200, Florian Eckert wrote:
> 
> 
> On 2023-10-23 14:27, Greg KH wrote:
> > On Mon, Oct 23, 2023 at 02:15:55PM +0200, Florian Eckert wrote:
> > > > Again, I thought we had rx/tx already?  If not, how was that controlled
> > > > today?
> > > 
> > > It could not be controlled! The LED flashed when data where
> > > transferred.
> > > This was the only function that the trigger supported.
> > 
> > Ok, then maybe this needs to be a bit longer of a series.  One that does
> > the "tx/rx" feature, as that is needed today, and will be the more
> > complex one, and then one-per-line-setting that you want to apply.
> > 
> > That should make it much easier to review overall, right?
> 
> Sorry for asking, but why should I split the change.
> What is the added value? But if it is necessary, then I will do it.
> 
> Before my change, the trigger could not be configured.
> The LED always flashed when data was transferred.

But you could configure that, right?  on/off, correct?  And now you are
splitting this out into different "options", which are all different.

> Now I can configure for which tty event the LED should flash or be on/off.

Great.

> So that the trigger behaves the same as before (flash on rx/tx
> transmission),
> I set the rx/tx bits in the function ledtrig_tty_activate() with the
> following code. Nothing changes for the user of the trigger.
> 
> /* Enable default rx/tx LED blink */
> set_bit(TRIGGER_TTY_TX, &trigger_data->ttytrigger);
> set_bit(TRIGGER_TTY_RX, &trigger_data->ttytrigger);

I agree, but now you are splitting this up into a much finer grained
feature.

Anyway, just a thought, I'll defer to the LED maintainers here as to how
they want to see this, I thought it would actually be easier this way,
maybe not, your call.

thanks,

greg k-h

  reply	other threads:[~2023-10-23 12:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  9:42 [PATCH v5 0/2] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-23  9:42 ` [PATCH v5 1/2] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-23 10:06   ` Greg KH
2023-10-23  9:42 ` [PATCH v5 2/2] leds: ledtrig-tty: add new line mode evaluation Florian Eckert
2023-10-23 10:06   ` Greg KH
2023-10-23 12:15     ` Florian Eckert
2023-10-23 12:27       ` Greg KH
2023-10-23 12:45         ` Florian Eckert
2023-10-23 12:59           ` Greg KH [this message]
2023-10-23 13:19             ` Florian Eckert
2023-10-28 10:43   ` m.brock
2023-10-30  8:15     ` Florian Eckert
2023-11-04 13:59       ` m.brock
2023-11-06  8:40         ` Florian Eckert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023102333-skewer-reclining-8d04@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Eckert.Florian@googlemail.com \
    --cc=fe@dev.tdt.de \
    --cc=jirislaby@kernel.org \
    --cc=kabel@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.brock@vanmierlo.com \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).