From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Eckert.Florian@googlemail.com, jirislaby@kernel.org,
pavel@ucw.cz, lee@kernel.org, kabel@kernel.org,
u.kleine-koenig@pengutronix.de, m.brock@vanmierlo.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [Patch v7 2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
Date: Mon, 6 Nov 2023 13:56:50 +0100 [thread overview]
Message-ID: <2023110629-scenic-rounding-905f@gregkh> (raw)
In-Reply-To: <20231106123415.3365732-3-fe@dev.tdt.de>
On Mon, Nov 06, 2023 at 01:34:11PM +0100, Florian Eckert wrote:
> The ttyname buffer for the ledtrig_tty_data struct is allocated in the
> sysfs ttyname_store() function. This buffer must be released on trigger
> deactivation. This was missing and is thus a memory leak.
>
> While we are at it, the tty handler in the ledtrig_tty_data struct should
> also be returned in case of the trigger deactivation call.
>
> Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> ---
> drivers/leds/trigger/ledtrig-tty.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c
> index 8ae0d2d284af..3e69a7bde928 100644
> --- a/drivers/leds/trigger/ledtrig-tty.c
> +++ b/drivers/leds/trigger/ledtrig-tty.c
> @@ -168,6 +168,10 @@ static void ledtrig_tty_deactivate(struct led_classdev *led_cdev)
>
> cancel_delayed_work_sync(&trigger_data->dwork);
>
> + kfree(trigger_data->ttyname);
> + tty_kref_put(trigger_data->tty);
> + trigger_data->tty = NULL;
> +
> kfree(trigger_data);
> }
>
> --
> 2.30.2
>
This should be sent independent of your new changes please, as it is a
bugfix for all kernels.
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-06 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 12:34 [Patch v7 0/6] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-11-06 12:34 ` [Patch v7 1/6] tty: add new helper function tty_get_tiocm Florian Eckert
2023-11-06 12:34 ` [Patch v7 2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate Florian Eckert
2023-11-06 12:56 ` Greg KH [this message]
2023-11-06 12:57 ` Greg KH
2023-11-06 12:34 ` [Patch v7 3/6] leds: ledtrig-tty: change logging if get icount failed Florian Eckert
2023-11-06 12:34 ` [Patch v7 4/6] leds: ledtrig-tty: replace mutex with completion Florian Eckert
2023-11-06 12:34 ` [Patch v7 5/6] leds: ledtrig-tty: make rx tx activitate configurable Florian Eckert
2023-11-06 12:34 ` [Patch v7 6/6] leds: ledtrig-tty: add additional line state evaluation Florian Eckert
2023-11-06 13:27 ` m.brock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023110629-scenic-rounding-905f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).