From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: lee.jones@linaro.org
Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
daniel.thompson@linaro.org, jingoohan1@gmail.com, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com
Subject: Re: [PATCH v4 0/4] Add a generic driver for LED-based backlight
Date: Thu, 18 Jul 2019 15:19:44 +0200 [thread overview]
Message-ID: <283d9044-df2d-b176-bea9-7e1520d9cf56@gmail.com> (raw)
In-Reply-To: <20190717141514.21171-1-jjhiblot@ti.com>
On 7/17/19 4:15 PM, Jean-Jacques Hiblot wrote:
> This series aims to add a led-backlight driver, similar to pwm-backlight,
> but using a LED class device underneath.
>
> A few years ago (2015), Tomi Valkeinen posted a series implementing a
> backlight driver on top of a LED device:
> https://patchwork.kernel.org/patch/7293991/
> https://patchwork.kernel.org/patch/7294001/
> https://patchwork.kernel.org/patch/7293981/
>
> The discussion stopped because Tomi lacked the time to work on it.
>
> changes in v4:
> - fix dev_err() messages and commit logs following the advices of Pavel
> - cosmetic changes (indents, getting rid of "? 1 : 0" in
> led_match_led_node())
>
> changes in v3:
> - dt binding: don't limit the brightness range to 0-255. Use the range of
> the underlying LEDs. as a side-effect, all LEDs must now have the same
> range
> - driver: Adapt to dt binding update.
> - driver: rework probe() for clarity and remove the remaining goto.
>
> changes in v2:
> - handle more than one LED.
> - don't make the backlight device a child of the LED controller.
> - make brightness-levels and default-brightness-level optional
> - removed the option to use a GPIO enable.
> - removed the option to use a regulator. It should be handled by the LED
> core
> - don't make any change to the LED core (not needed anymore)
>
> Jean-Jacques Hiblot (2):
> leds: Add managed API to get a LED from a device driver
> dt-bindings: backlight: Add led-backlight binding
>
> Tomi Valkeinen (2):
> leds: Add of_led_get() and led_put()
> backlight: add led-backlight driver
>
> .../bindings/leds/backlight/led-backlight.txt | 28 ++
> drivers/leds/led-class.c | 92 ++++++
> drivers/video/backlight/Kconfig | 7 +
> drivers/video/backlight/Makefile | 1 +
> drivers/video/backlight/led_bl.c | 268 ++++++++++++++++++
> include/linux/leds.h | 6 +
> 6 files changed, 402 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
> create mode 100644 drivers/video/backlight/led_bl.c
>
For the whole set:
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Lee - we need to create immutable branch for this set since there will
be some interfering changes in the LED core in this cycle.
I can create the branch and send the pull request once we will
obtain the ack from Rob for DT bindings, unless you have other
preference.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-07-18 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 14:15 [PATCH v4 0/4] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-07-17 14:15 ` [PATCH v4 1/4] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-07-30 11:02 ` Pavel Machek
2019-07-17 14:15 ` [PATCH v4 2/4] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-07-31 13:23 ` Tomi Valkeinen
2019-07-17 14:15 ` [PATCH v4 3/4] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-07-18 12:30 ` Jacek Anaszewski
2019-07-17 14:15 ` [PATCH v4 4/4] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-09-09 9:53 ` Daniel Thompson
2019-07-18 13:19 ` Jacek Anaszewski [this message]
2019-07-22 7:06 ` [PATCH v4 0/4] Add a generic driver for LED-based backlight Lee Jones
2019-07-22 21:23 ` Jacek Anaszewski
2019-09-08 16:17 ` Jacek Anaszewski
2019-09-09 11:12 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=283d9044-df2d-b176-bea9-7e1520d9cf56@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).