Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] leds: lm3532: Move static keyword to the front of declarations
Date: Tue, 3 Sep 2019 20:51:34 +0200
Message-ID: <30443cb8-cd19-2b0e-7e11-2a272d000696@gmail.com> (raw)
In-Reply-To: <20190830181104.5813-1-kw@linux.com>

Hi Krzysztof,

Thank you for the patch set.

On 8/30/19 8:11 PM, Krzysztof Wilczynski wrote:
> Move the static keyword to the front of declarations ramp_table,
> als_avrg_table and als_imp_table, and resolve the following
> compiler warnings that can be seen when building with warnings
> enabled (W=1):
> 
> drivers/leds/leds-lm3532.c:209:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> 
> drivers/leds/leds-lm3532.c:266:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> 
> drivers/leds/leds-lm3532.c:281:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> 
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
> Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
> 
>  drivers/leds/leds-lm3532.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
> index c5cfd8e3f15f..62ace6698d25 100644
> --- a/drivers/leds/leds-lm3532.c
> +++ b/drivers/leds/leds-lm3532.c
> @@ -208,7 +208,7 @@ static const struct regmap_config lm3532_regmap_config = {
>  	.cache_type = REGCACHE_FLAT,
>  };
>  
> -const static int als_imp_table[LM3532_NUM_IMP_VALS] = {37000, 18500, 12330,
> +static const int als_imp_table[LM3532_NUM_IMP_VALS] = {37000, 18500, 12330,
>  						       92500, 7400, 6170, 5290,
>  						       4630, 4110, 3700, 3360,
>  						       3080, 2850, 2640, 2440,
> @@ -265,7 +265,7 @@ static int lm3532_get_index(const int table[], int size, int value)
>  	return -EINVAL;
>  }
>  
> -const static int als_avrg_table[LM3532_NUM_AVG_VALS] = {17920, 35840, 71680,
> +static const int als_avrg_table[LM3532_NUM_AVG_VALS] = {17920, 35840, 71680,
>  							1433360, 286720, 573440,
>  							1146880, 2293760};
>  static int lm3532_get_als_avg_index(int avg_time)
> @@ -280,7 +280,7 @@ static int lm3532_get_als_avg_index(int avg_time)
>  				avg_time);
>  }
>  
> -const static int ramp_table[LM3532_NUM_RAMP_VALS] = { 8, 1024, 2048, 4096, 8192,
> +static const int ramp_table[LM3532_NUM_RAMP_VALS] = { 8, 1024, 2048, 4096, 8192,
>  						     16384, 32768, 65536};
>  static int lm3532_get_ramp_index(int ramp_time)
>  {
> 

Both 1/2 and 2/2 applied.

-- 
Best regards,
Jacek Anaszewski

      parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30  9:09 [PATCH] leds: " Krzysztof Wilczynski
2019-08-30 15:02 ` Dan Murphy
2019-08-30 15:13   ` Krzysztof Wilczynski
2019-08-30 18:11 ` [PATCH v2 1/2] leds: lm3532: " Krzysztof Wilczynski
2019-08-30 18:11   ` [PATCH v2 2/2] leds: ti-lmu-common: Move static keyword to the front of declaration Krzysztof Wilczynski
2019-09-03 18:51   ` Jacek Anaszewski [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30443cb8-cd19-2b0e-7e11-2a272d000696@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=dmurphy@ti.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org linux-leds@archiver.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/ public-inbox