Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Dan Murphy <dmurphy@ti.com>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding
Date: Tue, 8 Oct 2019 14:51:51 +0200
Message-ID: <30fcd898-aa50-bac2-b316-0d9bf2429369@ti.com> (raw)
In-Reply-To: <CAL_JsqLTqnKpU4PB8Zt9SSPSia5mkFcUgoA8ZyX_1E_HfdFyxg@mail.gmail.com>

Hi Rob,

On 07/10/2019 18:15, Rob Herring wrote:
> Please send DT bindings to DT list or it's never in my queue. IOW,
> send patches to the lists that get_maintainers.pl tells you to.
>
> On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
>> Add DT binding for led-backlight.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>> ---
>>   .../bindings/leds/backlight/led-backlight.txt | 28 +++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
> Please make this a DT schema.

OK.

BTW I used "make dt_binding_check" but had to fix a couple of YAMLs file 
to get it to work. Do you have a kernel tree with already all the YAML 
files in good shape ? Or do you want me to post the changes to 
devicetree@vger.kernel.org ?


>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>> new file mode 100644
>> index 000000000000..4c7dfbe7f67a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>> @@ -0,0 +1,28 @@
>> +led-backlight bindings
>> +
>> +This binding is used to describe a basic backlight device made of LEDs.
>> +It can also be used to describe a backlight device controlled by the output of
>> +a LED driver.
>> +
>> +Required properties:
>> +  - compatible: "led-backlight"
>> +  - leds: a list of LEDs
> 'leds' is already used as a node name and mixing is not ideal.
>
> We already have 'flash-leds' in use and with the same definition, so
> lets continue that and use 'backlight-leds'.
OK
>
>> +
>> +Optional properties:
>> +  - brightness-levels: Array of distinct brightness levels. The levels must be
>> +                       in the range accepted by the underlying LED devices.
>> +                       This is used to translate a backlight brightness level
>> +                       into a LED brightness level. If it is not provided, the
>> +                       identity mapping is used.
>> +
>> +  - default-brightness-level: The default brightness level.
> You can just assume these 2 get a common schema at some point. So just
> need to define any additional constraints if possible.

Maybe we should keep them until such a common schema is written ?

JJ

>
> Rob

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 12:44 [PATCH v9 0/5] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-10-07 12:44 ` [PATCH v9 1/5] leds: populate the device's of_node Jean-Jacques Hiblot
2019-10-07 12:44 ` [PATCH v9 2/5] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-10-07 12:44 ` [PATCH v9 3/5] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-10-13 12:09   ` Pavel Machek
2019-10-07 12:44 ` [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-07 16:15   ` Rob Herring
2019-10-08 12:51     ` Jean-Jacques Hiblot [this message]
2019-10-08 13:30       ` Jean-Jacques Hiblot
2019-10-08 15:00         ` Rob Herring
2019-10-08 17:17           ` Jacek Anaszewski
2019-10-08 17:17           ` Jacek Anaszewski
2019-10-08 20:00             ` Rob Herring
2019-10-09 18:31               ` Jacek Anaszewski
2019-10-08 14:52       ` Rob Herring
2019-10-07 12:44 ` [PATCH v9 5/5] backlight: add led-backlight driver Jean-Jacques Hiblot

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30fcd898-aa50-bac2-b316-0d9bf2429369@ti.com \
    --to=jjhiblot@ti.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dmurphy@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git