From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3065C10F14 for ; Tue, 8 Oct 2019 12:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892F520640 for ; Tue, 8 Oct 2019 12:52:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="C3xkjpdK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730541AbfJHMwF (ORCPT ); Tue, 8 Oct 2019 08:52:05 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:35330 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730249AbfJHMwE (ORCPT ); Tue, 8 Oct 2019 08:52:04 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x98CpsTx127468; Tue, 8 Oct 2019 07:51:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570539114; bh=Dokst5718CmAxTwYuW21IP+idbHKHbrxtnp594hXaJM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=C3xkjpdKNFvvVV5BeRFI8KcgEAItARKGaiuyV4mEnboJjXpRgN69MGEXr6CgzjrXC JYKg5yB8mooAGhQKTnUhJtAx3YVXflHlPeweDoOVAW3BiNe2bst+tquOegdWIyiPnt 9oBIqblHQLu0wS2LUufgyFsR1TGGWEPxLrGFitZ0= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id x98Cps5I098014; Tue, 8 Oct 2019 07:51:54 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 8 Oct 2019 07:51:51 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Oct 2019 07:51:54 -0500 Received: from [10.250.99.146] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x98CppEv035995; Tue, 8 Oct 2019 07:51:52 -0500 Subject: Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding To: Rob Herring CC: Jacek Anaszewski , Pavel Machek , Sebastian Reichel , Mark Rutland , Lee Jones , Daniel Thompson , Dan Murphy , Linux LED Subsystem , "linux-kernel@vger.kernel.org" , dri-devel , Tomi Valkeinen References: <20191007124437.20367-1-jjhiblot@ti.com> <20191007124437.20367-5-jjhiblot@ti.com> From: Jean-Jacques Hiblot Message-ID: <30fcd898-aa50-bac2-b316-0d9bf2429369@ti.com> Date: Tue, 8 Oct 2019 14:51:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi Rob, On 07/10/2019 18:15, Rob Herring wrote: > Please send DT bindings to DT list or it's never in my queue. IOW, > send patches to the lists that get_maintainers.pl tells you to. > > On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot wrote: >> Add DT binding for led-backlight. >> >> Signed-off-by: Jean-Jacques Hiblot >> Reviewed-by: Daniel Thompson >> Reviewed-by: Sebastian Reichel >> --- >> .../bindings/leds/backlight/led-backlight.txt | 28 +++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt > Please make this a DT schema. OK. BTW I used "make dt_binding_check" but had to fix a couple of YAMLs file to get it to work. Do you have a kernel tree with already all the YAML files in good shape ? Or do you want me to post the changes to devicetree@vger.kernel.org ? > >> diff --git a/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt >> new file mode 100644 >> index 000000000000..4c7dfbe7f67a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt >> @@ -0,0 +1,28 @@ >> +led-backlight bindings >> + >> +This binding is used to describe a basic backlight device made of LEDs. >> +It can also be used to describe a backlight device controlled by the output of >> +a LED driver. >> + >> +Required properties: >> + - compatible: "led-backlight" >> + - leds: a list of LEDs > 'leds' is already used as a node name and mixing is not ideal. > > We already have 'flash-leds' in use and with the same definition, so > lets continue that and use 'backlight-leds'. OK > >> + >> +Optional properties: >> + - brightness-levels: Array of distinct brightness levels. The levels must be >> + in the range accepted by the underlying LED devices. >> + This is used to translate a backlight brightness level >> + into a LED brightness level. If it is not provided, the >> + identity mapping is used. >> + >> + - default-brightness-level: The default brightness level. > You can just assume these 2 get a common schema at some point. So just > need to define any additional constraints if possible. Maybe we should keep them until such a common schema is written ? JJ > > Rob