linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	linux-leds@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	devicetree@vger.kernel.org
Subject: Broken LP5562 LEDs since multicolor framework was added
Date: Fri, 30 Apr 2021 16:44:28 +0200	[thread overview]
Message-ID: <36a87582-5565-6eeb-33be-ea57ef63ac15@ysoft.com> (raw)

Hello Dan,

I am in a process of upgrading kernel from v5.5 to v5.10 on our imx6dl-yapp4
platform and I just realized that LEDs on the board stopped working.

I bisected the problem to commit 92a81562e695 ("leds: lp55xx: Add multicolor
framework support to lp55xx"). I found that you also added commit 0724cf4b8b17
("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") to
accommodate the multicolor framework.

It's a pity I was not on the Cc list for that DT change and did not have
chance to test it.

Anyways, probe of the lp5562 driver on my board fails with or without commit
0724cf4b8b17 with this error:

lp5562: probe of 1-0030 failed with error -22

AFAICT the driver fails on the lp55xx_of_populate_pdata call but I did
not get much further.

I checked the updated LED documentation/binding and at first glance
everything looks good and the DT should work.

I have no idea what might be wrong and would appreciate any advice.

Thanks,
Michal




                 reply	other threads:[~2021-04-30 14:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36a87582-5565-6eeb-33be-ea57ef63ac15@ysoft.com \
    --to=michal.vokac@ysoft.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).