From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB77C433E0 for ; Tue, 16 Mar 2021 23:01:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5304B64F4D for ; Tue, 16 Mar 2021 23:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbhCPXBW (ORCPT ); Tue, 16 Mar 2021 19:01:22 -0400 Received: from 1.mo179.mail-out.ovh.net ([178.33.111.220]:46775 "EHLO 1.mo179.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbhCPXA7 (ORCPT ); Tue, 16 Mar 2021 19:00:59 -0400 X-Greylist: delayed 964 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Mar 2021 19:00:58 EDT Received: from player762.ha.ovh.net (unknown [10.110.208.168]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id CE848192FBE for ; Tue, 16 Mar 2021 23:44:52 +0100 (CET) Received: from milecki.pl (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player762.ha.ovh.net (Postfix) with ESMTPSA id B5C461C1A0637; Tue, 16 Mar 2021 22:44:44 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-104R00590ba227f-f0e6-4995-86e5-396bb2d1189f, A1A54852ADC5FECC858E3B1428EFF252DD499A2B) smtp.auth=rafal@milecki.pl X-OVh-ClientIp: 194.187.74.233 Subject: Re: [PATCH] dt-bindings: leds: leds-gpio: fix & extend node regex To: Rob Herring , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Pavel Machek , Dan Murphy , Jacek Anaszewski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, Florian Fainelli References: <20210310070025.9150-1-zajec5@gmail.com> <20210316223122.GA3800914@robh.at.kernel.org> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <37f56e82-f60a-2375-e809-2b12fde5311b@milecki.pl> Date: Tue, 16 Mar 2021 23:44:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210316223122.GA3800914@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 3811171185956523759 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrudefvddgudeiiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeekudehjeehffdufefhgffhgeejjeelteekveeuleevgeekhffhffeiheellefgveenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeeivddrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehrrghfrghlsehmihhlvggtkhhirdhplhdprhgtphhtthhopehlihhnuhigqdhlvggushesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 16.03.2021 23:31, Rob Herring wrote: > On Wed, Mar 10, 2021 at 08:00:25AM +0100, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> The old regex allowed only 1 character to follow the "led-" prefix which >> was most likely just an overlook. > > Indeed. > >> Fix it and while at it allow dashes in >> node names. It allows more meaningful names and it helpful e.g. when >> having the same function name with 2 different colors. For example: >> 1. led-power-white >> 2. led-power-blue > > No, node names are supposed to be generic and reflect the class of > device. There was some extra discussion on this patch that has ended up with a question about numbering nodes. Current binding assumes that nodes should be numbered with independent suffix numbers like: led-0 { }; led-1 { }; led-2 { }; Do you think this could / should be improved somehow? One option I was thinking about was using: led@0 { }; led@5 { }; where numbers ("0", "5") should match GPIO numbers. Is that a valid solution and does it improve things to make it worth it?