From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
pavel@ucw.cz, dmurphy@ti.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: leds-ns2: Add of_node_put() before return
Date: Mon, 15 Jul 2019 21:58:04 +0200 [thread overview]
Message-ID: <39a3ae6b-a8e6-b50a-c5cb-3e00bd3a4d03@gmail.com> (raw)
In-Reply-To: <20190709173420.13949-1-nishkadg.linux@gmail.com>
Hi Nishka,
Thank you for the patch.
Please apply err_node_put scheme similarly like you've already
done that for leds-max77650.
Best regards,
Jacek Anaszewski
On 7/9/19 7:34 PM, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return in
> four places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/leds/leds-ns2.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c
> index f92e2c07c1c6..6e47c21ef1c4 100644
> --- a/drivers/leds/leds-ns2.c
> +++ b/drivers/leds/leds-ns2.c
> @@ -263,12 +263,16 @@ ns2_leds_get_of_pdata(struct device *dev, struct ns2_led_platform_data *pdata)
> struct ns2_led_modval *modval;
>
> ret = of_get_named_gpio(child, "cmd-gpio", 0);
> - if (ret < 0)
> + if (ret < 0) {
> + of_node_put(child);
> return ret;
> + }
> led->cmd = ret;
> ret = of_get_named_gpio(child, "slow-gpio", 0);
> - if (ret < 0)
> + if (ret < 0) {
> + of_node_put(child);
> return ret;
> + }
> led->slow = ret;
> ret = of_property_read_string(child, "label", &string);
> led->name = (ret == 0) ? string : child->name;
> @@ -281,6 +285,7 @@ ns2_leds_get_of_pdata(struct device *dev, struct ns2_led_platform_data *pdata)
> if (ret < 0 || ret % 3) {
> dev_err(dev,
> "Missing or malformed modes-map property\n");
> + of_node_put(child);
> return -EINVAL;
> }
>
> @@ -289,8 +294,10 @@ ns2_leds_get_of_pdata(struct device *dev, struct ns2_led_platform_data *pdata)
> num_modes,
> sizeof(struct ns2_led_modval),
> GFP_KERNEL);
> - if (!modval)
> + if (!modval) {
> + of_node_put(child);
> return -ENOMEM;
> + }
>
> for (i = 0; i < num_modes; i++) {
> of_property_read_u32_index(child,
>
prev parent reply other threads:[~2019-07-15 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:34 [PATCH] leds: leds-ns2: Add of_node_put() before return Nishka Dasgupta
2019-07-15 19:58 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a3ae6b-a8e6-b50a-c5cb-3e00bd3a4d03@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).