From: Dan Murphy <dmurphy@ti.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v17 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
Date: Mon, 2 Dec 2019 07:03:59 -0600 [thread overview]
Message-ID: <3f0b6da2-15ca-a0cf-ba82-8bbb6af3bf81@ti.com> (raw)
In-Reply-To: <20191202090645.GI9767@dragon>
Shawn
On 12/2/19 3:06 AM, Shawn Guo wrote:
> On Thu, Nov 14, 2019 at 07:30:14AM -0600, Dan Murphy wrote:
>> Add the reg property to each channel node. This update is
>> to accomodate the multicolor framework. In addition to the
>> accomodation this allows the LEDs to be placed on any channel
>> and allow designs to skip channels as opposed to requiring
>> sequential order.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> CC: Shawn Guo <shawnguo@kernel.org>
>> CC: Sascha Hauer <s.hauer@pengutronix.de>
>> CC: Pengutronix Kernel Team <kernel@pengutronix.de>
>> CC: Fabio Estevam <festevam@gmail.com>
>> CC: NXP Linux Team <linux-imx@nxp.com>
>> ---
>> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++----
>> 1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> index e8d800fec637..efc466ed1fea 100644
>> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> @@ -257,29 +257,35 @@
>> reg = <0x30>;
>> clock-mode = /bits/ 8 <1>;
>> status = "disabled";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>>
>> - chan0 {
>> + chan@0 {
> Again, why do not we rename it to led@0 as you update the bindings in
> the last patch in the series?
I am trying to limit the amount of change in this patchset.
I know what you are asking is for a small change but that would be
another patch to the series to the label. I want to keep functional
changes like this isolated from clean up changes like you asked for
bissectability.
From that point we can make additional changes. I would really like
this to get into 5.6 as I thought I hit the merge window for 5.5 but it
did not make it.
Dan
next prev parent reply other threads:[~2019-12-02 13:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 13:30 [PATCH v17 00/19] Multicolor Framework Dan Murphy
2019-11-14 13:30 ` [PATCH v17 01/19] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-11-14 13:30 ` [PATCH v17 02/19] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-11-14 13:30 ` [PATCH v17 03/19] " Dan Murphy
2019-11-14 13:30 ` [PATCH v17 04/19] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-11-14 13:30 ` [PATCH v17 05/19] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-11-14 13:30 ` [PATCH v17 06/19] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-11-14 13:30 ` [PATCH v17 07/19] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2019-12-22 18:25 ` Pavel Machek
2019-11-14 13:30 ` [PATCH v17 08/19] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2019-11-14 13:30 ` [PATCH v17 09/19] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2019-12-22 18:27 ` Pavel Machek
2019-11-14 13:30 ` [PATCH v17 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2019-12-02 9:06 ` Shawn Guo
2019-12-02 13:03 ` Dan Murphy [this message]
2019-11-14 13:30 ` [PATCH v17 11/19] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2019-12-22 18:28 ` Pavel Machek
2019-11-14 13:30 ` [PATCH v17 12/19] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2019-12-22 18:30 ` Pavel Machek
2020-01-03 15:44 ` Dan Murphy
2019-11-14 13:30 ` [PATCH v17 13/19] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2019-11-14 13:30 ` [PATCH v17 14/19] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2019-11-14 13:30 ` [PATCH v17 15/19] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2019-11-14 13:30 ` [PATCH v17 16/19] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2019-12-22 18:32 ` Pavel Machek
2019-11-14 13:30 ` [PATCH v17 17/19] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2019-12-22 18:33 ` Pavel Machek
2019-11-14 13:30 ` [PATCH v17 18/19] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
2019-12-22 18:33 ` Pavel Machek
2019-11-14 13:30 ` [PATCH v17 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header Dan Murphy
2019-12-22 18:35 ` Pavel Machek
2020-01-03 15:43 ` Dan Murphy
2019-11-15 14:57 ` [PATCH v17 00/19] Multicolor Framework Martin Fuzzey
2019-12-09 13:22 ` Dan Murphy
2019-12-18 14:45 ` Dan Murphy
2020-01-08 13:48 ` Dan Murphy
2020-01-08 19:09 ` Jacek Anaszewski
2020-01-08 19:12 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f0b6da2-15ca-a0cf-ba82-8bbb6af3bf81@ti.com \
--to=dmurphy@ti.com \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).