From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1336C432C2 for ; Wed, 25 Sep 2019 21:28:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 701E420673 for ; Wed, 25 Sep 2019 21:28:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rvpys1yb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725938AbfIYV2H (ORCPT ); Wed, 25 Sep 2019 17:28:07 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45071 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfIYV2G (ORCPT ); Wed, 25 Sep 2019 17:28:06 -0400 Received: by mail-wr1-f66.google.com with SMTP id r5so9783wrm.12; Wed, 25 Sep 2019 14:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D7RgA7/FBS1ovxM45xXz8Q3YMMUB73xo0iwOjI2XEHk=; b=Rvpys1ybbxcrJzijdtQhF4jgFU0rCaO6QiKNp6cWlwV1RGj4NkUYnKeV85y6mfxQyq zoE/B8hb2dc900srxPRcB/qJIn8Ualnklmy17+9u7SZ78oMmZ5QSskRNYRg4heBjw1bY 1GrKObvfE1xOREwoYU4WD463iDTERcoPGy1JmEPpCnVbPUsUQCZP1n+yUKUxQyWYTmT9 ByqlQJ8RQrR7ZJMZHRhQeBmKeAvYbhhoAqsaFWxSwcs0Q3B76OKPcXOdXfjUj25kwDXP getj4hUz0qv9NRWHPeGriWs623QYT5HdiJzWKo6NaTu+M7/ArB5VMysCuVRhbwt4qaVB 66Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=D7RgA7/FBS1ovxM45xXz8Q3YMMUB73xo0iwOjI2XEHk=; b=MPhcVM77r8bmen9HfS8QVXDtomWcV74OJMpWICjuP/RbEt99J0/3AhXr07wnxqzI/3 Cmg2iMUdbwzqbEzEHmkf3O73m3YMS6UWbKQvwcJO/b5hncWeD9rLtTnzw0n7/L0iSF7v 9YMVoNkcEVFIClrrYlDUJFXgFOWMOgbrjNMuvvJ6bV0XnaQ9wVUaGjPOknnyp0p9Shp2 I1cBF/diYOz41xadDWKVfG3fCzDimYCt7vaEcUD7Oy9Ig105s8UhbRLIjr2wTvQF1idK vs978ODsR+Iu+uEy2CAacAioQsOYgKXVhrKSz5RDmDupjuThOwJElWEIkEeKcDufH57v uKKQ== X-Gm-Message-State: APjAAAV/PvnbBLzqJcxVKFv3dPxzuzjHcOYM4hDke43ftWIQv71OB764 DobJUcDekAaklv54Zf4QySvKyGSU X-Google-Smtp-Source: APXvYqw0hSGwv9xVENzSh2Wp/vN3dqhyViKJtTI84Op0IOtycPR88vA3diw4Z5zzTrXf4HWN9JkIDA== X-Received: by 2002:adf:ce86:: with SMTP id r6mr280321wrn.57.1569446879459; Wed, 25 Sep 2019 14:27:59 -0700 (PDT) Received: from [192.168.1.19] (bfw9.neoplus.adsl.tpnet.pl. [83.28.60.9]) by smtp.gmail.com with ESMTPSA id f3sm165151wrq.53.2019.09.25.14.27.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Sep 2019 14:27:58 -0700 (PDT) Subject: Re: [PATCH v9 07/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver To: Dan Murphy , pavel@ucw.cz Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190925174616.3714-1-dmurphy@ti.com> <20190925174616.3714-8-dmurphy@ti.com> From: Jacek Anaszewski Openpgp: preference=signencrypt Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABtC1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT6JAlgEEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheABQkJZgNMFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl05/9sC GQEACgkQvWpQHLeLfCarMQ/9FN/WqJdN2tf6xkP0RFyS4ft0sT04zkOCFfOMxs8mZ+KZoMU+ X3a+fEppDL7xgRFpHyGaEel7lSi1eqtzsqZ5JiHbDS1Ht1G8TtATb8q8id68qeSeW2mfzaLQ 98NPELGfUXFoUqUQkG5z2p92UrGF4Muj1vOIW93pwvE4uDpNsl+jriwHomLtjIUoZtIRjGfZ RCyUQI0vi5LYzXCebuzAjGD7Jh2YAp7fDGrv3qTq8sX+DUJ4H/+I8PiL+jXKkEeppqIhlBJJ l4WcgggMu3c2uljYDuqRYghte33BXyCPAocfO2/sN+yJRUTVuRFlOxUk4srz/W8SQDwOAwtK V7TzdyF1/jOGBxWwS13EjMb4u3XwPMzcPlEQNdIqz76NFmJ99xYEvgkAmFmRioxuBTRv8Fs1 c1jQ00WWJ5vezqY6lccdDroPalXWeFzfPjIhKbV3LAYTlqv0It75GW9+0TBhPqdTM15DrCVX B7Ues7UnD5FBtWwewTnwr+cu8te449VDMzN2I+a9YKJ1s6uZmzh5HnuKn6tAfGyQh8MujSOM lZrNHrRsIsLXOjeGVa84Qk/watEcOoyQ7d+YaVosU0OCZl0GldvbGp1z2u8cd2N/HJ7dAgFh Q7dtGXmdXpt2WKQvTvQXhIrCWVQErNYbDZDD2V0TZtlPBaZP4fkUDkvH+Sy5Ag0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAGJAiUEGAEIAA8FAlWjfaECGwwFCQlm AYAACgkQvWpQHLeLfCZqGxAAlWBWVvjU6xj70GwengiqYZwmW1i8gfS4TNibQT/KRq0zkBnE wgKwXRbVoW38pYVuGa5x/JDQMJDrLAJ0wrCOS3XxbSHCWOl/k2ZD9OaxUeXq6N+OmGTzfrYv PUvWS1Hy04q9AD1dIaMNruZQmvnRfkOk2UDncDIg0166/NTHiYI09H5mpWGpHn/2aT6dmpVw uoM9/rHlF5s5qAAo95tZ0QW2BtIceG9/rbYlL57waSMPF49awvwLQX5RhWoF8mPS5LsBrXXK hmizIsn40tLbi2RtWjzDWgZYitqmmqijeCnDvISN4qJ/nCLO4DjiSGs59w5HR+l0nwePDhOC A4RYZqS1e2Clx1VSkDXFpL3egabcIsqK7CZ6a21r8lXVpo4RnMlQsmXZTnRx4SajFvX7PrRg /02C811fLfh2r5O5if8sKQ6BKKlHpuuioqfj/w9z3B0aQ71e4n1zNJBO1kcdznikPLAbr7jG gkBUXT1yJiwpTfRQr5y2Uo12IJsKxohnNFVYtK8X/R6S0deKPjrZWvAkllgIPcHjMi2Va8yw KTj/JgcpUO5KN906Pf7ywZISe7Kbcc/qnE0YjPPSqFOvoeZvHe6EZCMW9+xZsaipvlqpByQV UHnVg09K9YFvjUBsBPdC8ef6YwgfR9o6AnPmxl0oMUIXkCCC5c99fzJY/k+JAq0EGAEIACAW IQS/HfwKVo8F95V1cJC9alAct4t8JgUCWwqKhgIbAgCBCRC9alAct4t8JnYgBBkWCAAdFiEE FMMcSshOZf56bfAEYhBsURv0pdsFAlsKioYACgkQYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY 0LLxM/rFY9Vz1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8G 7joP/jx+oGOmdRogs7mG//H+w9DTnBfPpnfkeiiokGYo/+huWO5V0Ac9tTqZeFc//t/YuYJn wWvS0Rx+KL0fT3eh9BQo47uF4yDiZIiWLNh4Agpup1MUSVsz4MjD0lW6ghtnLcGlIgoVHW0v tPW1m9jATYyJSOG/MC1iDrcYcp9uVYn5tKfkEeQNspuG6iSfS0q3tajPKnT1nJxMTxVOD2RW EIGfaV9Scrou92VD/eC+/8INRsiWS93j3hOKIAV5XRNINFqtzkagPYAP8r6wksjSjh01fSTB p5zxjfsIwWDDzDrqgzwv83CvrLXRV3OlG1DNUDYA52qJr47paH5QMWmHW5TNuoBX8qb6RW/H M3DzPgT+l+r1pPjMPfvL1t7civZUoPuNzoyFpQRj6TvWi2bGGMQKryeYksXG2zi2+avMFnLe lOxGdUZ7jn1SJ6Abba5WL3VrXCP+TUE6bZLgfw8kYa8QSXP3ysyeMI0topHFntBZ8a0KXBNs qqFCBWmTHXfwsfW0VgBmRtPO7eXVBybjJ1VXKR2RZxwSq/GoNXh/yrRXQxbcpZ+QP3/Tttsb FdKciZ4u3ts+5UwYra0BRuvb51RiZR2wRNnUeBnXWagJVTlG7RHBO/2jJOE6wrcdCMjs0Iiw PNWmiVoZA930TvHA5UeGENxdGqo2MvMdRJ54YaIR Message-ID: <4293530f-70ae-0796-e7a7-0c6564e71132@gmail.com> Date: Wed, 25 Sep 2019 23:27:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190925174616.3714-8-dmurphy@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Introduce the LP5036/30/24/18/12/9 RGB LED driver. > The difference in these parts are the number of > LED outputs where the: > > LP5036 can control 36 LEDs > LP5030 can control 30 LEDs > LP5024 can control 24 LEDs > LP5018 can control 18 LEDs > LP5012 can control 12 LEDs > LP5009 can control 9 LEDs > > The device has the ability to group LED output into control banks > so that multiple LED banks can be controlled with the same mixing and > brightness. Inversely the LEDs can also be controlled independently. > > Signed-off-by: Dan Murphy > --- > drivers/leds/Kconfig | 11 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-lp50xx.c | 767 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 779 insertions(+) > create mode 100644 drivers/leds/leds-lp50xx.c > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index cfb1ebb6517f..84f60e35c5ee 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -363,6 +363,17 @@ config LEDS_LP3952 > To compile this driver as a module, choose M here: the > module will be called leds-lp3952. > > +config LEDS_LP50XX > + tristate "LED Support for TI LP5036/30/24/18/12/9 LED driver chip" > + depends on LEDS_CLASS && REGMAP_I2C > + depends on LEDS_CLASS_MULTI_COLOR > + help > + If you say yes here you get support for the Texas Instruments > + LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 LED driver. > + > + To compile this driver as a module, choose M here: the > + module will be called leds-lp50xx. > + > config LEDS_LP55XX_COMMON > tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501" > depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501 > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > index 841038cfe35b..7a208a0f7b84 100644 > --- a/drivers/leds/Makefile > +++ b/drivers/leds/Makefile > @@ -34,6 +34,7 @@ obj-$(CONFIG_LEDS_GPIO_REGISTER) += leds-gpio-register.o > obj-$(CONFIG_LEDS_GPIO) += leds-gpio.o > obj-$(CONFIG_LEDS_LP3944) += leds-lp3944.o > obj-$(CONFIG_LEDS_LP3952) += leds-lp3952.o > +obj-$(CONFIG_LEDS_LP50XX) += leds-lp50xx.o > obj-$(CONFIG_LEDS_LP55XX_COMMON) += leds-lp55xx-common.o > obj-$(CONFIG_LEDS_LP5521) += leds-lp5521.o > obj-$(CONFIG_LEDS_LP5523) += leds-lp5523.o > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > new file mode 100644 > index 000000000000..a4654cc2bea5 > --- /dev/null > +++ b/drivers/leds/leds-lp50xx.c > @@ -0,0 +1,767 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// TI LP50XX LED chip family driver > +// Copyright (C) 2018 Texas Instruments Incorporated - http://www.ti.com/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#define LP50XX_DEV_CFG0 0x00 > +#define LP50XX_DEV_CFG1 0x01 > +#define LP50XX_LED_CFG0 0x02 > + > +/* LP5009 and LP5012 registers */ > +#define LP5012_BNK_BRT 0x03 > +#define LP5012_BNKA_CLR 0x04 > +#define LP5012_BNKB_CLR 0x05 > +#define LP5012_BNKC_CLR 0x06 > +#define LP5012_LED0_BRT 0x07 > +#define LP5012_LED1_BRT 0x08 > +#define LP5012_LED2_BRT 0x09 > +#define LP5012_LED3_BRT 0x0a > +#define LP5012_OUT0_CLR 0x0b > +#define LP5012_OUT1_CLR 0x0c > +#define LP5012_OUT2_CLR 0x0d > +#define LP5012_OUT3_CLR 0x0e > +#define LP5012_OUT4_CLR 0x0f > +#define LP5012_OUT5_CLR 0x10 > +#define LP5012_OUT6_CLR 0x11 > +#define LP5012_OUT7_CLR 0x12 > +#define LP5012_OUT8_CLR 0x13 > +#define LP5012_OUT9_CLR 0x14 > +#define LP5012_OUT10_CLR 0x15 > +#define LP5012_OUT11_CLR 0x16 > +#define LP5012_RESET 0x17 > + > +/* LP5018 and LP5024 registers */ > +#define LP5024_BNK_BRT 0x03 > +#define LP5024_BNKA_CLR 0x04 > +#define LP5024_BNKB_CLR 0x05 > +#define LP5024_BNKC_CLR 0x06 > +#define LP5024_LED0_BRT 0x07 > +#define LP5024_LED1_BRT 0x08 > +#define LP5024_LED2_BRT 0x09 > +#define LP5024_LED3_BRT 0x0a > +#define LP5024_LED4_BRT 0x0b > +#define LP5024_LED5_BRT 0x0c > +#define LP5024_LED6_BRT 0x0d > +#define LP5024_LED7_BRT 0x0e > + > +#define LP5024_OUT0_CLR 0x0f > +#define LP5024_OUT1_CLR 0x10 > +#define LP5024_OUT2_CLR 0x11 > +#define LP5024_OUT3_CLR 0x12 > +#define LP5024_OUT4_CLR 0x13 > +#define LP5024_OUT5_CLR 0x14 > +#define LP5024_OUT6_CLR 0x15 > +#define LP5024_OUT7_CLR 0x16 > +#define LP5024_OUT8_CLR 0x17 > +#define LP5024_OUT9_CLR 0x18 > +#define LP5024_OUT10_CLR 0x19 > +#define LP5024_OUT11_CLR 0x1a > +#define LP5024_OUT12_CLR 0x1b > +#define LP5024_OUT13_CLR 0x1c > +#define LP5024_OUT14_CLR 0x1d > +#define LP5024_OUT15_CLR 0x1e > +#define LP5024_OUT16_CLR 0x1f > +#define LP5024_OUT17_CLR 0x20 > +#define LP5024_OUT18_CLR 0x21 > +#define LP5024_OUT19_CLR 0x22 > +#define LP5024_OUT20_CLR 0x23 > +#define LP5024_OUT21_CLR 0x24 > +#define LP5024_OUT22_CLR 0x25 > +#define LP5024_OUT23_CLR 0x26 > +#define LP5024_RESET 0x27 > + > +/* LP5030 and LP5036 registers */ > +#define LP5036_LED_CFG1 0x03 > +#define LP5036_BNK_BRT 0x04 > +#define LP5036_BNKA_CLR 0x05 > +#define LP5036_BNKB_CLR 0x06 > +#define LP5036_BNKC_CLR 0x07 > +#define LP5036_LED0_BRT 0x08 > +#define LP5036_LED1_BRT 0x09 > +#define LP5036_LED2_BRT 0x0a > +#define LP5036_LED3_BRT 0x0b > +#define LP5036_LED4_BRT 0x0c > +#define LP5036_LED5_BRT 0x0d > +#define LP5036_LED6_BRT 0x0e > +#define LP5036_LED7_BRT 0x0f > +#define LP5036_LED8_BRT 0x10 > +#define LP5036_LED9_BRT 0x11 > +#define LP5036_LED10_BRT 0x12 > +#define LP5036_LED11_BRT 0x13 > + > +#define LP5036_OUT0_CLR 0x14 > +#define LP5036_OUT1_CLR 0x15 > +#define LP5036_OUT2_CLR 0x16 > +#define LP5036_OUT3_CLR 0x17 > +#define LP5036_OUT4_CLR 0x18 > +#define LP5036_OUT5_CLR 0x19 > +#define LP5036_OUT6_CLR 0x1a > +#define LP5036_OUT7_CLR 0x1b > +#define LP5036_OUT8_CLR 0x1c > +#define LP5036_OUT9_CLR 0x1d > +#define LP5036_OUT10_CLR 0x1e > +#define LP5036_OUT11_CLR 0x1f > +#define LP5036_OUT12_CLR 0x20 > +#define LP5036_OUT13_CLR 0x21 > +#define LP5036_OUT14_CLR 0x22 > +#define LP5036_OUT15_CLR 0x23 > +#define LP5036_OUT16_CLR 0x24 > +#define LP5036_OUT17_CLR 0x25 > +#define LP5036_OUT18_CLR 0x26 > +#define LP5036_OUT19_CLR 0x27 > +#define LP5036_OUT20_CLR 0x28 > +#define LP5036_OUT21_CLR 0x29 > +#define LP5036_OUT22_CLR 0x2a > +#define LP5036_OUT23_CLR 0x2b > +#define LP5036_OUT24_CLR 0x2c > +#define LP5036_OUT25_CLR 0x2d > +#define LP5036_OUT26_CLR 0x2e > +#define LP5036_OUT27_CLR 0x2f > +#define LP5036_OUT28_CLR 0x30 > +#define LP5036_OUT29_CLR 0x31 > +#define LP5036_OUT30_CLR 0x32 > +#define LP5036_OUT31_CLR 0x33 > +#define LP5036_OUT32_CLR 0x34 > +#define LP5036_OUT33_CLR 0x35 > +#define LP5036_OUT34_CLR 0x36 > +#define LP5036_OUT35_CLR 0x37 > +#define LP5036_RESET 0x38 > + > +#define LP50XX_SW_RESET 0xff > +#define LP50XX_CHIP_EN BIT(6) > + > +/* There are 3 LED outputs per bank */ > +#define LP50XX_LEDS_PER_MODULE 3 > + > +#define LP5009_MAX_LED_MODULES 2 > +#define LP5012_MAX_LED_MODULES 4 > +#define LP5018_MAX_LED_MODULES 6 > +#define LP5024_MAX_LED_MODULES 8 > +#define LP5030_MAX_LED_MODULES 10 > +#define LP5036_MAX_LED_MODULES 12 > + > +#define LP5009_MAX_LEDS (LP5009_MAX_LED_MODULES * LP50XX_LEDS_PER_MODULE) > +#define LP5012_MAX_LEDS (LP5012_MAX_LED_MODULES * LP50XX_LEDS_PER_MODULE) > +#define LP5018_MAX_LEDS (LP5018_MAX_LED_MODULES * LP50XX_LEDS_PER_MODULE) > +#define LP5024_MAX_LEDS (LP5024_MAX_LED_MODULES * LP50XX_LEDS_PER_MODULE) > +#define LP5030_MAX_LEDS (LP5030_MAX_LED_MODULES * LP50XX_LEDS_PER_MODULE) > +#define LP5036_MAX_LEDS (LP5036_MAX_LED_MODULES * LP50XX_LEDS_PER_MODULE) > + > +struct lp50xx_led { > + struct led_classdev led_dev; > + struct led_classdev_mc mc_cdev; > + struct lp50xx *priv; > + unsigned long bank_modules; > + int led_intensity[LP50XX_LEDS_PER_MODULE]; > + u8 ctrl_bank_enabled; > + int led_number; > +}; > + > +/** > + * struct lp50xx - > + * @enable_gpio: hardware enable gpio > + * @regulator: LED supply regulator pointer > + * @client: pointer to the I2C client > + * @regmap: device register map > + * @dev: pointer to the devices device struct > + * @lock: lock for reading/writing the device > + * @chip_info: chip specific information (ie num_leds) > + * @num_of_banked_leds: holds the number of banked LEDs > + * @leds: array of LED strings > + */ > +struct lp50xx { > + struct gpio_desc *enable_gpio; > + struct regulator *regulator; > + struct i2c_client *client; > + struct regmap *regmap; > + struct device *dev; > + struct mutex lock; > + const struct lp50xx_chip_info *chip_info; > + int num_of_banked_leds; > + > + /* This needs to be at the end of the struct */ > + struct lp50xx_led leds[]; > +}; > + > +static const struct reg_default lp5012_reg_defs[] = { > + {LP50XX_DEV_CFG0, 0x0}, > + {LP50XX_DEV_CFG1, 0x3c}, > + {LP50XX_LED_CFG0, 0x0}, > + {LP5012_BNK_BRT, 0xff}, > + {LP5012_BNKA_CLR, 0x0f}, > + {LP5012_BNKB_CLR, 0x0f}, > + {LP5012_BNKC_CLR, 0x0f}, > + {LP5012_LED0_BRT, 0x0f}, > + {LP5012_LED1_BRT, 0xff}, > + {LP5012_LED2_BRT, 0xff}, > + {LP5012_LED3_BRT, 0xff}, > + {LP5012_OUT0_CLR, 0x0f}, > + {LP5012_OUT1_CLR, 0x00}, > + {LP5012_OUT2_CLR, 0x00}, > + {LP5012_OUT3_CLR, 0x00}, > + {LP5012_OUT4_CLR, 0x00}, > + {LP5012_OUT5_CLR, 0x00}, > + {LP5012_OUT6_CLR, 0x00}, > + {LP5012_OUT7_CLR, 0x00}, > + {LP5012_OUT8_CLR, 0x00}, > + {LP5012_OUT9_CLR, 0x00}, > + {LP5012_OUT10_CLR, 0x00}, > + {LP5012_OUT11_CLR, 0x00}, > + {LP5012_RESET, 0x00} > +}; > + > +static const struct reg_default lp5024_reg_defs[] = { > + {LP50XX_DEV_CFG0, 0x0}, > + {LP50XX_DEV_CFG1, 0x3c}, > + {LP50XX_LED_CFG0, 0x0}, > + {LP5024_BNK_BRT, 0xff}, > + {LP5024_BNKA_CLR, 0x0f}, > + {LP5024_BNKB_CLR, 0x0f}, > + {LP5024_BNKC_CLR, 0x0f}, > + {LP5024_LED0_BRT, 0x0f}, > + {LP5024_LED1_BRT, 0xff}, > + {LP5024_LED2_BRT, 0xff}, > + {LP5024_LED3_BRT, 0xff}, > + {LP5024_LED4_BRT, 0xff}, > + {LP5024_LED5_BRT, 0xff}, > + {LP5024_LED6_BRT, 0xff}, > + {LP5024_LED7_BRT, 0xff}, > + {LP5024_OUT0_CLR, 0x0f}, > + {LP5024_OUT1_CLR, 0x00}, > + {LP5024_OUT2_CLR, 0x00}, > + {LP5024_OUT3_CLR, 0x00}, > + {LP5024_OUT4_CLR, 0x00}, > + {LP5024_OUT5_CLR, 0x00}, > + {LP5024_OUT6_CLR, 0x00}, > + {LP5024_OUT7_CLR, 0x00}, > + {LP5024_OUT8_CLR, 0x00}, > + {LP5024_OUT9_CLR, 0x00}, > + {LP5024_OUT10_CLR, 0x00}, > + {LP5024_OUT11_CLR, 0x00}, > + {LP5024_OUT12_CLR, 0x00}, > + {LP5024_OUT13_CLR, 0x00}, > + {LP5024_OUT14_CLR, 0x00}, > + {LP5024_OUT15_CLR, 0x00}, > + {LP5024_OUT16_CLR, 0x00}, > + {LP5024_OUT17_CLR, 0x00}, > + {LP5024_OUT18_CLR, 0x00}, > + {LP5024_OUT19_CLR, 0x00}, > + {LP5024_OUT20_CLR, 0x00}, > + {LP5024_OUT21_CLR, 0x00}, > + {LP5024_OUT22_CLR, 0x00}, > + {LP5024_OUT23_CLR, 0x00}, > + {LP5024_RESET, 0x00} > +}; > + > +static const struct reg_default lp5036_reg_defs[] = { > + {LP50XX_DEV_CFG0, 0x0}, > + {LP50XX_DEV_CFG1, 0x3c}, > + {LP50XX_LED_CFG0, 0x0}, > + {LP5036_LED_CFG1, 0x0}, > + {LP5036_BNK_BRT, 0xff}, > + {LP5036_BNKA_CLR, 0x0f}, > + {LP5036_BNKB_CLR, 0x0f}, > + {LP5036_BNKC_CLR, 0x0f}, > + {LP5036_LED0_BRT, 0x0f}, > + {LP5036_LED1_BRT, 0xff}, > + {LP5036_LED2_BRT, 0xff}, > + {LP5036_LED3_BRT, 0xff}, > + {LP5036_LED4_BRT, 0xff}, > + {LP5036_LED5_BRT, 0xff}, > + {LP5036_LED6_BRT, 0xff}, > + {LP5036_LED7_BRT, 0xff}, > + {LP5036_OUT0_CLR, 0x0f}, > + {LP5036_OUT1_CLR, 0x00}, > + {LP5036_OUT2_CLR, 0x00}, > + {LP5036_OUT3_CLR, 0x00}, > + {LP5036_OUT4_CLR, 0x00}, > + {LP5036_OUT5_CLR, 0x00}, > + {LP5036_OUT6_CLR, 0x00}, > + {LP5036_OUT7_CLR, 0x00}, > + {LP5036_OUT8_CLR, 0x00}, > + {LP5036_OUT9_CLR, 0x00}, > + {LP5036_OUT10_CLR, 0x00}, > + {LP5036_OUT11_CLR, 0x00}, > + {LP5036_OUT12_CLR, 0x00}, > + {LP5036_OUT13_CLR, 0x00}, > + {LP5036_OUT14_CLR, 0x00}, > + {LP5036_OUT15_CLR, 0x00}, > + {LP5036_OUT16_CLR, 0x00}, > + {LP5036_OUT17_CLR, 0x00}, > + {LP5036_OUT18_CLR, 0x00}, > + {LP5036_OUT19_CLR, 0x00}, > + {LP5036_OUT20_CLR, 0x00}, > + {LP5036_OUT21_CLR, 0x00}, > + {LP5036_OUT22_CLR, 0x00}, > + {LP5036_OUT23_CLR, 0x00}, > + {LP5036_OUT24_CLR, 0x00}, > + {LP5036_OUT25_CLR, 0x00}, > + {LP5036_OUT26_CLR, 0x00}, > + {LP5036_OUT27_CLR, 0x00}, > + {LP5036_OUT28_CLR, 0x00}, > + {LP5036_OUT29_CLR, 0x00}, > + {LP5036_OUT30_CLR, 0x00}, > + {LP5036_OUT31_CLR, 0x00}, > + {LP5036_OUT32_CLR, 0x00}, > + {LP5036_OUT33_CLR, 0x00}, > + {LP5036_OUT34_CLR, 0x00}, > + {LP5036_OUT35_CLR, 0x00}, > + {LP5036_RESET, 0x00} > +}; > + > +static const struct regmap_config lp5012_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + > + .max_register = LP5012_RESET, > + .reg_defaults = lp5012_reg_defs, > + .num_reg_defaults = ARRAY_SIZE(lp5012_reg_defs), > + .cache_type = REGCACHE_RBTREE, > +}; > + > +static const struct regmap_config lp5024_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + > + .max_register = LP5024_RESET, > + .reg_defaults = lp5024_reg_defs, > + .num_reg_defaults = ARRAY_SIZE(lp5024_reg_defs), > + .cache_type = REGCACHE_RBTREE, > +}; > + > +static const struct regmap_config lp5036_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + > + .max_register = LP5036_RESET, > + .reg_defaults = lp5036_reg_defs, > + .num_reg_defaults = ARRAY_SIZE(lp5036_reg_defs), > + .cache_type = REGCACHE_RBTREE, > +}; > + > +enum lp50xx_model { > + LP5009, > + LP5012, > + LP5018, > + LP5024, > + LP5030, > + LP5036, > +}; > + > +/* > + * struct lp50xx_chip_info - > + * @num_leds: number of LED outputs available on the device > + * @led_brightness0_reg: first brightness register of the device > + * @mix_out0_reg: first color mix register of the device > + * @bank_brt_reg: bank brightness register > + * @bank_mix_reg: color mix register > + * @reset_reg: device reset register > + */ > +struct lp50xx_chip_info { > + struct regmap_config lp50xx_regmap_config; > + u8 num_leds; > + u8 led_brightness0_reg; > + u8 mix_out0_reg; > + u8 bank_brt_reg; > + u8 bank_mix_reg; > + u8 reset_reg; > +}; > + > +static const struct lp50xx_chip_info lp50xx_chip_info_tbl[] = { > + [LP5009] = { > + .num_leds = LP5009_MAX_LEDS, > + .led_brightness0_reg = LP5012_LED0_BRT, > + .mix_out0_reg = LP5012_OUT0_CLR, > + .bank_brt_reg = LP5012_BNK_BRT, > + .bank_mix_reg = LP5012_BNKA_CLR, > + .reset_reg = LP5012_RESET, > + .lp50xx_regmap_config = lp5012_regmap_config, > + }, > + [LP5012] = { > + .num_leds = LP5012_MAX_LEDS, > + .led_brightness0_reg = LP5012_LED0_BRT, > + .mix_out0_reg = LP5012_OUT0_CLR, > + .bank_brt_reg = LP5012_BNK_BRT, > + .bank_mix_reg = LP5012_BNKA_CLR, > + .reset_reg = LP5012_RESET, > + .lp50xx_regmap_config = lp5012_regmap_config, > + }, > + [LP5018] = { > + .num_leds = LP5018_MAX_LEDS, > + .led_brightness0_reg = LP5024_LED0_BRT, > + .mix_out0_reg = LP5024_OUT0_CLR, > + .bank_brt_reg = LP5024_BNK_BRT, > + .bank_mix_reg = LP5024_BNKA_CLR, > + .reset_reg = LP5024_RESET, > + .lp50xx_regmap_config = lp5024_regmap_config, > + }, > + [LP5024] = { > + .num_leds = LP5024_MAX_LEDS, > + .led_brightness0_reg = LP5024_LED0_BRT, > + .mix_out0_reg = LP5024_OUT0_CLR, > + .bank_brt_reg = LP5024_BNK_BRT, > + .bank_mix_reg = LP5024_BNKA_CLR, > + .reset_reg = LP5024_RESET, > + .lp50xx_regmap_config = lp5024_regmap_config, > + }, > + [LP5030] = { > + .num_leds = LP5030_MAX_LEDS, > + .led_brightness0_reg = LP5036_LED0_BRT, > + .mix_out0_reg = LP5036_OUT0_CLR, > + .bank_brt_reg = LP5036_BNK_BRT, > + .bank_mix_reg = LP5036_BNKA_CLR, > + .reset_reg = LP5036_RESET, > + .lp50xx_regmap_config = lp5036_regmap_config, > + }, > + [LP5036] = { > + .num_leds = LP5036_MAX_LEDS, > + .led_brightness0_reg = LP5036_LED0_BRT, > + .mix_out0_reg = LP5036_OUT0_CLR, > + .bank_brt_reg = LP5036_BNK_BRT, > + .bank_mix_reg = LP5036_BNKA_CLR, > + .reset_reg = LP5036_RESET, > + .lp50xx_regmap_config = lp5036_regmap_config, > + }, > +}; > + > +static int lp50xx_brightness_set(struct led_classdev *cdev, > + enum led_brightness brightness) > +{ > + struct lp50xx_led *led = container_of(cdev, struct lp50xx_led, led_dev); > + const struct lp50xx_chip_info *led_chip = led->priv->chip_info; > + struct led_mc_color_entry *color_data; > + u8 led_offset, reg_val, reg_color_offset; > + int ret = 0; > + > + mutex_lock(&led->priv->lock); > + > + if (led->ctrl_bank_enabled) > + reg_val = led_chip->bank_brt_reg; > + else > + reg_val = led_chip->led_brightness0_reg + > + led->led_number; > + > + ret = regmap_write(led->priv->regmap, reg_val, brightness); > + if (ret) { > + dev_err(&led->priv->client->dev, > + "Cannot write brightness value %d\n", ret); > + goto out; > + } > + > + list_for_each_entry(color_data, &led->mc_cdev.color_list, list) { > + if (color_data->led_color_id == LED_COLOR_ID_RED) > + reg_color_offset = 0; > + else if (color_data->led_color_id == LED_COLOR_ID_GREEN) > + reg_color_offset = 1; > + else if (color_data->led_color_id == LED_COLOR_ID_BLUE) > + reg_color_offset = 2; > + else > + continue; This else case is quite erroneous. Sheer continue is just ignoring serious problem. I'd log the problem and return -EINVAL. Also, you could have a macro for mapping color_id to offset. > + > + if (led->ctrl_bank_enabled) { > + reg_val = led_chip->bank_mix_reg + reg_color_offset; > + } else { > + led_offset = (led->led_number * 3) + reg_color_offset; > + reg_val = led_chip->mix_out0_reg + led_offset; > + } > + > + ret = regmap_write(led->priv->regmap, reg_val, > + color_data->intensity); > + if (ret) { > + dev_err(&led->priv->client->dev, > + "Cannot write intensity value %d\n", ret); > + goto out; > + } > + } > +out: > + mutex_unlock(&led->priv->lock); > + return ret; > +} > + > +static enum led_brightness lp50xx_brightness_get(struct led_classdev *cdev) > +{ > + struct lp50xx_led *led = container_of(cdev, struct lp50xx_led, led_dev); > + const struct lp50xx_chip_info *led_chip = led->priv->chip_info; > + unsigned int brt_val; > + u8 reg_val; > + int ret; > + > + mutex_lock(&led->priv->lock); > + > + if (led->ctrl_bank_enabled) > + reg_val = led_chip->bank_brt_reg; > + else > + reg_val = led_chip->led_brightness0_reg + led->led_number; > + > + ret = regmap_read(led->priv->regmap, reg_val, &brt_val); > + > + mutex_unlock(&led->priv->lock); > + > + return brt_val; > +} > + > +static int lp50xx_set_banks(struct lp50xx *priv, u32 led_banks[]) > +{ > + u8 led_config_lo, led_config_hi; > + u32 bank_enable_mask = 0; > + int ret; > + int i; > + > + for (i = 0; i < priv->chip_info->num_leds; i++) > + bank_enable_mask |= (1 << led_banks[i]); > + > + led_config_lo = (u8)(bank_enable_mask & 0xff); > + led_config_hi = (u8)(bank_enable_mask >> 8) & 0xff; > + > + ret = regmap_write(priv->regmap, LP50XX_LED_CFG0, led_config_lo); > + if (ret) > + return ret; > + > + if (led_config_hi) Now I think that less questionable would be writing led_config_hi always for devices that have CFG1 register. IOW write led_config_hi also when it equals 0. > + ret = regmap_write(priv->regmap, LP5036_LED_CFG1, > + led_config_hi); > + > + return ret; > +} > + > +static int lp50xx_reset(struct lp50xx *priv) > +{ > + if (priv->enable_gpio) > + return gpiod_direction_output(priv->enable_gpio, 1); > + else > + return regmap_write(priv->regmap, priv->chip_info->reset_reg, > + LP50XX_SW_RESET); > +} > + > +static int lp50xx_enable_disable(struct lp50xx *priv, u8 enable_disable) > +{ > + return regmap_write(priv->regmap, LP50XX_DEV_CFG0, enable_disable); > +} > + > +static int lp50xx_probe_dt(struct lp50xx *priv) > +{ > + u32 led_banks[LP5036_MAX_LED_MODULES]; > + struct fwnode_handle *child = NULL; > + struct fwnode_handle *led_node = NULL; > + struct led_init_data init_data; > + struct lp50xx_led *led; > + int num_colors; > + u32 color_id; > + int led_number; > + size_t i = 0; > + int ret; > + > + priv->enable_gpio = devm_gpiod_get_optional(&priv->client->dev, > + "enable", GPIOD_OUT_LOW); > + if (IS_ERR(priv->enable_gpio)) { > + ret = PTR_ERR(priv->enable_gpio); > + dev_err(&priv->client->dev, "Failed to get enable gpio: %d\n", > + ret); > + return ret; > + } > + > + priv->regulator = devm_regulator_get(&priv->client->dev, "vled"); > + if (IS_ERR(priv->regulator)) > + priv->regulator = NULL; > + > + device_for_each_child_node(&priv->client->dev, child) { > + led = &priv->leds[i]; > + if (fwnode_property_present(child, "ti,led-bank")) { > + ret = fwnode_property_read_u32_array(child, > + "ti,led-bank", > + NULL, 0); > + ret = fwnode_property_read_u32_array(child, > + "ti,led-bank", > + led_banks, > + ret); > + > + priv->num_of_banked_leds = ARRAY_SIZE(led_banks); > + > + ret = lp50xx_set_banks(priv, led_banks); > + if (ret) { > + dev_err(&priv->client->dev, > + "Cannot setup banked LEDs\n"); > + fwnode_handle_put(child); > + goto child_out; > + } > + led->ctrl_bank_enabled = 1; > + > + } else { > + ret = fwnode_property_read_u32(child, "reg", > + &led_number); Not checking ret val? > + > + led->led_number = led_number; > + } > + if (ret) { > + dev_err(&priv->client->dev, > + "led sourcing property missing\n"); > + fwnode_handle_put(child); > + goto child_out; > + } > + > + if (led_number > priv->chip_info->num_leds) { > + dev_err(&priv->client->dev, > + "led-sources property is invalid\n"); > + ret = -EINVAL; > + fwnode_handle_put(child); > + goto child_out; > + } > + > + init_data.fwnode = child; > + fwnode_property_read_string(child, "linux,default-trigger", > + &led->led_dev.default_trigger); > + num_colors = 0; > + > + fwnode_for_each_child_node(child, led_node) { > + ret = fwnode_property_read_u32(led_node, "color", > + &color_id); > + if (ret) > + dev_err(&priv->client->dev, > + "Cannot read color\n"); > + > + set_bit(color_id, &led->mc_cdev.available_colors); > + num_colors++; > + > + } > + > + led->priv = priv; > + led->mc_cdev.num_leds = num_colors; > + led->mc_cdev.led_cdev = &led->led_dev; > + led->led_dev.brightness_set_blocking = lp50xx_brightness_set; > + led->led_dev.brightness_get = lp50xx_brightness_get; > + ret = led_classdev_multicolor_register_ext(&priv->client->dev, > + &led->mc_cdev, > + &init_data); > + if (ret) { > + dev_err(&priv->client->dev, "led register err: %d\n", > + ret); > + fwnode_handle_put(child); > + goto child_out; > + } > + i++; > + } > + > +child_out: > + return ret; > +} > + > +static int lp50xx_probe(struct i2c_client *client, > + const struct i2c_device_id *id) > +{ > + struct lp50xx *led; > + int count; > + int ret; > + > + count = device_get_child_node_count(&client->dev); > + if (!count) { > + dev_err(&client->dev, "LEDs are not defined in device tree!"); > + return -ENODEV; > + } > + > + led = devm_kzalloc(&client->dev, struct_size(led, leds, count), > + GFP_KERNEL); > + if (!led) > + return -ENOMEM; > + > + mutex_init(&led->lock); > + led->client = client; > + led->dev = &client->dev; > + led->chip_info = &lp50xx_chip_info_tbl[id->driver_data]; > + i2c_set_clientdata(client, led); > + > + led->regmap = devm_regmap_init_i2c(client, > + &led->chip_info->lp50xx_regmap_config); > + if (IS_ERR(led->regmap)) { > + ret = PTR_ERR(led->regmap); > + dev_err(&client->dev, "Failed to allocate register map: %d\n", > + ret); > + return ret; > + } > + > + ret = lp50xx_reset(led); > + if (ret) > + return ret; > + > + ret = lp50xx_probe_dt(led); > + if (ret) > + return ret; > + > + return lp50xx_enable_disable(led, LP50XX_CHIP_EN); > +} > + > +static int lp50xx_remove(struct i2c_client *client) > +{ > + struct lp50xx *led = i2c_get_clientdata(client); > + int ret; > + > + ret = lp50xx_enable_disable(led, LP50XX_CHIP_EN); > + if (ret) { > + dev_err(&led->client->dev, "Failed to disable regulator\n"); > + return ret; > + } > + > + if (led->enable_gpio) > + gpiod_direction_output(led->enable_gpio, 0); > + > + if (led->regulator) { > + ret = regulator_disable(led->regulator); > + if (ret) > + dev_err(&led->client->dev, > + "Failed to disable regulator\n"); > + } > + > + mutex_destroy(&led->lock); > + > + return 0; > +} > + > +static const struct i2c_device_id lp50xx_id[] = { > + { "lp5009", LP5009 }, > + { "lp5012", LP5012 }, > + { "lp5018", LP5018 }, > + { "lp5024", LP5024 }, > + { "lp5030", LP5030 }, > + { "lp5036", LP5036 }, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, lp50xx_id); > + > +static const struct of_device_id of_lp50xx_leds_match[] = { > + { .compatible = "ti,lp5009", .data = (void *)LP5009 }, > + { .compatible = "ti,lp5012", .data = (void *)LP5012 }, > + { .compatible = "ti,lp5018", .data = (void *)LP5018 }, > + { .compatible = "ti,lp5024", .data = (void *)LP5024 }, > + { .compatible = "ti,lp5030", .data = (void *)LP5030 }, > + { .compatible = "ti,lp5036", .data = (void *)LP5036 }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, of_lp50xx_leds_match); > + > +static struct i2c_driver lp50xx_driver = { > + .driver = { > + .name = "lp50xx", > + .of_match_table = of_lp50xx_leds_match, > + }, > + .probe = lp50xx_probe, > + .remove = lp50xx_remove, > + .id_table = lp50xx_id, > +}; > +module_i2c_driver(lp50xx_driver); > + > +MODULE_DESCRIPTION("Texas Instruments LP50XX LED driver"); > +MODULE_AUTHOR("Dan Murphy "); > +MODULE_LICENSE("GPL v2"); > -- Best regards, Jacek Anaszewski