From: Luca Weiss <luca@z3ntu.xyz> To: Rob Herring <robh@kernel.org> Cc: linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>, Heiko Stuebner <heiko@sntech.de>, Icenowy Zheng <icenowy@aosc.io>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mark Rutland <mark.rutland@arm.com>, Maxime Ripard <mripard@kernel.org>, Pavel Machek <pavel@ucw.cz>, Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 2/3] dt-bindings: leds: Add binding for sgm3140 Date: Tue, 24 Mar 2020 21:02:45 +0100 Message-ID: <4545531.31r3eYUQgx@g550jk> (raw) In-Reply-To: <20200323205727.GA4038@bogus> Hi Rob, On Montag, 23. März 2020 21:57:27 CET Rob Herring wrote: > On Mon, Mar 09, 2020 at 09:35:57PM +0100, Luca Weiss wrote: > > Add YAML devicetree binding for SGMICRO SGM3140 charge pump used for > > camera flash LEDs. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > Changes since RFC: > > - new patch > > > > I'm not sure about the completeness of this binding as it doesn't > > mention the led subnode at all. > > The only existing led yaml binding is leds/leds-max77650.yaml which > > mentions the subnode but duplicates properties from documented in > > leds/common.txt. > > It's common.yaml now. Reference it from a child node defined here. Thanks, that helps a lot! > > > .../bindings/leds/leds-sgm3140.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml Regards Luca
next prev parent reply index Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-09 20:35 [PATCH 0/3] Add sgm3140 flash led driver Luca Weiss 2020-03-09 20:35 ` [PATCH 1/3] dt-bindings: Add vendor prefix for SG Micro Corp Luca Weiss 2020-03-23 20:54 ` Rob Herring 2020-03-09 20:35 ` [PATCH 2/3] dt-bindings: leds: Add binding for sgm3140 Luca Weiss 2020-03-09 22:22 ` Sakari Ailus 2020-03-11 12:49 ` Dan Murphy 2020-03-15 10:47 ` Luca Weiss 2020-03-15 10:53 ` Laurent Pinchart 2020-03-23 21:30 ` Dan Murphy 2020-03-23 20:57 ` Rob Herring 2020-03-24 20:02 ` Luca Weiss [this message] 2020-03-09 20:35 ` [PATCH 3/3] leds: add sgm3140 driver Luca Weiss 2020-03-09 22:18 ` Sakari Ailus 2020-03-09 22:49 ` Pavel Machek 2020-03-09 22:52 ` Luca Weiss 2020-03-11 13:02 ` Dan Murphy 2020-03-11 21:09 ` Jacek Anaszewski 2020-03-15 10:42 ` Luca Weiss
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4545531.31r3eYUQgx@g550jk \ --to=luca@z3ntu.xyz \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=heiko@sntech.de \ --cc=icenowy@aosc.io \ --cc=jacek.anaszewski@gmail.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mripard@kernel.org \ --cc=pavel@ucw.cz \ --cc=robh@kernel.org \ --cc=shawnguo@kernel.org \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-LEDs Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \ linux-leds@vger.kernel.org public-inbox-index linux-leds Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds AGPL code for this site: git clone https://public-inbox.org/public-inbox.git