Re: [PATCH v12 00/16] Multicolor Framework v12

From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 00/16] Multicolor Framework v12
Date: Fri, 11 Oct 2019 21:40:45 +0200	[thread overview]
Message-ID: <47e924dd-ae75-b822-b79e-9156d09b8b1a@gmail.com> (raw)
In-Reply-To: <20191011130657.4713-1-dmurphy@ti.com>

Dan,

On 10/11/19 3:06 PM, Dan Murphy wrote:
> Hello
> 
> Minor changes per review comments.
> https://lore.kernel.org/patchwork/project/lkml/list/?series=413385
> 
> Rebased the series on top of Pavel's next branch.
> 
> Multicolor changes:
> Rename led_mc_calc_brightness to led_mc_calc_color_components
> Updated the binding example for the function from STATUS to CHARGING

I see STATUS is still there, as well ass "Child".

> LP50xx changes:
> None
> 
> LP55xx changes:
> Changed color_component array allocation from COLOR_MAX_ID to MAX_GROUPED_CHANNELS
> Updated MC API to call led_mc_calc_color_components
> 
> Dan
> 
> Dan Murphy (16):
>   dt: bindings: Add multicolor class dt bindings documention
>   dt-bindings: leds: Add multicolor ID to the color ID list
>   leds: Add multicolor ID to the color ID list
>   leds: multicolor: Introduce a multicolor class definition
>   dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
>   leds: lp50xx: Add the LP50XX family of the RGB LED driver
>   dt: bindings: lp55xx: Be consistent in the document with LED acronym
>   dt: bindings: lp55xx: Update binding for Multicolor Framework
>   ARM: dts: n900: Add reg property to the LP5523 channel node
>   ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
>   ARM: dts: ste-href: Add reg property to the LP5521 channel nodes
>   leds: lp55xx: Add multicolor framework support to lp55xx
>   leds: lp5523: Update the lp5523 code to add intensity function
>   leds: lp5521: Add multicolor framework intensity support
>   leds: lp55xx: Fix checkpatch file permissions issues
>   leds: lp5523: Fix checkpatch issues in the code
> 
>  .../ABI/testing/sysfs-class-led-multicolor    |  36 +
>  .../bindings/leds/leds-class-multicolor.txt   |  98 +++
>  .../devicetree/bindings/leds/leds-lp50xx.txt  | 148 ++++
>  .../devicetree/bindings/leds/leds-lp55xx.txt  | 155 +++-
>  Documentation/leds/index.rst                  |   1 +
>  Documentation/leds/leds-class-multicolor.rst  |  96 +++
>  arch/arm/boot/dts/imx6dl-yapp4-common.dtsi    |  14 +-
>  arch/arm/boot/dts/omap3-n900.dts              |  29 +-
>  arch/arm/boot/dts/ste-href.dtsi               |  22 +-
>  drivers/leds/Kconfig                          |  22 +
>  drivers/leds/Makefile                         |   2 +
>  drivers/leds/led-class-multicolor.c           | 271 ++++++
>  drivers/leds/led-core.c                       |   1 +
>  drivers/leds/leds-lp50xx.c                    | 799 ++++++++++++++++++
>  drivers/leds/leds-lp5521.c                    |  20 +
>  drivers/leds/leds-lp5523.c                    |  39 +-
>  drivers/leds/leds-lp55xx-common.c             | 198 ++++-
>  drivers/leds/leds-lp55xx-common.h             |   9 +
>  include/dt-bindings/leds/common.h             |   3 +-
>  include/linux/led-class-multicolor.h          | 143 ++++
>  include/linux/platform_data/leds-lp55xx.h     |   7 +
>  21 files changed, 2020 insertions(+), 93 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt
>  create mode 100644 Documentation/leds/leds-class-multicolor.rst
>  create mode 100644 drivers/leds/led-class-multicolor.c
>  create mode 100644 drivers/leds/leds-lp50xx.c
>  create mode 100644 include/linux/led-class-multicolor.h
> 

-- 
Best regards,
Jacek Anaszewski