* Re: [PATCH v1] Add support for MediaTek regulator vibrator driver [not found] <20200429081759.26964-1-Xing.Zhang@mediatek.com> @ 2020-05-07 17:45 ` Pavel Machek 2020-05-07 20:45 ` Jacek Anaszewski 0 siblings, 1 reply; 3+ messages in thread From: Pavel Machek @ 2020-05-07 17:45 UTC (permalink / raw) To: Xing Zhang Cc: Matthias Brugger, Jacek Anaszewski, Dan Murphy, linux-arm-kernel, linux-mediatek, linux-kernel, linux-leds Hi! > This patchset add regulator vibrator driver for MTK Soc. The driver > controls vibrator through regulator's enable and disable. We'd prefer not to have vibrators in led subsystem. > > Xing Zhang (3): > dt-bindings: add regulator vibrator documentation > arm64: mediatek: Add regulator vibrator support > Vibrator: Add regulator vibrator driver > > .../bindings/leds/regulator-vibrator.txt | 39 ++ > arch/arm64/configs/defconfig | 1 + > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/regulator-vibrator.c | 450 ++++++++++++++++++ OTOH, connecting LED to regulator might make some sense. I can take the driver with vibrator functionality stripped, provided it is named the usual way... Best regards, Pavel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Add support for MediaTek regulator vibrator driver 2020-05-07 17:45 ` [PATCH v1] Add support for MediaTek regulator vibrator driver Pavel Machek @ 2020-05-07 20:45 ` Jacek Anaszewski 2020-05-07 21:09 ` Pavel Machek 0 siblings, 1 reply; 3+ messages in thread From: Jacek Anaszewski @ 2020-05-07 20:45 UTC (permalink / raw) To: Pavel Machek, Xing Zhang Cc: Matthias Brugger, Dan Murphy, linux-arm-kernel, linux-mediatek, linux-kernel, linux-leds Hi Pavel, On 5/7/20 7:45 PM, Pavel Machek wrote: > Hi! > >> This patchset add regulator vibrator driver for MTK Soc. The driver >> controls vibrator through regulator's enable and disable. > > We'd prefer not to have vibrators in led subsystem. > >> >> Xing Zhang (3): >> dt-bindings: add regulator vibrator documentation >> arm64: mediatek: Add regulator vibrator support >> Vibrator: Add regulator vibrator driver >> >> .../bindings/leds/regulator-vibrator.txt | 39 ++ >> arch/arm64/configs/defconfig | 1 + >> drivers/leds/Kconfig | 10 + >> drivers/leds/Makefile | 1 + >> drivers/leds/regulator-vibrator.c | 450 ++++++++++++++++++ > > OTOH, connecting LED to regulator might make some sense. I can take the driver with > vibrator functionality stripped, provided it is named the usual way... We already had an attempt of solving this in more generic way [0], but you opposed then [1]. Just for the record. [0] https://lore.kernel.org/linux-leds/20170913175400.42744-1-dtwlin@google.com/ [1] https://lore.kernel.org/linux-leds/20170914205804.GA24339@amd/ -- Best regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Add support for MediaTek regulator vibrator driver 2020-05-07 20:45 ` Jacek Anaszewski @ 2020-05-07 21:09 ` Pavel Machek 0 siblings, 0 replies; 3+ messages in thread From: Pavel Machek @ 2020-05-07 21:09 UTC (permalink / raw) To: Jacek Anaszewski Cc: Xing Zhang, Matthias Brugger, Dan Murphy, linux-arm-kernel, linux-mediatek, linux-kernel, linux-leds [-- Attachment #1: Type: text/plain, Size: 1470 bytes --] On Thu 2020-05-07 22:45:35, Jacek Anaszewski wrote: > Hi Pavel, > > On 5/7/20 7:45 PM, Pavel Machek wrote: > > Hi! > > > > > This patchset add regulator vibrator driver for MTK Soc. The driver > > > controls vibrator through regulator's enable and disable. > > > > We'd prefer not to have vibrators in led subsystem. > > > > > > > > Xing Zhang (3): > > > dt-bindings: add regulator vibrator documentation > > > arm64: mediatek: Add regulator vibrator support > > > Vibrator: Add regulator vibrator driver > > > > > > .../bindings/leds/regulator-vibrator.txt | 39 ++ > > > arch/arm64/configs/defconfig | 1 + > > > drivers/leds/Kconfig | 10 + > > > drivers/leds/Makefile | 1 + > > > drivers/leds/regulator-vibrator.c | 450 ++++++++++++++++++ > > > > OTOH, connecting LED to regulator might make some sense. I can take the driver with > > vibrator functionality stripped, provided it is named the usual way... > > We already had an attempt of solving this in more generic way [0], > but you opposed then [1]. Just for the record. That's something different. led-regulator.c might be acceptable. Special code to support vibrator quirks... not so much. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 21:09 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200429081759.26964-1-Xing.Zhang@mediatek.com> 2020-05-07 17:45 ` [PATCH v1] Add support for MediaTek regulator vibrator driver Pavel Machek 2020-05-07 20:45 ` Jacek Anaszewski 2020-05-07 21:09 ` Pavel Machek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).