From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] dt-bindings: leds: add Broadcom's BCM63xxx controller
Date: Mon, 22 Nov 2021 23:00:16 +0100 [thread overview]
Message-ID: <5113880f-d37d-0835-c140-c3749048c519@gmail.com> (raw)
In-Reply-To: <495a94ce-984e-f5c5-f5a2-74dc1b61e345@gmail.com>
On 22.11.2021 22:51, Florian Fainelli wrote:
> On 11/15/21 1:11 AM, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Broadcom used 2 LEDs hardware blocks for their BCM63xx SoCs:
>> 1. Older one (BCM6318, BCM6328, BCM6362, BCM63268, BCM6838)
>> 2. Newer one (BCM6848, BCM6858, BCM63138, BCM63148, BCM63381, BCM68360)
>
> Just so the existing pattern/regexps continue to work, I would be naming
> this "bcm63xx" to be consistent with the rest of existing code-base.
The problem I saw with "bcm63xx" is that it seems to match all SoCs:
those with old block and those with new block. So I guess both groups
have the same right to use that "bcm63xx" based binding.
To avoid favouring old or new block I decided to avoid "bcm63xx".
Given above explanation: do you still prefer using "bcm63xx" based
binding for the new block? I'm OK with that, I just want to make sure
you're aware of that minor issue. Please let me know :)
next prev parent reply other threads:[~2021-11-22 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:11 [PATCH 1/2] dt-bindings: leds: add Broadcom's BCM63xxx controller Rafał Miłecki
2021-11-15 9:11 ` [PATCH 2/2] leds: bcm63xxx: add support for " Rafał Miłecki
2021-11-22 22:04 ` Florian Fainelli
2021-11-24 8:11 ` Rafał Miłecki
2021-11-22 21:51 ` [PATCH 1/2] dt-bindings: leds: add Broadcom's " Florian Fainelli
2021-11-22 22:00 ` Rafał Miłecki [this message]
2021-11-23 22:17 ` Florian Fainelli
2021-11-23 22:19 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5113880f-d37d-0835-c140-c3749048c519@gmail.com \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).