From: Eddie James <eajames@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>, Pavel Machek <pavel@ucw.cz>,
Dan Murphy <dmurphy@ti.com>
Cc: "Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Vishwanatha Subbanna" <vishwa@linux.vnet.ibm.com>,
linux-leds@vger.kernel.org
Subject: Re: leds: pca955x: Allow full control over led name
Date: Fri, 26 Mar 2021 16:41:02 -0500 [thread overview]
Message-ID: <55566731-1a4e-0e91-d5d7-7ded3739f42d@linux.ibm.com> (raw)
In-Reply-To: <20210325005456.152469-1-joel@jms.id.au>
On 3/24/21 7:54 PM, Joel Stanley wrote:
> The PCA955x driver since it was merged has added a "pca955x:" prefix to
> LED names. This meanas platform data (such as the device tree) cannot
> fully control the name. Here's what this produces using the example in
> the device tree bindings:
>
> # cat /sys/class/leds/
> pca955x:green:power/
> pca955x:pca9552:white/
> pca955x:pca9552:yellow/
> pca955x:red:power/
>
> Some systems want the ability to configure the full string. To do this,
> introduce a build time option that adds the prefix that defaults to
> enabled in order to preserve existing behaviour.
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/leds/Kconfig | 11 +++++++++++
> drivers/leds/leds-pca955x.c | 8 +++++++-
> 2 files changed, 18 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2021-03-26 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 0:54 [PATCH] leds: pca955x: Allow full control over led name Joel Stanley
2021-03-26 21:41 ` Eddie James [this message]
[not found] ` <1807483D-FF4A-454F-B0B9-AC373B938292@linux.vnet.ibm.com>
2021-04-14 11:06 ` vishwanatha subbanna
2021-04-25 21:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55566731-1a4e-0e91-d5d7-7ded3739f42d@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=dmurphy@ti.com \
--cc=joel@jms.id.au \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=vishwa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).