From: Randy Dunlap <rdunlap@infradead.org>
To: "Ansuel Smith" <ansuelsmth@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>, "Pavel Machek" <pavel@ucw.cz>,
"John Crispin" <john@phrozen.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-leds@vger.kernel.org, "Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH v5 2/8] leds: document additional use of blink_set for hardware control
Date: Fri, 12 Nov 2021 16:55:58 -0800 [thread overview]
Message-ID: <5ef01f7d-b250-73e5-3f06-d03aba1304c7@infradead.org> (raw)
In-Reply-To: <20211112153557.26941-3-ansuelsmth@gmail.com>
On 11/12/21 7:35 AM, Ansuel Smith wrote:
> diff --git a/Documentation/leds/leds-class.rst b/Documentation/leds/leds-class.rst
> index e5d266919a19..fa6e1cfc4628 100644
> --- a/Documentation/leds/leds-class.rst
> +++ b/Documentation/leds/leds-class.rst
> @@ -202,6 +202,23 @@ hardware mode and any software only trigger will reject activation.
> On init an LED driver that support a hardware mode should reset every blink mode
> set by default.
>
> +Once a trigger has declared support for hardware-controlled blinks, it will use
> +blink_set() to try to offload his trigger on activation/configuration.
this trigger
> +blink_set() will return 0 if the requested modes set in trigger_data can be
> +controlled by hardware or an error if both of the bitmap modes are not supported by
> +the hardware or there was a problem in the configuration.
> +
> +Following blink_set logic, setting brightness to LED_OFF with hardware control active
> +will reset any active blink mode and disable hardware control setting the LED to off.
> +
> +It's in the LED driver's interest to know how to elaborate the trigger data and report support
> +for a particular set of blink modes. For this exact reason explicit support for the specific
> +trigger is mandatory or the driver returns -EOPNOTSUPP if asked to enter hardware mode
> +with a not supported trigger.
> +If the driver returns -EOPNOTSUPP on hw_control_configure(), the trigger activation will
> +fail as the driver doesn't support that specific hardware blink mode or doesn't know
> +how to handle the provided trigger data.
--
~Randy
next prev parent reply other threads:[~2021-11-13 0:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 15:35 [PATCH v5 0/8] Adds support for PHY LEDs with offload triggers Ansuel Smith
2021-11-12 15:35 ` [PATCH v5 1/8] leds: add support for hardware driven LEDs Ansuel Smith
2021-11-13 1:04 ` Randy Dunlap
2021-11-12 15:35 ` [PATCH v5 2/8] leds: document additional use of blink_set for hardware control Ansuel Smith
2021-11-13 0:55 ` Randy Dunlap [this message]
2021-11-12 15:35 ` [PATCH v5 3/8] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode Ansuel Smith
2021-11-12 15:35 ` [PATCH v5 4/8] leds: trigger: netdev: rename and expose NETDEV trigger enum and struct Ansuel Smith
2021-11-12 15:35 ` [PATCH v5 5/8] leds: trigger: netdev: add hardware control support Ansuel Smith
2021-11-12 15:35 ` [PATCH v5 6/8] leds: trigger: add hardware-phy-activity trigger Ansuel Smith
2021-11-13 0:52 ` Randy Dunlap
2021-11-12 15:35 ` [PATCH v5 7/8] net: dsa: qca8k: add LEDs support Ansuel Smith
2021-11-12 15:35 ` [PATCH v5 8/8] dt-bindings: net: dsa: qca8k: add LEDs definition example Ansuel Smith
2021-11-28 23:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ef01f7d-b250-73e5-3f06-d03aba1304c7@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).