From: "Vesa Jääskeläinen" <dachaac@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Hermes Zhang <chenhui.zhang@axis.com>,
dmurphy@ti.com, robh+dt@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
chenhuiz@axis.com, lkml@axis.com, kernel@axis.com
Subject: Re: [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings
Date: Sun, 28 Mar 2021 23:46:16 +0300 [thread overview]
Message-ID: <6313e117-e0f8-ef7c-9165-96c5d2b9d318@gmail.com> (raw)
In-Reply-To: <20210325184140.GA16039@duo.ucw.cz>
Hi,
On 25.3.2021 20.41, Pavel Machek wrote:
>>> + led-gpios:
>>> + description: Array of one or more GPIOs pins used to control the LED.
>>> + minItems: 1
>>> + maxItems: 8 # Should be enough
>>
>> We also have a case with multi color LEDs (which is probably a more common
>> than multi intensity LED. So I am wondering how these both could co-exist.
>>
>> From: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-gpio.yaml?h=v5.12-rc4#n58
>>
>> led-0 {
>> gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "disk-activity";
>> function = LED_FUNCTION_DISK;
>> };
>>
>> Now 'gpios' (and in LED context) and 'led-gpios' is very close to each other
>> and could easily be confused.
>>
>> Perhaps this could be something like:
>>
>> intensity-gpios = ...
>>
>> or even simplified then just to gpios = <...>
>
> ...
>> How would this sound?
>
> Well, not too bad on a quick look.
>
> Are you willing to implement such multi-color-multi-bit-multi-gpio
> driver?
We have a need for multi color GPIO LED support so I can work on that if
no one else gets there before me -- I do not have hardware with multiple
GPIO lines controlling the brightness so that needs a bit more effort in
order to test that out.
At some point of time I could also revive the PWM stuff if no one else
beats me to it -- but probably the GPIO variant is easier to get done as
binary states are easier.
Thanks,
Vesa Jääskeläinen
next prev parent reply other threads:[~2021-03-28 20:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:56 [PATCH 0/2] New multiple GPIOs LED driver Hermes Zhang
2021-03-24 7:56 ` [PATCH 1/2] leds: leds-multi-gpio: Add " Hermes Zhang
2021-03-24 10:34 ` Marek Behun
2021-03-24 10:40 ` Pavel Machek
2021-03-24 10:42 ` Pavel Machek
2021-03-25 6:04 ` Hermes Zhang
2021-03-25 12:26 ` Marek Behun
2021-03-24 10:41 ` Pavel Machek
2021-03-24 7:56 ` [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings Hermes Zhang
2021-03-24 10:40 ` Marek Behun
2021-03-25 5:27 ` Vesa Jääskeläinen
2021-03-25 18:41 ` Pavel Machek
2021-03-28 20:46 ` Vesa Jääskeläinen [this message]
2021-03-24 10:42 ` [PATCH 0/2] New multiple GPIOs LED driver Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6313e117-e0f8-ef7c-9165-96c5d2b9d318@gmail.com \
--to=dachaac@gmail.com \
--cc=chenhui.zhang@axis.com \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkml@axis.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).