From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Markus Elfring" <Markus.Elfring@web.de>,
linux-leds@vger.kernel.org,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Dan Murphy" <dmurphy@ti.com>, "Pavel Machek" <pavel@ucw.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Himanshu Jha <himanshujha199640@gmail.com>
Subject: Re: [PATCH] leds-bcm63xx: Use devm_platform_ioremap_resource() in two functions
Date: Thu, 19 Sep 2019 22:35:34 +0200 [thread overview]
Message-ID: <658bd05d-376d-adfd-64a5-e20f83d7b90a@gmail.com> (raw)
In-Reply-To: <b6ea044c-c483-0de6-67c5-5ea2fa3c85aa@web.de>
Hi Markus,
Thank you for the patch.
Please split it to two separate ones - one per affected driver.
Best regards,
Jacek Anaszewski
On 9/18/19 10:55 AM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 18 Sep 2019 10:45:24 +0200
>
> Simplify these function implementations by using a known function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/leds/leds-bcm6328.c | 7 +------
> drivers/leds/leds-bcm6358.c | 7 +------
> 2 files changed, 2 insertions(+), 12 deletions(-)
next prev parent reply other threads:[~2019-09-19 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 8:55 [PATCH] leds-bcm63xx: Use devm_platform_ioremap_resource() in two functions Markus Elfring
2019-09-19 20:35 ` Jacek Anaszewski [this message]
2019-09-20 12:40 ` [PATCH v2] leds-bcm6328: Use devm_platform_ioremap_resource() in bcm6328_leds_probe() Markus Elfring
2019-09-20 19:49 ` Jacek Anaszewski
2019-09-20 12:50 ` [PATCH v2] leds-bcm6358: Use devm_platform_ioremap_resource() in bcm6358_leds_probe() Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658bd05d-376d-adfd-64a5-e20f83d7b90a@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=bgolaszewski@baylibre.com \
--cc=dmurphy@ti.com \
--cc=himanshujha199640@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).