From: Dan Murphy <dmurphy@ti.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<tony@atomide.com>, <sre@kernel.org>, <nekit1000@gmail.com>,
<mpartap@gmx.net>, <merlijn@wizzup.org>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt: lm3532: Add property for full scale current.
Date: Thu, 1 Aug 2019 14:12:02 -0500 [thread overview]
Message-ID: <73134d05-7422-8f4e-01d1-63a80a5bb87e@ti.com> (raw)
In-Reply-To: <2c486267-e0b4-25f3-0a3e-189447adf8b5@gmail.com>
Jacek
On 8/1/19 1:53 PM, Jacek Anaszewski wrote:
> Dan,
>
> On 8/1/19 5:14 PM, Dan Murphy wrote:
>> Add a property for each control bank to configure the
>> full scale current setting for the device.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> Documentation/devicetree/bindings/leds/leds-lm3532.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3532.txt b/Documentation/devicetree/bindings/leds/leds-lm3532.txt
>> index c087f85ddddc..d3498dd24e8e 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lm3532.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3532.txt
>> @@ -62,6 +62,9 @@ Optional LED child properties:
>> - label : see Documentation/devicetree/bindings/leds/common.txt
>> - linux,default-trigger :
>> see Documentation/devicetree/bindings/leds/common.txt
>> + - ti,fs-current : Defines the full scale current value for each control
>> + bank. The range is from 5000uA-29800uA in increments
>> + of 800uA.
> Wouldn't led-max-microamp fit here?
Ah thats what I was looking for. I would rather use existing properties.
I will change that.
Dan
next prev parent reply other threads:[~2019-08-01 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 15:14 [PATCH 1/3] leds: lm3532: Fix brightness control for i2c mode Dan Murphy
2019-08-01 15:14 ` [PATCH 2/3] dt: lm3532: Add property for full scale current Dan Murphy
2019-08-01 18:53 ` Jacek Anaszewski
2019-08-01 19:12 ` Dan Murphy [this message]
2019-08-01 15:14 ` [PATCH 3/3] leds: lm3532: Add full scale current configuration Dan Murphy
2019-08-01 18:52 ` [PATCH 1/3] leds: lm3532: Fix brightness control for i2c mode Jacek Anaszewski
2019-08-01 19:17 ` Dan Murphy
2019-08-01 19:48 ` Jacek Anaszewski
2019-08-01 21:36 ` Pavel Machek
2019-08-02 0:02 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73134d05-7422-8f4e-01d1-63a80a5bb87e@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).