From: "Andreas Färber" <afaerber@suse.de>
To: linux-realtek-soc@lists.infradead.org, linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org, Dan Murphy <dmurphy@ti.com>
Subject: Re: [RFC 07/25] leds: Add Titan Micro Electronics TM1628
Date: Sat, 14 Dec 2019 10:48:04 +0100 [thread overview]
Message-ID: <7441a2d5-f10a-8ca9-8df9-10c0a78cbeb7@suse.de> (raw)
In-Reply-To: <20191212033952.5967-8-afaerber@suse.de>
Am 12.12.19 um 04:39 schrieb Andreas Färber:
> diff --git a/drivers/leds/leds-tm1628.c b/drivers/leds/leds-tm1628.c
> new file mode 100644
> index 000000000000..319bf34ce835
> --- /dev/null
> +++ b/drivers/leds/leds-tm1628.c
[...]
> +struct tm1628 {
> + struct spi_device *spi;
> + const struct tm1628_info *info;
> + u32 grids;
> + unsigned int segments;
These fields were unused since introducing mode_index, dropping.
> + int mode_index;
> + int pwm_index;
> + u8 data[14];
> + unsigned int num_leds;
> + struct tm1628_led leds[];
> +};
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2019-12-14 9:48 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 3:39 [RFC 00/25] arm64: realtek: Add Xnano X5 and implement TM1628/FD628/AiP1618 LED controllers Andreas Färber
2019-12-12 3:39 ` [RFC 01/25] dt-bindings: vendor-prefixes: Add Xnano Andreas Färber
2019-12-19 22:26 ` Rob Herring
2019-12-12 3:39 ` [RFC 02/25] dt-bindings: arm: realtek: Add Xnano X5 Andreas Färber
2019-12-19 22:27 ` Rob Herring
2019-12-12 3:39 ` [RFC 03/25] arm64: dts: realtek: rtd1295: " Andreas Färber
2019-12-12 3:39 ` [RFC 04/25] spi: gpio: Implement LSB First bitbang support Andreas Färber
2019-12-12 8:40 ` Geert Uytterhoeven
2019-12-12 15:14 ` Andreas Färber
2019-12-12 17:19 ` Mark Brown
2019-12-12 21:08 ` Andreas Färber
2019-12-13 11:42 ` Mark Brown
2019-12-12 3:39 ` [RFC 05/25] dt-bindings: vendor-prefixes: Add Titan Micro Electronics Andreas Färber
2019-12-19 22:31 ` Rob Herring
2019-12-12 3:39 ` [RFC 06/25] dt-bindings: leds: Add Titan Micro Electronics TM1628 Andreas Färber
2019-12-19 23:04 ` Rob Herring
2019-12-12 3:39 ` [RFC 07/25] " Andreas Färber
2019-12-14 9:48 ` Andreas Färber [this message]
2019-12-12 3:39 ` [RFC 08/25] arm64: dts: realtek: rtd129x-zidoo-x9s: Add TM1628 LED controller Andreas Färber
2019-12-12 3:39 ` [RFC 09/25] arm64: dts: realtek: rtd1295-zidoo-x9s: Add regular LEDs to TM1628 Andreas Färber
2019-12-12 3:39 ` [RFC 10/25] dt-bindings: vendor-prefixes: Add Fuda Hisi Microelectronics Andreas Färber
2019-12-19 23:04 ` Rob Herring
2019-12-12 3:39 ` [RFC 11/25] dt-bindings: leds: tm1628: Add Fuda Hisi Microelectronics FD628 Andreas Färber
2019-12-19 23:05 ` Rob Herring
2019-12-12 3:39 ` [RFC 12/25] " Andreas Färber
2019-12-12 3:39 ` [RFC 13/25] arm64: dts: realtek: rtd1295-xnano-x5: Add FD628 LED controller Andreas Färber
2019-12-12 3:39 ` [RFC 14/25] arm64: dts: realtek: rtd1295-xnano-x5: Add regular LEDs to FD628 Andreas Färber
2019-12-21 20:21 ` Pavel Machek
2019-12-12 3:39 ` [RFC 15/25] dt-bindings: vendor-prefixes: Add Fude Microelectronics Andreas Färber
2019-12-19 23:05 ` Rob Herring
2019-12-12 3:39 ` [RFC 16/25] dt-bindings: leds: tm1628: Add Fude Microelectronics AiP1618 Andreas Färber
2019-12-19 23:06 ` Rob Herring
2019-12-12 3:39 ` [RFC 17/25] leds: tm1628: Prepare " Andreas Färber
2019-12-21 19:55 ` Andreas Färber
2019-12-12 3:39 ` [RFC 18/25] dt-bindings: leds: tm1628: Define display child nodes Andreas Färber
2019-12-12 3:39 ` [RFC 19/25] leds: tm1628: Add 7-segment display support Andreas Färber
2019-12-12 8:33 ` Geert Uytterhoeven
2019-12-12 14:10 ` Andreas Färber
2019-12-21 20:23 ` Pavel Machek
2019-12-12 3:39 ` [RFC 20/25] arm64: dts: realtek: rtd1295-zidoo-x9s: Add display to TM1628 Andreas Färber
2019-12-12 3:39 ` [RFC 21/25] arm64: dts: realtek: rtd1295-xnano-x5: Add display to FD628 Andreas Färber
2019-12-12 3:39 ` [RFC 22/25] leds: tm1826: Add combined glyph support Andreas Färber
2019-12-21 20:27 ` Pavel Machek
2019-12-21 20:41 ` Andreas Färber
2019-12-21 21:04 ` Pavel Machek
2019-12-21 21:49 ` Andreas Färber
[not found] ` <CANiq72nA9OLa0SjY8W055J_2A32tcp7S98SruKSdWH2dm25VKw@mail.gmail.com>
2019-12-22 3:14 ` Andreas Färber
2020-01-15 14:31 ` Miguel Ojeda
2019-12-12 3:39 ` [RFC 23/25] WIP: leds: tm1628: Prepare TM1628 keys Andreas Färber
2019-12-12 3:39 ` [RFC 24/25] WIP: leds: tm1628: Prepare FD628 keys Andreas Färber
2019-12-12 3:39 ` [RFC 25/25] WIP: leds: tm1628: Prepare AiP1618 keys Andreas Färber
2019-12-12 13:14 ` [RFC 00/25] arm64: realtek: Add Xnano X5 and implement TM1628/FD628/AiP1618 LED controllers Robin Murphy
2019-12-12 20:55 ` Andreas Färber
2019-12-13 14:07 ` Robin Murphy
2019-12-13 14:36 ` Geert Uytterhoeven
2020-02-25 21:42 ` Ezra Buehler
2020-02-26 13:03 ` Pavel Machek
2019-12-21 18:20 ` Pavel Machek
2019-12-21 21:07 ` Andreas Färber
2020-01-15 13:34 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7441a2d5-f10a-8ca9-8df9-10c0a78cbeb7@suse.de \
--to=afaerber@suse.de \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).