From: Dan Murphy <dmurphy@ti.com>
To: Oleh Kravchenko <oleg@kaa.org.ua>, <devicetree@vger.kernel.org>,
<linux-leds@vger.kernel.org>, <jacek.anaszewski@gmail.com>,
<pavel@ucw.cz>
Subject: Re: [PATCH v8 1/2] dt-bindings: Add docs for EL15203000
Date: Fri, 13 Sep 2019 08:40:28 -0500 [thread overview]
Message-ID: <7af9f38e-bf5e-97fc-fd49-87fd8b8c98a6@ti.com> (raw)
In-Reply-To: <20190912221115.23595-2-oleg@kaa.org.ua>
Oleh
On 9/12/19 5:11 PM, Oleh Kravchenko wrote:
> Add documentation and example for dt-bindings EL15203000.
> LED board (aka RED LED board) from Crane Merchandising Systems.
>
> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
> ---
> .../bindings/leds/leds-el15203000.txt | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-el15203000.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-el15203000.txt b/Documentation/devicetree/bindings/leds/leds-el15203000.txt
> new file mode 100644
> index 000000000000..d74b492d28b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-el15203000.txt
> @@ -0,0 +1,53 @@
> +Crane Merchandising System - el15203000 LED driver
> +--------------------------------------------------
> +
> +This LED Board (aka RED LEDs board) is widely used in
> +coffee vending machines produced by Crane Merchandising Systems.
> +
> +Required properties:
> +- compatible : "crane,el15203000"
> +
> +Property rules described in
> +Documentation/devicetree/bindings/spi/spi-controller.yaml is apply.
Not sure what this statement means
> +In particular, "reg" and "spi-max-frequency" properties must be given.
> +50KHz is very well tested value for spi-max-frequency.
> +
> +Optional LED sub-node properties:
> +- function:
> + see Documentation/devicetree/bindings/leds/common.txt
This was not fixed per v7 comments
Where is the "reg" property definition for the LED child node?
What is the 0x50,0x53 and 0x56 mean? Are there any other values?
Dan
<snip>
next prev parent reply other threads:[~2019-09-13 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 22:11 v7 EL15203000 Oleh Kravchenko
2019-09-12 22:11 ` [PATCH v8 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-09-13 13:40 ` Dan Murphy [this message]
2019-09-12 22:11 ` [PATCH v8 2/2] leds: add LED driver for EL15203000 board Oleh Kravchenko
2019-09-13 13:42 ` Dan Murphy
2019-09-13 13:36 ` v7 EL15203000 Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7af9f38e-bf5e-97fc-fd49-87fd8b8c98a6@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).