From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Pavel Machek <pavel@ucw.cz>, Jeff LaBundy <jeff@labundy.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Thierry Reding <thierry.reding@gmail.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH 2/3] leds: pwm: convert to atomic PWM API
Date: Wed, 26 Feb 2020 15:55:44 +0100 [thread overview]
Message-ID: <863bdd8c-570d-9cf9-4eda-a873b039696b@kleine-koenig.org> (raw)
In-Reply-To: <20200226143522.GM4080@duo.ucw.cz>
[-- Attachment #1.1: Type: text/plain, Size: 1038 bytes --]
Hi Pavel,
On 2/26/20 3:35 PM, Pavel Machek wrote:
>> On Fri, Jan 24, 2020 at 05:54:08PM +0100, Uwe Kleine-König wrote:
>>> pwm_config(), pwm_enable() and pwm_disable() should get removed in the
>>> long run. So update the driver to use the atomic API that is here to
>>> stay.
>>>
>>> A few side effects:
>>>
>>> - led_pwm_set() now returns an error when setting the PWM fails.
>>> - During .probe() the PWM isn't disabled implicitly by pwm_apply_args()
>>> any more.
>>>
>>> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>
>> And so:
>>
>> Tested-by: Jeff LaBundy <jeff@labundy.com>
>
> Thanks for patches, thanks for testing.
>
> 1,2 applied to -for-next.
>
> AFAICT 3/3 should really get the default-state: keep support before
> being merged?
Maybe I miss something, but I wonder why default-state: keep support
isn't implemented in the core but in each led driver instead. (And as
soon as someone implements it in the core, patch 3 is the right thing to
do.)
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-26 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 16:54 [PATCH 0/3] leds: pwm: some cleanups Uwe Kleine-König
2020-01-24 16:54 ` [PATCH 1/3] leds: pwm: simplify if condition Uwe Kleine-König
2020-01-26 18:55 ` Jeff LaBundy
2020-01-24 16:54 ` [PATCH 2/3] leds: pwm: convert to atomic PWM API Uwe Kleine-König
2020-01-26 19:15 ` Jeff LaBundy
2020-02-26 14:35 ` Pavel Machek
2020-02-26 14:55 ` Uwe Kleine-König [this message]
2020-01-24 16:54 ` [PATCH 3/3] leds: pwm: don't set the brightness during .probe Uwe Kleine-König
2020-01-26 19:42 ` Jeff LaBundy
2020-01-27 7:41 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863bdd8c-570d-9cf9-4eda-a873b039696b@kleine-koenig.org \
--to=uwe@kleine-koenig.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jeff@labundy.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).