linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static
@ 2023-06-01 21:34 Arnd Bergmann
  2023-06-02 12:59 ` Hans de Goede
  0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2023-06-01 21:34 UTC (permalink / raw)
  To: Pavel Machek, Lee Jones, Hans de Goede, Yauhen Kharuzhy
  Cc: Arnd Bergmann, linux-leds, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

This was apparently made global but is not called from anywhere else:

drivers/leds/leds-cht-wcove.c:144:21: error: no previous prototype for 'cht_wc_leds_brightness_get' [-Werror=missing-prototypes]

Fixes: 047da762b9a93 ("leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/leds/leds-cht-wcove.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 0cfebee989107..0a5c30e5ed5d4 100644
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
 	return ret;
 }
 
-enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
+static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
 {
 	struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
 	unsigned int val;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static
  2023-06-01 21:34 [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static Arnd Bergmann
@ 2023-06-02 12:59 ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2023-06-02 12:59 UTC (permalink / raw)
  To: Arnd Bergmann, Pavel Machek, Lee Jones, Yauhen Kharuzhy
  Cc: Arnd Bergmann, linux-leds, linux-kernel

Hi Arnd,

On 6/1/23 23:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This was apparently made global but is not called from anywhere else:
> 
> drivers/leds/leds-cht-wcove.c:144:21: error: no previous prototype for 'cht_wc_leds_brightness_get' [-Werror=missing-prototypes]
> 
> Fixes: 047da762b9a93 ("leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you for the patch. This is a duplicate fix with these
2 earlier submissions of the same fix:

https://lore.kernel.org/linux-leds/20230525183317.129232-1-hdegoede@redhat.com/
https://lore.kernel.org/linux-leds/20230530234748.3641630-1-trix@redhat.com/

Regards,

Hans





> ---
>  drivers/leds/leds-cht-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
> index 0cfebee989107..0a5c30e5ed5d4 100644
> --- a/drivers/leds/leds-cht-wcove.c
> +++ b/drivers/leds/leds-cht-wcove.c
> @@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
>  	return ret;
>  }
>  
> -enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
> +static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
>  {
>  	struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
>  	unsigned int val;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] leds: cht-wcove: Mark cht_wc_leds_brightness_get() static
  2023-05-25 18:33 [PATCH] leds: cht-wcove: Mark cht_wc_leds_brightness_get() static Hans de Goede
@ 2023-06-08 14:56 ` Lee Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-06-08 14:56 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Pavel Machek, linux-leds, Yauhen Kharuzhy, kernel test robot

On Thu, 25 May 2023, Hans de Goede wrote:

> cht_wc_leds_brightness_get() is only used internally, mark it static.
> 
> Cc: Yauhen Kharuzhy <jekhor@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202305260008.QCRrKILf-lkp@intel.com/
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/leds/leds-cht-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] leds: cht-wcove: Mark cht_wc_leds_brightness_get() static
@ 2023-05-25 18:33 Hans de Goede
  2023-06-08 14:56 ` Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2023-05-25 18:33 UTC (permalink / raw)
  To: Pavel Machek, Lee Jones
  Cc: Hans de Goede, linux-leds, Yauhen Kharuzhy, kernel test robot

cht_wc_leds_brightness_get() is only used internally, mark it static.

Cc: Yauhen Kharuzhy <jekhor@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202305260008.QCRrKILf-lkp@intel.com/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/leds/leds-cht-wcove.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 0cfebee98910..0a5c30e5ed5d 100644
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
 	return ret;
 }
 
-enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
+static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
 {
 	struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
 	unsigned int val;
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-08 14:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 21:34 [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static Arnd Bergmann
2023-06-02 12:59 ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2023-05-25 18:33 [PATCH] leds: cht-wcove: Mark cht_wc_leds_brightness_get() static Hans de Goede
2023-06-08 14:56 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).