From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com,
Jonas Gorski <jonas.gorski@gmail.com>,
rpurdie@rpsys.net
Subject: Re: [PATCH v3] leds-bcm6328: support second hw blinking interval
Date: Thu, 4 Jun 2020 16:00:05 +0200 [thread overview]
Message-ID: <8AE81CB2-8A26-43D4-AA4D-C89758E675A1@gmail.com> (raw)
In-Reply-To: <20200604135354.GJ7222@duo.ucw.cz>
Sorry, I had just sent v4 without it.
However, I’ve now sent v5 with the summary.
Best regards,
Álvaro.
> El 4 jun 2020, a las 15:53, Pavel Machek <pavel@ucw.cz> escribió:
>
> On Thu 2020-06-04 15:43:35, Álvaro Fernández Rojas wrote:
>> Hi Pavel,
>>
>>> El 4 jun 2020, a las 15:40, Pavel Machek <pavel@ucw.cz> escribió:
>>>
>>> On Thu 2020-06-04 15:35:06, Álvaro Fernández Rojas wrote:
>>>> HI Pavel,
>>>>
>>>> Right now, only one hw blinking interval is supported, but up to two hw blinking intervals can be configured in the controller.
>>>> This patch just adds support for the second hw blinking interval.
>>>>
>>>> BTW, I will send v4 which should clarify that each LED can be configured in 4 modes:
>>>> 0: On
>>>> 1: HW Blinking (Interval 1)
>>>> 2: HW Blinking (Interval 2)
>>>> 3: Off
>>>>
>>>> Until now we were only using 3 modes:
>>>> 0: On
>>>> 1: HW Blinking (Interval 1)
>>>> 3: Off
>>>
>>> So the issue is .... there are like 5 LEDs and they can be on or off
>>> or blinking with at most 2 different intervals?
>>> Pavel
>>
>> Yes, the controller supports two different blinking delays (intervals), and LEDs can either be on, off or assigned to one of the two blinking delays.
>> However, the current upstream controller only supports one blinking delay. This patch just adds support for both blinking delays instead of just one.
>>
>
> Ok. Please put this kind of summary in comment somewhere.
>
> Best regards,
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-06-04 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 12:46 [PATCH] leds-bcm6328: support second hw blinking interval Álvaro Fernández Rojas
2020-04-24 13:32 ` [PATCH v2] " Álvaro Fernández Rojas
2020-04-25 21:14 ` Pavel Machek
2020-04-26 8:39 ` Álvaro Fernández Rojas
2020-05-12 10:01 ` [PATCH v3] " Álvaro Fernández Rojas
2020-06-04 13:24 ` Pavel Machek
2020-06-04 13:35 ` Álvaro Fernández Rojas
2020-06-04 13:40 ` Pavel Machek
2020-06-04 13:43 ` Álvaro Fernández Rojas
2020-06-04 13:53 ` Pavel Machek
2020-06-04 14:00 ` Álvaro Fernández Rojas [this message]
2020-06-04 13:48 ` [PATCH v4] " Álvaro Fernández Rojas
2020-06-04 13:59 ` [PATCH v5] " Álvaro Fernández Rojas
2020-06-04 14:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8AE81CB2-8A26-43D4-AA4D-C89758E675A1@gmail.com \
--to=noltari@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).