From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA3BC4CEC9 for ; Wed, 18 Sep 2019 18:45:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0420821927 for ; Wed, 18 Sep 2019 18:45:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="yFSPDOfc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbfIRSpl (ORCPT ); Wed, 18 Sep 2019 14:45:41 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:56918 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfIRSpl (ORCPT ); Wed, 18 Sep 2019 14:45:41 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8IIjbhR088798; Wed, 18 Sep 2019 13:45:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1568832337; bh=EXt8+T246I96qjzHn0OTx9qPWlbzfdV0acnWhBtUscQ=; h=Subject:To:References:From:Date:In-Reply-To; b=yFSPDOfcm+jvM/UgrFAIv5irGShkWaFB74jqABIJA/y+zlACz8L2cn3DvCEqrhP5h u+BWsA4US9PXuIuAs4y6G223WlX6XMdcGXMaO0Fe1sB94sgLW8XozqWaJ3Nr+p52ST ejw/jIcP7kFpxHUMsqiy3vOJBDLIz/E3nXuKeINM= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8IIjbrl028043 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Sep 2019 13:45:37 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 18 Sep 2019 13:45:33 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 18 Sep 2019 13:45:37 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8IIjap6107852; Wed, 18 Sep 2019 13:45:36 -0500 Subject: Re: [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL To: =?UTF-8?Q?Guido_G=c3=bcnther?= , Jacek Anaszewski , Pavel Machek , , References: From: Dan Murphy Message-ID: <905f43fb-b75c-d0f2-8669-275e18241735@ti.com> Date: Wed, 18 Sep 2019 13:48:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Guido On 9/17/19 9:19 PM, Guido Günther wrote: > Use LM3692X_RAMP_EN instead of LM3692X_PWM_HYSTER_4LSB > since the later is a flag for the PWM register. The > actual register value remains unchanged. > > Signed-off-by: Guido Günther Reviewed-by: Dan Murphy > --- > drivers/leds/leds-lm3692x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c > index d673f706385e..ecac586ca89c 100644 > --- a/drivers/leds/leds-lm3692x.c > +++ b/drivers/leds/leds-lm3692x.c > @@ -269,7 +269,7 @@ static int lm3692x_init(struct lm3692x_led *led) > goto out; > > ret = regmap_write(led->regmap, LM3692X_BRT_CTRL, > - LM3692X_BL_ADJ_POL | LM3692X_PWM_HYSTER_4LSB); > + LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN); > if (ret) > goto out; >