From: Robin Murphy <robin.murphy@arm.com>
To: Johan Jonker <jbx6244@gmail.com>, Chen-Yu Tsai <wens@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
"Heiko Stübner" <heiko@sntech.de>, "Pavel Machek" <pavel@ucw.cz>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Rob Herring" <robh+dt@kernel.org>,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dmurphy@ti.com
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers
Date: Mon, 27 Apr 2020 16:13:59 +0100 [thread overview]
Message-ID: <94e7671f-2d11-b2f7-e049-b90893c61ab2@arm.com> (raw)
In-Reply-To: <a81840d3-813b-51b5-767c-e0d9d270200e@gmail.com>
On 2020-04-27 3:12 pm, Johan Jonker wrote:
> Hi,
>
>>> So for fixing up the LED node names, we'd probably want the following:
>>>
>>> diy_led: led-0
>>> yellow_led: led-1
>>> work_led: led-2
>
> Change proposal for led nodes to comply with preexisting dts.
> Does this work?
>
> diy_led: led_0: led-0
> yellow_led: led_1: led-1
> work_led: led_2: led-2
Yuck, why?
Labels are simply human-readable source annotations for the sake of
referencing nodes more easily. Meaningful label names - that correlate
to SoC or board components, schematic names, or physical labels on the
board/device - make the DT sources easier to read, review, and maintain.
There are a handful of cases where one node might have multiple labels,
e.g. if two logical supply nets come from the same regulator on certain
board variants, but there is zero point in defining redundant labels
that just meaninglessly echo the DT's own structure.
> blue: led_0: led-0
>
> A check does not give any warnings.
I should hope not. Labels are there to be consumed by DT compilers (and
whatever symbolic overlay handlers count as... DT linkers, maybe?) -
they have no business being within the scope of the bindings that define
a contract for system software consuming the final DTB.
Robin.
> make -k ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml
>
>>
>> That doesn't look pretty either.
>> Would like to hear the maintainers view on how to handle other cases
>> without 'led' like for example 'blue' for mk808.
>>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
next prev parent reply other threads:[~2020-04-27 15:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 7:31 [PATCH v2 0/3] arm64: dts: rockchip: misc. cleanups and improvements Chen-Yu Tsai
2020-04-27 7:31 ` [PATCH v2 1/3] dt-bindings: leds: common: Drop enumeration for linux,default-triggers Chen-Yu Tsai
2020-04-27 8:33 ` Johan Jonker
2020-04-27 9:21 ` Chen-Yu Tsai
2020-05-11 23:12 ` Rob Herring
2020-04-27 7:31 ` [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers Chen-Yu Tsai
2020-04-27 8:57 ` Johan Jonker
2020-04-27 9:17 ` Chen-Yu Tsai
2020-04-27 10:08 ` Johan Jonker
2020-04-27 10:33 ` Chen-Yu Tsai
2020-04-27 10:55 ` Johan Jonker
2020-04-27 14:12 ` Johan Jonker
2020-04-27 14:45 ` Chen-Yu Tsai
2020-04-27 15:13 ` Robin Murphy [this message]
2020-04-27 7:31 ` [PATCH v2 3/3] arm64: dts: rockchip: rk3328-roc-cc: Set dr_mode to "host" for OTG Chen-Yu Tsai
2020-05-05 6:24 ` [PATCH v2 0/3] arm64: dts: rockchip: misc. cleanups and improvements Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94e7671f-2d11-b2f7-e049-b90893c61ab2@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).