From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 0/2] tps6105x add devicetree and leds support
Date: Fri, 22 Nov 2019 22:04:58 +0100 [thread overview]
Message-ID: <957d06d2-90d6-6a19-87ab-9cce7d03543d@gmail.com> (raw)
In-Reply-To: <CAGngYiXtHC7Ez2c1wXSx13jTcaq+vW69FpNokZYvk7vqt6FmpA@mail.gmail.com>
On 11/22/19 2:36 PM, Sven Van Asbroeck wrote:
> On Thu, Nov 21, 2019 at 1:20 PM Jacek Anaszewski
> <jacek.anaszewski@gmail.com> wrote:
>>
>> For both patches:
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>
> Thank you Jacek. To get accepted in a maintainer tree, does this
> patch need more acks/reviews?
It should get ack from Pavel Machek since he now maintains LED tree.
I'd say that it should be merged in one batch with the related change
to the MFD driver, but this is to be agreed upon by Pavel and Lee, via
which tree it will go.
> Should I continue to include it in new patch set versions if it doesn't
> change?
You can include it, and add my ack.
However, you could remove also below lines, since you switched
to using color DT property and a new LED registration API:
- init_data.devicename = "tps6105x";
- init_data.default_label = ":torch";
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-11-22 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 14:27 [PATCH v4 0/2] tps6105x add devicetree and leds support Sven Van Asbroeck
2019-11-21 14:27 ` [PATCH v4 1/2] leds: tps6105x: add driver for mfd chip led mode Sven Van Asbroeck
2019-11-21 14:27 ` [PATCH v4 2/2] dt-bindings: mfd: update TI tps6105x chip bindings Sven Van Asbroeck
2019-11-23 0:02 ` Rob Herring
2019-12-09 12:32 ` Lee Jones
2019-12-09 13:44 ` Sven Van Asbroeck
2019-12-10 8:46 ` Lee Jones
2019-12-10 8:46 ` Lee Jones
2019-11-21 18:20 ` [PATCH v4 0/2] tps6105x add devicetree and leds support Jacek Anaszewski
2019-11-22 13:36 ` Sven Van Asbroeck
2019-11-22 21:04 ` Jacek Anaszewski [this message]
2019-11-27 13:15 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=957d06d2-90d6-6a19-87ab-9cce7d03543d@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).