[PATCH] leds: lgm: fix gpiolib dependency

[PATCH] leds: lgm: fix gpiolib dependency

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Without gpiolib, the driver fails to build:

    drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
            struct gpio_chip chip;
                             ^
    include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
    struct gpio_chip;
           ^
    drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
                    gpiod_set_value(led->gpiod, val);
                    ^
    drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
    include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
    static inline void gpio_set_value(unsigned gpio, int value)
                       ^
    drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
                    gpiod_set_value(led->gpiod, 1);
                    ^

Add the dependency in Kconfig.

Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/leds/blink/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 265b53476a80..6dedc58c47b3 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -9,6 +9,7 @@ if LEDS_BLINK
 
 config LEDS_BLINK_LGM
 	tristate "LED support for Intel LGM SoC series"
+	depends on GPIOLIB
 	depends on LEDS_CLASS
 	depends on MFD_SYSCON
 	depends on OF
-- 
2.29.2

Intel, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi!

> From: Arnd Bergmann <arnd@arndb.de>
> 
> Without gpiolib, the driver fails to build:
> 
>     drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
>             struct gpio_chip chip;
>                              ^

Thanks, applied.

I'd like people from Intel to contact me. There's more to fix there,
and AFAICT original author went away.

Best regards,
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: Intel, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

Hi!

> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Without gpiolib, the driver fails to build:
> > 
> >     drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
> >             struct gpio_chip chip;
> >                              ^
> 
> Thanks, applied.
> 
> I'd like people from Intel to contact me. There's more to fix there,
> and AFAICT original author went away.

The following message to <mallikarjunax.reddy@linux.intel.com> was
undeliverable.
The reason for the problem:
5.1.0 - Unknown address error 550-'5.1.1
<mallikarjunax.reddy@linux.intel.com>: Recipient
+address rejected: User unknown in virtual mailbox table'

commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>

Signed-off-by: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>

If someone knows how to contact the author, that would be welcome.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Adam Borowski]

On Tue, Mar 09, 2021 at 08:39:10PM +0100, Pavel Machek wrote:
> > I'd like people from Intel to contact me. There's more to fix there,
> > and AFAICT original author went away.
> 
> The following message to <mallikarjunax.reddy@linux.intel.com> was
> undeliverable.

> <mallikarjunax.reddy@linux.intel.com>: Recipient
> +address rejected: User unknown in virtual mailbox table'

> commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
> Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>

I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
together with the rest of the Connected Home Division.  So he most likely
still works on this stuff, just under a different banner.

> If someone knows how to contact the author, that would be welcome.

Alas, no idea about his MaxLinear address.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ in the beginning was the boot and root floppies and they were good.
⢿⡄⠘⠷⠚⠋⠀                                       -- <willmore> on #linux-sunxi
⠈⠳⣄⠀⠀⠀⠀

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]

Hi!

> > > I'd like people from Intel to contact me. There's more to fix there,
> > > and AFAICT original author went away.
> > 
> > The following message to <mallikarjunax.reddy@linux.intel.com> was
> > undeliverable.
> 
> > <mallikarjunax.reddy@linux.intel.com>: Recipient
> > +address rejected: User unknown in virtual mailbox table'
> 
> > commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
> > Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
> 
> I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
> together with the rest of the Connected Home Division.  So he most likely
> still works on this stuff, just under a different banner.
> 
> > If someone knows how to contact the author, that would be welcome.
> 
> Alas, no idea about his MaxLinear address.

Thanks for the effort. Anyway, I suspect I'll just do this:

BR,
								Pavel

diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 6dedc58c47b3..79493f21d365 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,14 +1,6 @@
-menuconfig LEDS_BLINK
-	bool "LED Blink support"
-	depends on LEDS_CLASS
-	help
-	  This option enables blink support for the leds class.
-	  If unsure, say Y.
-
-if LEDS_BLINK
-
 config LEDS_BLINK_LGM
 	tristate "LED support for Intel LGM SoC series"
+	depends on BROKEN
 	depends on GPIOLIB
 	depends on LEDS_CLASS
 	depends on MFD_SYSCON
@@ -17,5 +9,3 @@ config LEDS_BLINK_LGM
 	  Parallel to serial conversion, which is also called SSO controller,
 	  can drive external shift register for LED outputs.
 	  This enables LED support for Serial Shift Output controller(SSO).
-
-endif # LEDS_BLINK


-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Arnd Bergmann]

On Wed, Mar 10, 2021 at 8:30 AM Pavel Machek <pavel@ucw.cz> wrote:
>
> Hi!
>
> > > > I'd like people from Intel to contact me. There's more to fix there,
> > > > and AFAICT original author went away.
> > >
> > > The following message to <mallikarjunax.reddy@linux.intel.com> was
> > > undeliverable.
> >
> > > <mallikarjunax.reddy@linux.intel.com>: Recipient
> > > +address rejected: User unknown in virtual mailbox table'
> >
> > > commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
> > > Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
> >
> > I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
> > together with the rest of the Connected Home Division.  So he most likely
> > still works on this stuff, just under a different banner.
> >
> > > If someone knows how to contact the author, that would be welcome.
> >
> > Alas, no idea about his MaxLinear address.
>
> Thanks for the effort. Anyway, I suspect I'll just do this:

Maybe Hauke or John  (added both to cc) know who at MaxLinear is
responsible for maintaining the Lightning Mountain drivers now.

       Arnd

> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 6dedc58c47b3..79493f21d365 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,14 +1,6 @@
> -menuconfig LEDS_BLINK
> -       bool "LED Blink support"
> -       depends on LEDS_CLASS
> -       help
> -         This option enables blink support for the leds class.
> -         If unsure, say Y.
> -
> -if LEDS_BLINK
> -
>  config LEDS_BLINK_LGM
>         tristate "LED support for Intel LGM SoC series"
> +       depends on BROKEN
>         depends on GPIOLIB
>         depends on LEDS_CLASS
>         depends on MFD_SYSCON
> @@ -17,5 +9,3 @@ config LEDS_BLINK_LGM
>           Parallel to serial conversion, which is also called SSO controller,
>           can drive external shift register for LED outputs.
>           This enables LED support for Serial Shift Output controller(SSO).
> -
> -endif # LEDS_BLINK
>
>
> --
> http://www.livejournal.com/~pavelmachek

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Hauke Mehrtens]

On 3/10/21 5:57 PM, Arnd Bergmann wrote:
> On Wed, Mar 10, 2021 at 8:30 AM Pavel Machek <pavel@ucw.cz> wrote:
>>
>> Hi!
>>
>>>>> I'd like people from Intel to contact me. There's more to fix there,
>>>>> and AFAICT original author went away.
>>>>
>>>> The following message to <mallikarjunax.reddy@linux.intel.com> was
>>>> undeliverable.
>>>
>>>> <mallikarjunax.reddy@linux.intel.com>: Recipient
>>>> +address rejected: User unknown in virtual mailbox table'
>>>
>>>> commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
>>>> Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
>>>
>>> I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
>>> together with the rest of the Connected Home Division.  So he most likely
>>> still works on this stuff, just under a different banner.
>>>
>>>> If someone knows how to contact the author, that would be welcome.
>>>
>>> Alas, no idea about his MaxLinear address.
>>
>> Thanks for the effort. Anyway, I suspect I'll just do this:
> 
> Maybe Hauke or John  (added both to cc) know who at MaxLinear is
> responsible for maintaining the Lightning Mountain drivers now.
> 
>         Arnd

Hi Qiming,

It looks like there are some problems and potential fixes for the led 
driver Mallikarjuna added to the Linux kernel for LGM some time ago.

Could you please take care of this request from Pavel and Arnd.


Hauke


> 
>> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
>> index 6dedc58c47b3..79493f21d365 100644
>> --- a/drivers/leds/blink/Kconfig
>> +++ b/drivers/leds/blink/Kconfig
>> @@ -1,14 +1,6 @@
>> -menuconfig LEDS_BLINK
>> -       bool "LED Blink support"
>> -       depends on LEDS_CLASS
>> -       help
>> -         This option enables blink support for the leds class.
>> -         If unsure, say Y.
>> -
>> -if LEDS_BLINK
>> -
>>   config LEDS_BLINK_LGM
>>          tristate "LED support for Intel LGM SoC series"
>> +       depends on BROKEN
>>          depends on GPIOLIB
>>          depends on LEDS_CLASS
>>          depends on MFD_SYSCON
>> @@ -17,5 +9,3 @@ config LEDS_BLINK_LGM
>>            Parallel to serial conversion, which is also called SSO controller,
>>            can drive external shift register for LED outputs.
>>            This enables LED support for Serial Shift Output controller(SSO).
>> -
>> -endif # LEDS_BLINK
>>
>>
>> --
>> http://www.livejournal.com/~pavelmachek

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Arnd Bergmann]

On Thu, Mar 11, 2021 at 6:48 AM Rahul Tanwar <rtanwar@maxlinear.com> wrote:
> Hi Arnd, Pavel,
>
> Sorry for the hiccup due to missing email address in the email chain during the ownership transition.
>
> Henceforth, I will be the maintainer for all kernel drivers/code related to “formerly Intel’s now MaxLinear’s” Lightning Mountain SoC.
>
> Please send any Lightning Mountain SoC related issues email to Rahul Tanwar (rtanwar@maxlinear.com) and I will ensure that I address the issues in a timely manner.

Thank you for the reply and for stepping up as maintainer.

I tend to merge updates to the MAINTAINERS file as bugfixes the file contains
the correct addresses at all times. If you sent an update for this to
soc@kernel.org,
I'll get that merged.

Since I think this is an x86 platform, you can alternatively send the same patch
to the x86 maintainers.

Are you also planning to maintain or add drivers for some of the older SoC
generations from Ti/Lantiq/Infineon/Intel that are now owned by MaxLinear?
It would be good to be explicit about which ones of these you are working
with. From what I can tell, the arch/mips/lantiq/ platform is only for fairly
old designs (xrx200 and older), while support for the slightly later mips
and x86 based chips was submitted a few years ago but never merged.

> I will wait for more details on your fix request for LGM LED driver. Thanks.

From my side, only an Ack on the original bugfix I sent [1] is needed, but
Pavel had other concerns about the driver. I expect he will follow up on those
with you.

         Arnd

[1] https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Rahul Tanwar]

Hi Arnd,

On 11/3/2021 6:01 pm, Arnd Bergmann wrote:
> This email was sent from outside of MaxLinear.
> 
> On Thu, Mar 11, 2021 at 6:48 AM Rahul Tanwar <rtanwar@maxlinear.com> wrote:
>  > Hi Arnd, Pavel,
>  >
>  > Sorry for the hiccup due to missing email address in the email chain 
> during the ownership transition.
>  >
>  > Henceforth, I will be the maintainer for all kernel drivers/code 
> related to “formerly Intel’s now MaxLinear’s” Lightning Mountain SoC.
>  >
>  > Please send any Lightning Mountain SoC related issues email to Rahul 
> Tanwar (rtanwar@maxlinear.com) and I will ensure that I address the 
> issues in a timely manner.
> 
> Thank you for the reply and for stepping up as maintainer.
> 
> I tend to merge updates to the MAINTAINERS file as bugfixes the file 
> contains
> the correct addresses at all times. If you sent an update for this to
> soc@kernel.org,
> I'll get that merged.
> 
> Since I think this is an x86 platform, you can alternatively send the 
> same patch
> to the x86 maintainers.
>


Haven't sent any patch to update MAINTAINERS file yet. Thanks for your 
suggestion. I will take it up soon..


> Are you also planning to maintain or add drivers for some of the older SoC
> generations from Ti/Lantiq/Infineon/Intel that are now owned by MaxLinear?
> It would be good to be explicit about which ones of these you are working
> with. From what I can tell, the arch/mips/lantiq/ platform is only for 
> fairly
> old designs (xrx200 and older), while support for the slightly later mips
> and x86 based chips was submitted a few years ago but never merged.
> 

Thank you for asking. At this point of time, our focus for upstreaming 
and maintaining is on LGM(Lightning Mountain) SoC.

Regards,
Rahul

>  > I will wait for more details on your fix request for LGM LED driver. 
> Thanks.
> 
>  From my side, only an Ack on the original bugfix I sent [1] is needed, but
> Pavel had other concerns about the driver. I expect he will follow up on 
> those
> with you.
> 
> Arnd
> 
> [1] 
> https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/ 
> <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org>

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Hi!

> Sorry for the hiccup due to missing email address in the email chain during the ownership transition.
> 
> Henceforth, I will be the maintainer for all kernel drivers/code related to “formerly Intel’s now MaxLinear’s” Lightning Mountain SoC.
> 
> Please send any Lightning Mountain SoC related issues email to Rahul Tanwar (rtanwar@maxlinear.com<mailto:rtanwar@maxlinear.com>) and I will ensure that I
> address the issues in a timely manner.
> 
> I will wait for more details on your fix request for LGM LED
> driver. Thanks.

Please review/Ack arnd's change.

Plus I'd like you to

1) remove LEDS_BLINK Kconfig symbol

2) provide useful Kconfig help text for your driver.

Thank you,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]