linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Alexander Dahl <ada@thorsis.com>, linux-leds@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: syscon: Use resource managed variant of device register
Date: Tue, 27 Aug 2019 23:32:12 +0200	[thread overview]
Message-ID: <9d59f587-140b-9517-8b37-070817aea2ba@gmail.com> (raw)
In-Reply-To: <20190827130027.28998-1-ada@thorsis.com>

Hi Alexander,

Thank you for the patch.

On 8/27/19 3:00 PM, Alexander Dahl wrote:
> We have a MFD driver compiled as module instantiating this driver. When
> unloading that module, those LED devices are not removed, which produces
> conflicts, when that module is inserted again.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
>  drivers/leds/leds-syscon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
> index e35dff0050f0..b58f3cafe16f 100644
> --- a/drivers/leds/leds-syscon.c
> +++ b/drivers/leds/leds-syscon.c
> @@ -115,7 +115,7 @@ static int syscon_led_probe(struct platform_device *pdev)
>  	}
>  	sled->cdev.brightness_set = syscon_led_set;
>  
> -	ret = led_classdev_register(dev, &sled->cdev);
> +	ret = devm_led_classdev_register(dev, &sled->cdev);
>  	if (ret < 0)
>  		return ret;

Applied.

-- 
Best regards,
Jacek Anaszewski

      reply	other threads:[~2019-08-27 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 13:00 [PATCH] leds: syscon: Use resource managed variant of device register Alexander Dahl
2019-08-27 21:32 ` Jacek Anaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d59f587-140b-9517-8b37-070817aea2ba@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=ada@thorsis.com \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).