From: Akinobu Mita <akinobu.mita@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Bjorn Andersson <bjorn@kryo.se>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: Add leds-meter binding
Date: Fri, 1 Nov 2019 00:05:55 +0900 [thread overview]
Message-ID: <CAC5umyh0_2MN4=uin91sYVWNxvF1uwg_bEWME0XKurTiV08q0w@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqKa=936WNhTDQ0S9bW0fYPMHQXSwutjnQs0W9vP8h7sow@mail.gmail.com>
2019年10月31日(木) 3:29 Rob Herring <robh@kernel.org>:
>
> On Wed, Oct 30, 2019 at 10:27 AM Akinobu Mita <akinobu.mita@gmail.com> wrote:
> >
> > 2019年10月30日(水) 23:24 Rob Herring <robh@kernel.org>:
> > >
> > > On Sun, Oct 27, 2019 at 11:09:38PM +0900, Akinobu Mita wrote:
> > > > Add DT binding for generic LED level meter which consists of multiple LED
> > > > devices by different drivers.
> > >
> > > Do you have some pointers to actual h/w?
> >
> > This doesn't require a specific hardware.
>
> But I do for my understanding. If I don't understand it, then my
> default answer is: no, we don't do "generic" bindings because the h/w
> is never generic.
For example, https://www.switch-science.com/catalog/2677/
The LEDs on this board are controlled by NXP PCA9956B.
The driver is under development by Bjorn Andersson.
But the LED level meter doesn't depend on the actual LED controller driver,
so I call it "generic" LED level meter driver.
> > If there are more than two LEDs that can be described by devicetree,
> > it can be an LED level meter by bundling them up with this binding.
>
> Depends on the physical locations too? If you just want to group any
> random LEDs, then do that from userspace because it's more flexible.
Yes. I assume that the level meter's LEDs are mounted in a line, or matrix.
I plan to rename it to 'leds-array' because 'leds-meter' is unclear.
next prev parent reply other threads:[~2019-10-31 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 14:09 [PATCH v2 0/2] leds: introduce generic LED level meter driver Akinobu Mita
2019-10-27 14:09 ` [PATCH v2 1/2] dt-bindings: leds: Add leds-meter binding Akinobu Mita
2019-10-29 12:05 ` Dan Murphy
2019-10-30 15:08 ` Akinobu Mita
2019-10-30 14:24 ` Rob Herring
2019-10-30 15:27 ` Akinobu Mita
2019-10-30 18:29 ` Rob Herring
2019-10-31 15:05 ` Akinobu Mita [this message]
2019-10-27 14:09 ` [PATCH v2 2/2] leds: Add generic LED level meter driver Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umyh0_2MN4=uin91sYVWNxvF1uwg_bEWME0XKurTiV08q0w@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=bjorn@kryo.se \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).