From: Linus Walleij <linus.walleij@linaro.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
newbytee@protonmail.com, Stephan Gerhold <stephan@gerhold.net>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515
Date: Wed, 19 Aug 2020 23:05:47 +0200 [thread overview]
Message-ID: <CACRpkdYcKthp9_482ptL7YSitN-YUU4_u57ra25Ko4_-102JaQ@mail.gmail.com> (raw)
In-Reply-To: <e8d27b57-ac17-29e4-0e43-b72d7447d43a@gmail.com>
On Thu, Aug 13, 2020 at 11:06 PM Jacek Anaszewski
<jacek.anaszewski@gmail.com> wrote:
> > + led:
> > + type: object
> > + $ref: common.yaml#
(...)
> > + led {
> > + function = LED_FUNCTION_FLASH;
> > + color = <LED_COLOR_ID_WHITE>;
> > + flash-max-timeout-us = <250000>;
>
> Constraints for this property are needed above.
Can you elaborate on what you expect this to look like?
The property is from common.yaml, so should that be
extended with a constraint?
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-08-19 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 9:07 [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515 Linus Walleij
2020-08-12 9:07 ` [PATCH 2/2] leds: rt8515: Add Richtek RT8515 LED driver Linus Walleij
2020-08-13 21:04 ` Jacek Anaszewski
2020-10-14 10:52 ` Linus Walleij
2020-10-15 20:39 ` Jacek Anaszewski
2020-08-13 21:06 ` [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515 Jacek Anaszewski
2020-08-19 21:05 ` Linus Walleij [this message]
2020-08-19 21:20 ` Jacek Anaszewski
2020-09-09 8:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYcKthp9_482ptL7YSitN-YUU4_u57ra25Ko4_-102JaQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=newbytee@protonmail.com \
--cc=pavel@ucw.cz \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).