From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB681C4743D for ; Fri, 4 Jun 2021 22:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D518D61407 for ; Fri, 4 Jun 2021 22:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbhFDWMO (ORCPT ); Fri, 4 Jun 2021 18:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhFDWMN (ORCPT ); Fri, 4 Jun 2021 18:12:13 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E73AC061767 for ; Fri, 4 Jun 2021 15:10:16 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id p17so15455706lfc.6 for ; Fri, 04 Jun 2021 15:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YMx9d/KwaGXDIgZMt2DPtgDzNG9hC9FHDEasqs2eylw=; b=RnWNqREAbgLaek095trmxYAB2A32y6JnXwwCOEqCb69fAeTbDadtF8FlgfjScSVIAl VeeTs+PRgOCjPxTkkncXbvDpFdnykroIPzWS3ZkrcA5V09EUCUjR2N8eDmWGi1aSTldj sWGtkpZHNt+L8zQ1rec0frnXufrW6BYnmCPrTRRO9+m7pZcPtC+Qyxnn28G7ujhDYXAE byQy4rVnCqQe1KCfjRh86UTCzrbOPPbCEQHJjzcVwYU80D4Pmn7eHSaFdFucq0thDew9 mwIt+3FVhKJjw3+1RBYgxxjHifqmUr8neCsMcwOWZH12A84wexGKmonNSgDqwYVy2GKf ERww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YMx9d/KwaGXDIgZMt2DPtgDzNG9hC9FHDEasqs2eylw=; b=cwYgWoegccQXGkGJmnurTNjryMuZghcX/Pn/jXvYOrs+NpeYvilAQhVoGI/2a3oqwx fNTM89UEVUOYxu5DlVAwLuRZ+/20JpjXUPbp4DRYwznEGxEwNoWnTmYrzTjsP8ux1xDK MxSrxyp4YMN35jiO8rsOdZ/OaQ+/tQZu5a9nW/oBG/+3s5gVutTbnnLNEpm1MR9gz7mx toZ4rx3qjS5/2NVDaOcYQJFcPFDXspSvId1Up/9mtKsH3R6uEpkExe+nQvjV04DmWUy4 rwWDsjf4r16UAs0uqVQsCr2RfeZj51R6yDr6VaIbBn9FnpsIp7QSEqzYBBHKhfiXeeCT fYVQ== X-Gm-Message-State: AOAM532xO2STSNwI+UwcvcARIknCPAeBO4zJz10PGoEiioZYUBTBY4rn /sTKCmDw+LDrOfE/vWDnDYXVTLNhZGbuwLaiQKjBXg== X-Google-Smtp-Source: ABdhPJx69CXrOaH6IjDUNE/NOqbho2qNWe/t0l5SmoR6GFbzHw8h1llh1Vq5RtbcLkcaqfSzMyNyoSf5YZK3GJZYikI= X-Received: by 2002:ac2:544f:: with SMTP id d15mr4065245lfn.465.1622844614933; Fri, 04 Jun 2021 15:10:14 -0700 (PDT) MIME-Version: 1.0 References: <5d184778a6562e24abfa6e5dd2f7dbde4fede3fe.1622713678.git.sander@svanheule.net> In-Reply-To: <5d184778a6562e24abfa6e5dd2f7dbde4fede3fe.1622713678.git.sander@svanheule.net> From: Linus Walleij Date: Sat, 5 Jun 2021 00:10:03 +0200 Message-ID: Subject: Re: [PATCH v4 4/5] pinctrl: Add RTL8231 pin control and GPIO support To: Sander Vanheule Cc: Pavel Machek , Rob Herring , Lee Jones , Michael Walle , Andy Shevchenko , Linux LED Subsystem , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Hans de Goede , Andrew Lunn , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, Jun 3, 2021 at 12:01 PM Sander Vanheule wrote: > This driver implements the GPIO and pin muxing features provided by the > RTL8231. The device should be instantiated as an MFD child, where the > parent device has already configured the regmap used for register > access. > > Debouncing is only available for the six highest GPIOs, and must be > emulated when other pins are used for (button) inputs. Although > described in the bindings, drive strength selection is currently not > implemented. > > Signed-off-by: Sander Vanheule Wow this looks really good. Thanks for going the extra mile and fix this. Special thanks to Andy for the thorough review. Reviewed-by: Linus Walleij Yours, Linus Walleij