From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76E6C47E49 for ; Sun, 3 Nov 2019 22:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BF032190F for ; Sun, 3 Nov 2019 22:27:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TuHGE1F1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728059AbfKCW1Q (ORCPT ); Sun, 3 Nov 2019 17:27:16 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:33466 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727705AbfKCW1P (ORCPT ); Sun, 3 Nov 2019 17:27:15 -0500 Received: by mail-lf1-f65.google.com with SMTP id y127so10795327lfc.0 for ; Sun, 03 Nov 2019 14:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IzPJeK2cpUMQjH/975cPTUdiwrvG/dQ6KV42xRB7wAA=; b=TuHGE1F1+ZfQMWfZYOEceMUBeLUnTeKK5wwL276Sz2hY+xKk8yxeRPuxVCLI4K8K1b xc/+Bs3KENTr75oENU5Oij2awZZ1CEWkkAhr9YxWRcPvSoAZ0jwnjIPdTOs9KHH+bkjA gFA/bMn9usVK1w4Rsab/nFcqIguaiTrbPF90x6B7U0CPqlgL7IVMYuqCg0LkJ7UmqPtp nbt7syLDUloMjZ2JaJ7lBtj1V/QwAg3ng3c13tJGYyVP8U5en7JxXggkdqBp6at+kXvj ITQxqRfoZDCgVCzD0WsGKF7ftP+d2VB9+BO8PhPn6vdBZfC19rjv4tRamOHUEGXgKOd+ 5IUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IzPJeK2cpUMQjH/975cPTUdiwrvG/dQ6KV42xRB7wAA=; b=SZOwcqHl52DQO5CmRGwG1XFtXkHRQykgHE6pMYU13athkkS1g0pRRxrE5Z130YylPo yA/zdbGq9VRbktw/leTzfYHEvCHA7CqNgnMHDWY4px7U4UL/LbSONgv6HEzxPRrNjLQV Es9Tk25Wj6zL4oepBGASwpnkx+iMI0KECFZBZCsW/fhpoeRAzK1lh26Em7hcc98h98hZ BLKj4fGgUq2u3B0xafIsgTnMdnj3yVkceKBFzJEH/Wi1l2KiXAKm2TIDngKiaUy9N6jn hLKlBmnqGr+xA60kUsL7nhVGddu8WP7z0ArXNBHbhHQXIVnJmQT4uO5m06TDLznp8b/c rTEg== X-Gm-Message-State: APjAAAVV3WXfxCGbTZWcri4pJCL7lqoVipDNp7C6DoVlfItxU4Vva2xC CqXnjZhchmSAGYzMWv1iU9O6taOwN0U5+NOS7DDqpA== X-Google-Smtp-Source: APXvYqyjdYFNN9CDPrBMD1LL8+RPj9zGpSDVydNpsun9Cd81xB4a7KEsrKrdBFbr3NcThDQn/dcVLwc/glAw4mUAc7w= X-Received: by 2002:a19:6a0d:: with SMTP id u13mr5835609lfu.86.1572820033814; Sun, 03 Nov 2019 14:27:13 -0800 (PST) MIME-Version: 1.0 References: <2a8fa03308b08b2a15019d9b457d9bff7aafce94.1572606437.git.matti.vaittinen@fi.rohmeurope.com> In-Reply-To: <2a8fa03308b08b2a15019d9b457d9bff7aafce94.1572606437.git.matti.vaittinen@fi.rohmeurope.com> From: Linus Walleij Date: Sun, 3 Nov 2019 23:27:02 +0100 Message-ID: Subject: Re: [RFC PATCH v3 10/15] regulator: bd71828: Add GPIO based run-level control for regulators To: Matti Vaittinen Cc: Matti Vaittinen , Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Mark Rutland , Lee Jones , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , Linux LED Subsystem , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-clk , "open list:GPIO SUBSYSTEM" , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Nov 1, 2019 at 12:43 PM Matti Vaittinen wrote: > Bucks 1,2,6 and 7 on ROHM BD71828 can be either controlled as > individual regulartors - or they can be grouped to a group of > regulators that are controlled by 'run levels'. This can be > done via I2C. Each regulator can be assigned a voltage and > enable/disable status for each run-level. These statuses are > also changeable via I2C. > > Run-levels can then be changed either by I2C or GPIO. This > control mechanism is selected by data in one time programmable > area (during production) and can't be changed later. > > Allow regulators to be controlled via run-levels and allow > getting/setting the current run-level also via GPIO. > > Signed-off-by: Matti Vaittinen I like the way you use the gpio API so FWIW: Reviewed-by: Linus Walleij I do not understand the regulator parts of the patch. Yours, Linus Walleij