From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D5EC43603 for ; Wed, 4 Dec 2019 23:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 695B5206DB for ; Wed, 4 Dec 2019 23:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uQsVwqfR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728060AbfLDXqG (ORCPT ); Wed, 4 Dec 2019 18:46:06 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:44205 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbfLDXqF (ORCPT ); Wed, 4 Dec 2019 18:46:05 -0500 Received: by mail-lf1-f65.google.com with SMTP id v201so931420lfa.11 for ; Wed, 04 Dec 2019 15:46:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1oLuXTqP88AIJllnfUv70RaPKExVa3V8VYnwKFzXr90=; b=uQsVwqfRLCAJ44cXxreDwyi2t/pF9+6ktyX482qqhirs8nOUetXz3CJa6gX0d+StLI 4hrMtR2KUPZJw5V9yHYkuSxlHVrR0NcTxV66wok3kLyVEuiOdQ+87ZkDHjo1SaVe3qUt ExxMY9tZrB37RkXAXo4+S8vuXV0/TIiZ+XYFCBFZcfDXc3VafGj58nQzO9kGCJoKepaQ 45rWBnslFVJvwRITTvab0lm9wGC+o0gvis1jyeSwupr14EAS+0r5nhMkr0FKXIXS8wql EzUis/tSIFpQC3T4HIAyyWycETuiTV5ec3iLux8doePS9L+H9xv35IDJsOa4ul4uNfwO BGxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1oLuXTqP88AIJllnfUv70RaPKExVa3V8VYnwKFzXr90=; b=LNKEtCPxIJ8a0SJ3NaSFI35/nOFX7aRnLYQaMqBqGoENDhgm+7C1W+vKWpfIAkD0kq sV5FI1EfLgBP3rt5KUfQ6btBe4Qq/M1dryLBc5X4Ejcypelr/7frHkDwT9blniV5IcG1 8gfOTGavJ60jAFHKpBjwwDOZooXu21pYh8zZBsduRCwLtbUwNlLgyzXAC3jf8OTd0/1f BIUcsHYp65hW+djBaG9w1FTI1R4m7uljRth2XdvQu0JBbJmImr01pf+I2HDDv/yxtsJe IRTlOJjzCsMKmeE+xAWc+xYELzhclmk3vX86FRNsZYiD7h+wrBv8KFRmHgCMEbR8rkDS X0jQ== X-Gm-Message-State: APjAAAULaUmFiCUUL5H0lASCeq3weVmYXMhPalnn9OedTIbnwz1Mznxn LaAjp1TVy2GUK4Z2o+3gOwVMjv6SbQ91LM7o5hjBUg== X-Google-Smtp-Source: APXvYqyqVwBh7QLOCMY5WcVcMFSXciWG0BZOqFwPI5/16XD9DuCX7jpZucNx06M4rxkCfx9c/Kf2nRnArTuT/U4S8QM= X-Received: by 2002:ac2:5b86:: with SMTP id o6mr3552742lfn.44.1575503163840; Wed, 04 Dec 2019 15:46:03 -0800 (PST) MIME-Version: 1.0 References: <20191204110219.GV25745@shell.armlinux.org.uk> In-Reply-To: From: Linus Walleij Date: Thu, 5 Dec 2019 00:45:51 +0100 Message-ID: Subject: Re: "leds: gpio: Use generic support for composing LED names" breaks gpio debugfs To: Jacek Anaszewski Cc: Russell King - ARM Linux admin , Pavel Machek , Linux ARM , Linux LED Subsystem , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, Dec 4, 2019 at 9:52 PM Jacek Anaszewski wrote: > It seem that the only proper solution would be introducing a new > pre_register_cdev(const char *name) op to the LED core, that would allow > drivers to come up with their implementation thereof. In this particular > case leds-gpio driver would need to put there gpiod initialization. I don't know the particulars but if it helps you can at any point call: int gpiod_set_consumer_name(struct gpio_desc *desc, const char *name); For any successfully obtained descriptor, to set the consumer name, i.e. the text appearing in debugfs and the GPIO character device. Yours, Linus Walleij