From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E03CA9EA0 for ; Fri, 25 Oct 2019 19:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29ABC20679 for ; Fri, 25 Oct 2019 19:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="b4EDArzn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfJYTSg (ORCPT ); Fri, 25 Oct 2019 15:18:36 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:41877 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbfJYTSf (ORCPT ); Fri, 25 Oct 2019 15:18:35 -0400 Received: by mail-oi1-f194.google.com with SMTP id g81so2321786oib.8 for ; Fri, 25 Oct 2019 12:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=caqZS73ujV6Zdyymag8M26Wcqn5G2+KweE+j+HquELA=; b=b4EDArznp02keGtvfHllt+4DNwPB/wY2U4iXZgPoBpUBy8JsPeH4Qmg4aCBwc6NoZI ROfGAR3pXNQolhTlvEZNPiHhNH2bsdtOAfFz3jSVdFsDyUAJnt1KcP//X/ufZs+uHGQR mUz7uQkpYvQ7dgGjREk0laFRoO9N3Z+3on59o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=caqZS73ujV6Zdyymag8M26Wcqn5G2+KweE+j+HquELA=; b=bmDE1dMoS4LU/6Vb+lMcQkWCnJYiEuIzGs+KcOkd8AsP65PAnt47cqgk4vBc8qk4t3 DCVv7Fyd4mvseFDG/ezJkd0M3QkBS8pzCKzirymMupw5m7mhb3+dXDebMT0GDGxDDdjM 8FMcNp760lcnGlLCvtcQa7hQ3LVD8GDzvbyI3kq4iAZEY4p1lN4yecUyJzeG+gPIx8he QOSpZPEavvZXR+BboMuK+zRXB/f/EDjAWSaM13yNgwew5N2C2Ig9Qw4cn5qe8yHlvk9u s/r9Af7TOc081Q0HYwYMBzd9NGYgH7TZD/kzawwMr+dH7d8V9BXyGOIKI6isxYmkFXhO 8guA== X-Gm-Message-State: APjAAAV9ZE3jrQv2kimG9tlVRMsW/nNM8MBJsFln3CezK2jrGRViUos2 dWrxZRBEPzaTZ/1OSr/nen4OkTWhh9A= X-Google-Smtp-Source: APXvYqzrCJMIRgUJOEzVKGe57CC+r/+1qKFXRo1sFCQJdQgjBe4ZXyN31bgy7CBUaFQCcUe3ctkKlQ== X-Received: by 2002:aca:5015:: with SMTP id e21mr4552761oib.174.1572031112907; Fri, 25 Oct 2019 12:18:32 -0700 (PDT) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com. [209.85.210.43]) by smtp.gmail.com with ESMTPSA id z14sm790954oic.13.2019.10.25.12.18.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2019 12:18:31 -0700 (PDT) Received: by mail-ot1-f43.google.com with SMTP id 41so2766412oti.12 for ; Fri, 25 Oct 2019 12:18:31 -0700 (PDT) X-Received: by 2002:a05:6830:1147:: with SMTP id x7mr330026otq.349.1572031110654; Fri, 25 Oct 2019 12:18:30 -0700 (PDT) MIME-Version: 1.0 References: <20191024222805.183642-1-ncrews@chromium.org> <20191025173319.GA1768@chromium.org> In-Reply-To: <20191025173319.GA1768@chromium.org> From: Nick Crews Date: Fri, 25 Oct 2019 13:18:18 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support To: Daniel Campello Cc: Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Pavel Machek , linux-kernel , Arnd Bergmann , Wei Yongjun , Duncan Laurie , Daniel Kurtz , Dmitry Torokhov , Simon Glass , groeck@chromium.com Content-Type: text/plain; charset="UTF-8" Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Oct 25, 2019 at 11:33 AM Daniel Campello wrote: > > LGTM. > Reviewed-by: Daniel Campello