From: Daniel Campello <campello@google.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Nick Crews <ncrews@chromium.org>,
bleung@chromium.org, linux-leds@vger.kernel.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz,
linux-kernel@vger.kernel.org, arnd@arndb.de,
weiyongjun1@huawei.com, dlaurie@chromium.org,
djkurtz@chromium.org, dtor@google.com, sjg@chromium.org,
groeck@chromium.com
Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support
Date: Wed, 6 Nov 2019 09:39:18 -0700 [thread overview]
Message-ID: <CAHcu+VYJGUARhN8_LcdH=rMzgZN1aGnBcjMx=onftmkR-1PMXw@mail.gmail.com> (raw)
In-Reply-To: <CAHcu+VYdMxoFbcxYxB1FnDSdsM=w9UsVKjF0S48LZGG0ZxKUDA@mail.gmail.com>
HI again,
On Wed, Nov 6, 2019 at 9:34 AM Daniel Campello <campello@google.com> wrote:
>
> Hi Enric,
>
> On Wed, Nov 6, 2019 at 8:15 AM Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
>>
>> Hi Daniel,
>>
>> On 25/10/19 0:28, Nick Crews wrote:
>> > The EC is in charge of controlling the keyboard backlight on
>> > the Wilco platform. We expose a standard LED class device
>> > named platform::kbd_backlight.
>> >
>> > Since the EC will never change the backlight level of its own accord,
>> > we don't need to implement a brightness_get() method.
>> >
>> > Signed-off-by: Nick Crews <ncrews@chromium.org>
>> > Signed-off-by: Daniel Campello <campello@chromium.org>
>>
>> As you know 0day reported an issue that needs to be solved, waiting for a new
>> version.
>>
>> Thanks,
>> Enric
>
>
> I just sent a v9 of the patch with the issue addressed.
>
> Thanks,
> Daniel
Resending in plain text format... Sorry about that...
Daniel
prev parent reply other threads:[~2019-11-06 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 22:28 [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support Nick Crews
2019-10-24 22:28 ` [PATCH v8 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-11-06 15:16 ` Enric Balletbo i Serra
2019-10-25 17:33 ` [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support Daniel Campello
2019-10-25 19:18 ` Nick Crews
2019-11-06 15:15 ` Enric Balletbo i Serra
[not found] ` <CAHcu+VYdMxoFbcxYxB1FnDSdsM=w9UsVKjF0S48LZGG0ZxKUDA@mail.gmail.com>
2019-11-06 16:39 ` Daniel Campello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHcu+VYJGUARhN8_LcdH=rMzgZN1aGnBcjMx=onftmkR-1PMXw@mail.gmail.com' \
--to=campello@google.com \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=pavel@ucw.cz \
--cc=sjg@chromium.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).