From: Andy Shevchenko <andy.shevchenko@gmail.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Sascha Hauer <kernel@pengutronix.de>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Pavel Machek <pavel@ucw.cz>, Jiri Slaby <jslaby@suse.com>, Linux LED Subsystem <linux-leds@vger.kernel.org>, Dan Murphy <dmurphy@ti.com> Subject: Re: [PATCH v6 1/4] lib: new helper kstrtodev_t() Date: Thu, 20 Feb 2020 13:57:00 +0200 Message-ID: <CAHp75VcC2adjcPUiWaZhXZgocWDPoUJZwGMYNfJWSqyqDAY1Dg@mail.gmail.com> (raw) In-Reply-To: <CAHp75Vd3KN81qxOWJQ7v=GimSLtVymur_iPsf91pka1STc1nfA@mail.gmail.com> On Thu, Feb 20, 2020 at 1:46 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Feb 20, 2020 at 12:57 PM Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > On Thu, Feb 20, 2020 at 12:22:36PM +0200, Andy Shevchenko wrote: ... > > Also I don't understand yet, what you want me to do. > > I have issues with kstrto() not playing with simple numbers (boolean s/simple/simple and single/ > is a special case, but still a number at the end). > I also don't feel good with too narrow usage of the newly introduced helper > > > Assume I'd be > > willing to use simple_strtoul, I'd still want to have a function that > > gives me a dev_t from a given string. Should I put this directly in my > > led-trigger driver? > > I see the following possibilities: (above doesn't imply the necessity of simple_strto*() use) > a) put it inside the caller and forget about generic helper > b) do a generic helper, but 1/ in string_*() namespace, 2/ with a > delimiter parameter and 3/ possibility to take negative numbers > > In b) case, add to the commit message how many potential _existing_ > users may be converted to this. > Also it would be good to have two versions strict (only \n at the end > is allowed) and non-strict (based on the amount of users for each > group). And don't forget to extend lib/test_string.c accordingly. -- With Best Regards, Andy Shevchenko
next prev parent reply index Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-13 9:15 [PATCH v6 0/4] leds: trigger: implement a tty trigger Uwe Kleine-König 2020-02-13 9:15 ` [PATCH v6 1/4] lib: new helper kstrtodev_t() Uwe Kleine-König 2020-02-19 19:50 ` Andy Shevchenko 2020-02-20 7:49 ` Uwe Kleine-König 2020-02-20 10:22 ` Andy Shevchenko 2020-02-20 10:57 ` Uwe Kleine-König 2020-02-20 11:46 ` Andy Shevchenko 2020-02-20 11:57 ` Andy Shevchenko [this message] 2020-02-20 14:01 ` Uwe Kleine-König 2020-02-21 8:42 ` Andy Shevchenko 2020-02-21 10:53 ` Uwe Kleine-König 2020-04-25 7:07 ` Pavel Machek 2020-02-13 9:15 ` [PATCH v6 2/4] tty: rename tty_kopen() and add new function tty_kopen_shared() Uwe Kleine-König 2020-02-19 13:21 ` Johan Hovold 2020-02-19 16:37 ` Uwe Kleine-König 2020-02-19 17:17 ` Johan Hovold 2020-02-20 11:04 ` Uwe Kleine-König 2020-02-25 8:55 ` Johan Hovold 2020-02-25 9:05 ` Uwe Kleine-König 2020-02-13 9:15 ` [PATCH v6 3/4] tty: new helper function tty_get_icount() Uwe Kleine-König 2020-02-13 9:16 ` [PATCH v6 4/4] leds: trigger: implement a tty trigger Uwe Kleine-König 2020-02-19 10:52 ` Johan Hovold 2020-02-19 11:03 ` Uwe Kleine-König 2020-02-19 11:19 ` Johan Hovold 2020-02-19 12:48 ` Johan Hovold 2020-02-19 10:40 ` [PATCH v6 0/4] " Greg Kroah-Hartman 2020-02-26 14:02 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75VcC2adjcPUiWaZhXZgocWDPoUJZwGMYNfJWSqyqDAY1Dg@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=dmurphy@ti.com \ --cc=gregkh@linuxfoundation.org \ --cc=jacek.anaszewski@gmail.com \ --cc=jslaby@suse.com \ --cc=kernel@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-LEDs Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \ linux-leds@vger.kernel.org public-inbox-index linux-leds Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds AGPL code for this site: git clone https://public-inbox.org/public-inbox.git