From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD5EC433DF for ; Thu, 9 Jul 2020 20:51:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CDB920672 for ; Thu, 9 Jul 2020 20:51:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLAM8adN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbgGIUvR (ORCPT ); Thu, 9 Jul 2020 16:51:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgGIUvQ (ORCPT ); Thu, 9 Jul 2020 16:51:16 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B7DAC08C5CE; Thu, 9 Jul 2020 13:51:16 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id m16so108191pls.5; Thu, 09 Jul 2020 13:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6aAUMrDgu/dRMO1PKFcJzl15krQUj9/NrmpmX2igbSU=; b=QLAM8adNoWwlxAY3sKExkNjz7ranKdOekEgyi9t/Sjm1NULpynsg98SCvqGKj++2my IK6ockcKb2udy/ZF5A5MSGWuMXga8YnRQfwMlegNJLeMokYho+ff0W/PU+kagdruvlXN 9gkP+eAM5WjaKP96HoniGYjaNKLpDPvFyQT2H1OFmpiP/4SzVsYo3F9vJoOESX7nhgHg z1uJVBFWOPaPNtXVby+4aZ67Ytn5WneI4d5WL6X2FVAZoECT+cfFbRB0DPMAY+V7JMGo ohQCrGq+5zpYfdb5EivFa/KEV6oa4C/xLRl7xx7z5q04HZE18PRyhet427kCuxzbd+PE IBKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6aAUMrDgu/dRMO1PKFcJzl15krQUj9/NrmpmX2igbSU=; b=ZWHl+OHnnrviZisTXNCcx1BccUg1ffmY1YZn4XV3+zxDoBiLm/fAsmexMITtX9j09+ e5Xr2IE+07KArNUGlee6XKDVOC/rQw6jocho1zo5SiEhmBkZ/qicrpox/T6Uaa/2q2vd pf/aTaLRUvxoT9yCufCjVpDcdTecaoieP+EMf9I/gyXXZ/m+culCsHrACAMweTv71QLS PkkqYa05RREOCNXdrdvAO8WSlI2A6JoPvViU5EpP1+SMMTRqXNRvx4TdA3fFn2EeT56c p4vP5p4SKEc37YvuP0TLDcYRiL90ktO+VRnv2ueP59IP/5CHhdSZRk0GGMbrQkTIHpp9 bBOQ== X-Gm-Message-State: AOAM530UOZHZrlWBV+DG7rCMbvBRB73HsUvRRXf/ZXwa8wqAwnXWyP4E 4sJPtgNzWDhnP7Yxh+Hiqwm0ZCTbHuyUZH4Gpxe5gidE X-Google-Smtp-Source: ABdhPJxsjKxantzTRftMX6bNh0Ka3ytqBm/pi7VsMJfjHY2qg0YOKAp3gqWXkrp8PGXSVI7piz191sxizMiURXgpxig= X-Received: by 2002:a17:902:8491:: with SMTP id c17mr47735913plo.262.1594327876126; Thu, 09 Jul 2020 13:51:16 -0700 (PDT) MIME-Version: 1.0 References: <20200709201220.13736-1-eajames@linux.ibm.com> <20200709201220.13736-3-eajames@linux.ibm.com> In-Reply-To: <20200709201220.13736-3-eajames@linux.ibm.com> From: Andy Shevchenko Date: Thu, 9 Jul 2020 23:50:59 +0300 Message-ID: Subject: Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip To: Eddie James Cc: Linux LED Subsystem , Linux Kernel Mailing List , devicetree , Rob Herring , Dan Murphy , Pavel Machek , Jacek Anaszewski , vishwa@linux.ibm.com Content-Type: text/plain; charset="UTF-8" Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, Jul 9, 2020 at 11:16 PM Eddie James wrote: > > IBM created an implementation of the PCA9552 on a PIC16F > microcontroller. The I2C device addresses are different from the > hardware PCA9552, so add a new compatible string and associated > platform data to be able to probe this device. This is weird. I would rather expect ibm prefix with corresponding part number. > + pca9552_ibm, > + [pca9552_ibm] = { > + { "pca9552-ibm", pca9552_ibm }, > + { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm }, -- With Best Regards, Andy Shevchenko