From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFFBC4708F for ; Sat, 29 May 2021 10:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04A9D613D1 for ; Sat, 29 May 2021 10:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbhE2KsE (ORCPT ); Sat, 29 May 2021 06:48:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhE2KsB (ORCPT ); Sat, 29 May 2021 06:48:01 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07714C061760; Sat, 29 May 2021 03:46:25 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id e22so4468482pgv.10; Sat, 29 May 2021 03:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nh9/ZWlSwITR3jAdaVe3Wq51dfqcTRkUElzVjibwV70=; b=m3gqS9dIdGo598z7IbKAAaBFFe4NZxYR3WdUH20/bmDBVoSzaNLfBJQDzZ4ro93lvn IoXxfFusWGS1NNEncKLC3jhCWThdNq4r8rrmXhJlyz9vWHttxe2B66KYfqcP/ghIUnsp vsca6NJghBXhj/d8P+JvOZLZUEqNg/1mJm4QFewvNqDRPtn1TWOF2Kg9HEn346Jgyf2m MlpOaiht2g/T5vqzHRVeVh8Ocn1/XGnpEB1fTCFfOkwkOPcxS4PDSuGwrlnwAcK5Lcg2 n6eogCcETWy4mmHUo+E3FWewjq8x9uH+LpfSAzA5EgoUObsRHv2XYGJInzHt1QtfOCsu BF1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nh9/ZWlSwITR3jAdaVe3Wq51dfqcTRkUElzVjibwV70=; b=IzZ0xDuYdIKDxqhn8C2lLI58olzfjAF6U3UOT2dP1lkCDSIGhbIcLBqcKCXlNR4984 Imu2fdWDan6HpyE5k47j3GXhzfJjtFvUvh+uWSKVbH0I94UEtp08zPKVEpnBl5g2QYFb Rw/dluAMvNNdkJklNv9QUzvhhtGUdSeCkCv8AjAtSPKRmmZrIsH56H2EevG2brkmCCxn 3yyYTyRzR7+G1Ae/AgfgidiJXwHQi81EBBQVa5s9VxkF0gaR2eZV/yjw7DThhNqqe+og rN0J+qaOPHcLayVqcxBJEu0im8yDeEXf15c/9HN6vOCf36PMwt8jTRyvBDXFaa9ciDWP 8Y4g== X-Gm-Message-State: AOAM530qEGjqpg0r4Xj0Cb50CJYx9+bmdK5FOdFKqPBMzmZDqDz9ZrDr qaYykjBNy+mmZt3ZCg0IVxn6zwZzXKSjHGWlQfI= X-Google-Smtp-Source: ABdhPJzViolrkMg1tSCI79b8cwCkd2GY/ICw2C73TqHBl4RzJmMULM9dcxtGnAaQ29yQlnXY919eXVOQmHtmYgvvAMY= X-Received: by 2002:a05:6a00:1591:b029:2d9:369a:b846 with SMTP id u17-20020a056a001591b02902d9369ab846mr8269573pfk.40.1622285184511; Sat, 29 May 2021 03:46:24 -0700 (PDT) MIME-Version: 1.0 References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> <20210510095045.3299382-9-andy.shevchenko@gmail.com> <20210528100800.GF2209@amd> In-Reply-To: From: Andy Shevchenko Date: Sat, 29 May 2021 13:46:08 +0300 Message-ID: Subject: Re: [PATCH v1 08/28] leds: lgm-sso: Put fwnode in any case during ->probe() To: Pavel Machek Cc: Andy Shevchenko , Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sat, May 29, 2021 at 12:28 PM Andy Shevchenko wrote: > On Fri, May 28, 2021 at 1:08 PM Pavel Machek wrote: > > > @@ -734,10 +736,15 @@ static int sso_led_dt_parse(struct sso_led_priv *priv) > > > if (fw_ssoled) { > > > ret = __sso_led_dt_parse(priv, fw_ssoled); > > > if (ret) > > > - return ret; > > > + goto err_child_out; > > > } > > > > > > + fwnode_handle_put(fw_ssoled); > > > return 0; > > > + > > > +err_child_out: > > > + fwnode_handle_put(fw_ssoled); > > > + return ret; > > > } > > > > Just delete the return and you get the same effect, no? No need to > > have two exits here. > > Okay, I have tried and neither result is better: > option 1. Add ret = 0, but keep the label > option 2. Assign 0 to ret at the definition stage and replace return > with break and remove return 0 (I don't like that ret assigned to 0 in > the definition block. It usually may lead to subtle errors) > option 3+. Something I missed which you see can be done? > > Which one do you prefer? I found option 3 which is better and follows your suggestion (I suppose). -- With Best Regards, Andy Shevchenko